René's URL Explorer Experiment


Title: fixed bug in calculation of percent overshoot by sawyerbfuller · Pull Request #555 · python-control/python-control · GitHub

Open Graph Title: fixed bug in calculation of percent overshoot by sawyerbfuller · Pull Request #555 · python-control/python-control

X Title: fixed bug in calculation of percent overshoot by sawyerbfuller · Pull Request #555 · python-control/python-control

Description: Now it gives the correct result even if the transfer function is not strictly proper. Other changes: step_info now calculates overshoot with respect to dcgain rather than the final (edit: numeric) value of the (computed) step response. adjusted the length of the step response to go for a little longer, to within 0.1% rather than 1% of steady-state, to improve precision of step_info (and updated unit tests) a remark: sys.dcgain() now always returns a complex number because it evaluates at a frequency of zero (1 for DT systems) (as a result of #542?). This returns a real-valued complex number. I think there is a reasonable argument that it should be cast to a float because currently we assume system parameters are real-valued.

Open Graph Description: Now it gives the correct result even if the transfer function is not strictly proper. Other changes: step_info now calculates overshoot with respect to dcgain rather than the final (edit: numeric)...

X Description: Now it gives the correct result even if the transfer function is not strictly proper. Other changes: step_info now calculates overshoot with respect to dcgain rather than the final (edit: numeric)...

Opengraph URL: https://github.com/python-control/python-control/pull/555

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:95800b9a-45a1-33b0-9ac4-01678c18d9ab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAA76:5BE0D:1F36026:2C3BF73:697A5752
html-safe-nonce4a572a4ce098d7575e5d0affa2fd21540950461e0abb3c03fad54ef8fbf296c1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTc2OjVCRTBEOjFGMzYwMjY6MkMzQkY3Mzo2OTdBNTc1MiIsInZpc2l0b3JfaWQiOiI0MzUzNTc1Njg3MDUxNDMzODEwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac769c951e3576b59a8bee1eaa96e1f760e747fec90b17c269ac1a62484fd03ba8
hovercard-subject-tagpull_request:585055011
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/555/files
twitter:imagehttps://avatars.githubusercontent.com/u/58706249?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/58706249?s=400&v=4
og:image:altNow it gives the correct result even if the transfer function is not strictly proper. Other changes: step_info now calculates overshoot with respect to dcgain rather than the final (edit: numeric)...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonea2296221ffa83b7f45f8ba9b62e1aed869492cb43693309e51b8111607e38282
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release46d8a07df71eb59259545c68ce36abf1075d2fca
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/555/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F555%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F555%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/555/files
Reloadhttps://github.com/python-control/python-control/pull/555/files
Reloadhttps://github.com/python-control/python-control/pull/555/files
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
bnavigatorhttps://github.com/bnavigator
python-control:masterhttps://github.com/python-control/python-control/tree/master
sawyerbfuller:fix-stepinfohttps://github.com/sawyerbfuller/python-control/tree/fix-stepinfo
Conversation 6 https://github.com/python-control/python-control/pull/555
Commits 2 https://github.com/python-control/python-control/pull/555/commits
Checks 0 https://github.com/python-control/python-control/pull/555/checks
Files changed https://github.com/python-control/python-control/pull/555/files
Please reload this pagehttps://github.com/python-control/python-control/pull/555/files
fixed bug in calculation of percent overshoot https://github.com/python-control/python-control/pull/555/files#top
Show all changes 2 commits https://github.com/python-control/python-control/pull/555/files
9c87a5b fixed bug in calculation of pct overshoot that neglects not strictly … sawyerbfuller Mar 4, 2021 https://github.com/python-control/python-control/pull/555/commits/9c87a5bdea1d1089db81ad51bc8815a94aa5517a
b36d053 slight adjustment of decay time in step response sawyerbfuller Mar 4, 2021 https://github.com/python-control/python-control/pull/555/commits/b36d0532f147c07a9e6d3bc7bb6a5978f83021ba
Clear filters https://github.com/python-control/python-control/pull/555/files
Please reload this pagehttps://github.com/python-control/python-control/pull/555/files
Please reload this pagehttps://github.com/python-control/python-control/pull/555/files
sisotool_test.py https://github.com/python-control/python-control/pull/555/files#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92
timeresp_test.py https://github.com/python-control/python-control/pull/555/files#diff-ecf5a23a5f3aa1be4faff8673255c1610fd61b011b8ed010e1dc1497e3d8a9b1
timeresp.py https://github.com/python-control/python-control/pull/555/files#diff-3200453f1cf62f183f04dbf39d1129d91245c53a9f74675cee6bd384351c45b4
control/tests/sisotool_test.pyhttps://github.com/python-control/python-control/pull/555/files#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92
View file https://github.com/sawyerbfuller/python-control/blob/b36d0532f147c07a9e6d3bc7bb6a5978f83021ba/control/tests/sisotool_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/555/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/555/files#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92
https://github.com/python-control/python-control/pull/555/files#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92
https://github.com/python-control/python-control/pull/555/files#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92
https://github.com/python-control/python-control/pull/555/files#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92
control/tests/timeresp_test.pyhttps://github.com/python-control/python-control/pull/555/files#diff-ecf5a23a5f3aa1be4faff8673255c1610fd61b011b8ed010e1dc1497e3d8a9b1
View file https://github.com/sawyerbfuller/python-control/blob/b36d0532f147c07a9e6d3bc7bb6a5978f83021ba/control/tests/timeresp_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/555/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/555/files#diff-ecf5a23a5f3aa1be4faff8673255c1610fd61b011b8ed010e1dc1497e3d8a9b1
https://github.com/python-control/python-control/pull/555/files#diff-ecf5a23a5f3aa1be4faff8673255c1610fd61b011b8ed010e1dc1497e3d8a9b1
https://github.com/python-control/python-control/pull/555/files#diff-ecf5a23a5f3aa1be4faff8673255c1610fd61b011b8ed010e1dc1497e3d8a9b1
https://github.com/python-control/python-control/pull/555/files#diff-ecf5a23a5f3aa1be4faff8673255c1610fd61b011b8ed010e1dc1497e3d8a9b1
control/timeresp.pyhttps://github.com/python-control/python-control/pull/555/files#diff-3200453f1cf62f183f04dbf39d1129d91245c53a9f74675cee6bd384351c45b4
View file https://github.com/sawyerbfuller/python-control/blob/b36d0532f147c07a9e6d3bc7bb6a5978f83021ba/control/timeresp.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/555/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/555/files#diff-3200453f1cf62f183f04dbf39d1129d91245c53a9f74675cee6bd384351c45b4
https://github.com/python-control/python-control/pull/555/files#diff-3200453f1cf62f183f04dbf39d1129d91245c53a9f74675cee6bd384351c45b4
https://github.com/python-control/python-control/pull/555/files#diff-3200453f1cf62f183f04dbf39d1129d91245c53a9f74675cee6bd384351c45b4
https://github.com/python-control/python-control/pull/555/files#diff-3200453f1cf62f183f04dbf39d1129d91245c53a9f74675cee6bd384351c45b4
https://github.com/python-control/python-control/pull/555/files#diff-3200453f1cf62f183f04dbf39d1129d91245c53a9f74675cee6bd384351c45b4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.