Title: fixed bug in calculation of percent overshoot by sawyerbfuller · Pull Request #555 · python-control/python-control · GitHub
Open Graph Title: fixed bug in calculation of percent overshoot by sawyerbfuller · Pull Request #555 · python-control/python-control
X Title: fixed bug in calculation of percent overshoot by sawyerbfuller · Pull Request #555 · python-control/python-control
Description: Now it gives the correct result even if the transfer function is not strictly proper. Other changes: step_info now calculates overshoot with respect to dcgain rather than the final (edit: numeric) value of the (computed) step response. adjusted the length of the step response to go for a little longer, to within 0.1% rather than 1% of steady-state, to improve precision of step_info (and updated unit tests) a remark: sys.dcgain() now always returns a complex number because it evaluates at a frequency of zero (1 for DT systems) (as a result of #542?). This returns a real-valued complex number. I think there is a reasonable argument that it should be cast to a float because currently we assume system parameters are real-valued.
Open Graph Description: Now it gives the correct result even if the transfer function is not strictly proper. Other changes: step_info now calculates overshoot with respect to dcgain rather than the final (edit: numeric)...
X Description: Now it gives the correct result even if the transfer function is not strictly proper. Other changes: step_info now calculates overshoot with respect to dcgain rather than the final (edit: numeric)...
Opengraph URL: https://github.com/python-control/python-control/pull/555
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:0a275637-bc38-907b-e931-53ce78e0cf74 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 952E:2333C8:23161B9:2F68CC6:6979A3DC |
| html-safe-nonce | 0b06356e1148ca29b36233de3ec6b9c505a7f0097ee3d6139c46f17940b060bd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTJFOjIzMzNDODoyMzE2MUI5OjJGNjhDQzY6Njk3OUEzREMiLCJ2aXNpdG9yX2lkIjoiMTYxNTQwMDk4MjA1OTUyNTA4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c870c8a055f9dd877eec3109b0f3e85aee990f74321beac8375841df9d18fb3b |
| hovercard-subject-tag | pull_request:585055011 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/555/checks |
| twitter:image | https://avatars.githubusercontent.com/u/58706249?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/58706249?s=400&v=4 |
| og:image:alt | Now it gives the correct result even if the transfer function is not strictly proper. Other changes: step_info now calculates overshoot with respect to dcgain rather than the final (edit: numeric)... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | c049b65ec7e54cbf2521f5a560b6527714c612b0bd169188e2ea6e16f83bd5f4 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87b137883e35e2766c3d0f6a257c4044f6390b83 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width