Title: fix isssues arising in merge of descfcn/iosys changes by murrayrm · Pull Request #540 · python-control/python-control · GitHub
Open Graph Title: fix isssues arising in merge of descfcn/iosys changes by murrayrm · Pull Request #540 · python-control/python-control
X Title: fix isssues arising in merge of descfcn/iosys changes by murrayrm · Pull Request #540 · python-control/python-control
Description: This PR fixes a problem that popped up when merging changes from PR #536 with PR #521 that showed up as test failures in the master branch, as pointed out by @sawyerbfuller in comments in (merged) PR #536. The issue had to do with some pre-processing that was being done for iosys.py but that left a latent bug that showed up in one of the describing function unit tests (having to do with how the input parameter is processed). While fixing that, I also found a bug in the way that the describing function code called an output processing function, so fixed that at the same time. We should review and merge this quickly, since the master branch is currently broken.
Open Graph Description: This PR fixes a problem that popped up when merging changes from PR #536 with PR #521 that showed up as test failures in the master branch, as pointed out by @sawyerbfuller in comments in (merged) ...
X Description: This PR fixes a problem that popped up when merging changes from PR #536 with PR #521 that showed up as test failures in the master branch, as pointed out by @sawyerbfuller in comments in (merged) ...
Opengraph URL: https://github.com/python-control/python-control/pull/540
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:8e5906e1-49f9-6822-5480-710441cd5034 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | CD0C:3A8803:131F347:1B570B1:697A38BF |
| html-safe-nonce | 37a2f950555b8886212227af9362eaaab37c69a439a8684b7124df1a114f3282 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDBDOjNBODgwMzoxMzFGMzQ3OjFCNTcwQjE6Njk3QTM4QkYiLCJ2aXNpdG9yX2lkIjoiNzQyMzU0ODI5MzY3NTM2NjU5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1fae7f9005e5b95cc54c95558ff55f1ac5d3a9db8d2ca5ca40fef63d133f40ff |
| hovercard-subject-tag | pull_request:571499819 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/540/checks |
| twitter:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| og:image:alt | This PR fixes a problem that popped up when merging changes from PR #536 with PR #521 that showed up as test failures in the master branch, as pointed out by @sawyerbfuller in comments in (merged) ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | af6de804ceb83ad30bb9b348cdeaccaa30cdcb566762d5e74e21e2bad88885d0 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2d980605f0959039ddebcbcf522b072508302977 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width