René's URL Explorer Experiment


Title: fix isssues arising in merge of descfcn/iosys changes by murrayrm · Pull Request #540 · python-control/python-control · GitHub

Open Graph Title: fix isssues arising in merge of descfcn/iosys changes by murrayrm · Pull Request #540 · python-control/python-control

X Title: fix isssues arising in merge of descfcn/iosys changes by murrayrm · Pull Request #540 · python-control/python-control

Description: This PR fixes a problem that popped up when merging changes from PR #536 with PR #521 that showed up as test failures in the master branch, as pointed out by @sawyerbfuller in comments in (merged) PR #536. The issue had to do with some pre-processing that was being done for iosys.py but that left a latent bug that showed up in one of the describing function unit tests (having to do with how the input parameter is processed). While fixing that, I also found a bug in the way that the describing function code called an output processing function, so fixed that at the same time. We should review and merge this quickly, since the master branch is currently broken.

Open Graph Description: This PR fixes a problem that popped up when merging changes from PR #536 with PR #521 that showed up as test failures in the master branch, as pointed out by @sawyerbfuller in comments in (merged) ...

X Description: This PR fixes a problem that popped up when merging changes from PR #536 with PR #521 that showed up as test failures in the master branch, as pointed out by @sawyerbfuller in comments in (merged) ...

Opengraph URL: https://github.com/python-control/python-control/pull/540

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8e4d8c64-9b4a-9696-8eea-542bbd8368bd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9D48:3BEA84:1D6D396:27A9B6E:697AAA10
html-safe-nonce5ca256e8f5c9b883ac4c0c7a8328dd0abf343bddaa52890afeeed66b4e442eed
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDQ4OjNCRUE4NDoxRDZEMzk2OjI3QTlCNkU6Njk3QUFBMTAiLCJ2aXNpdG9yX2lkIjoiMjQ4MjIxMjg4ODA1NjA4MDkxMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdf651755d0c3a33d0b11b72747df9ab9cf5e7b47ddae348c747ee3c342acf815
hovercard-subject-tagpull_request:571499819
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/540/files
twitter:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
og:image:altThis PR fixes a problem that popped up when merging changes from PR #536 with PR #521 that showed up as test failures in the master branch, as pointed out by @sawyerbfuller in comments in (merged) ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4d375b6c612de26fd037e0638eaf57e32cf9b16daf53ab68c25c04cd3b058113
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5b310e2c1221fb24ffd3f38a097000863d2dfdd4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/540/changes#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F540%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F540%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/540/changes
Reloadhttps://github.com/python-control/python-control/pull/540/changes
Reloadhttps://github.com/python-control/python-control/pull/540/changes
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
sawyerbfullerhttps://github.com/sawyerbfuller
python-control:masterhttps://github.com/python-control/python-control/tree/master
murrayrm:fix_descfcn_iosys_mergehttps://github.com/murrayrm/python-control/tree/fix_descfcn_iosys_merge
Conversation 0 https://github.com/python-control/python-control/pull/540
Commits 1 https://github.com/python-control/python-control/pull/540/commits
Checks 0 https://github.com/python-control/python-control/pull/540/checks
Files changed https://github.com/python-control/python-control/pull/540/files
Please reload this pagehttps://github.com/python-control/python-control/pull/540/changes
fix isssues arising in merge of descfcn/iosys changes https://github.com/python-control/python-control/pull/540/changes#top
Show all changes 1 commit https://github.com/python-control/python-control/pull/540/files
a586543 fix isssues arising in merge of descfcn/iosys changes murrayrm Feb 11, 2021 https://github.com/python-control/python-control/pull/540/commits/a586543434e029257f3034030e639c94e5339f60
Clear filters https://github.com/python-control/python-control/pull/540/files
Please reload this pagehttps://github.com/python-control/python-control/pull/540/changes
Please reload this pagehttps://github.com/python-control/python-control/pull/540/changes
iosys.py https://github.com/python-control/python-control/pull/540/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
timeresp.py https://github.com/python-control/python-control/pull/540/changes#diff-3200453f1cf62f183f04dbf39d1129d91245c53a9f74675cee6bd384351c45b4
control/iosys.pyhttps://github.com/python-control/python-control/pull/540/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
View file https://github.com/murrayrm/python-control/blob/a586543434e029257f3034030e639c94e5339f60/control/iosys.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/540/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/540/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/540/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/540/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/540/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
control/timeresp.pyhttps://github.com/python-control/python-control/pull/540/changes#diff-3200453f1cf62f183f04dbf39d1129d91245c53a9f74675cee6bd384351c45b4
View file https://github.com/murrayrm/python-control/blob/a586543434e029257f3034030e639c94e5339f60/control/timeresp.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/540/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/540/changes#diff-3200453f1cf62f183f04dbf39d1129d91245c53a9f74675cee6bd384351c45b4
https://github.com/python-control/python-control/pull/540/changes#diff-3200453f1cf62f183f04dbf39d1129d91245c53a9f74675cee6bd384351c45b4
https://github.com/python-control/python-control/pull/540/changes#diff-3200453f1cf62f183f04dbf39d1129d91245c53a9f74675cee6bd384351c45b4
https://github.com/python-control/python-control/pull/540/changes#diff-3200453f1cf62f183f04dbf39d1129d91245c53a9f74675cee6bd384351c45b4
https://github.com/python-control/python-control/pull/540/changes#diff-3200453f1cf62f183f04dbf39d1129d91245c53a9f74675cee6bd384351c45b4
https://github.com/python-control/python-control/pull/540/changes#diff-3200453f1cf62f183f04dbf39d1129d91245c53a9f74675cee6bd384351c45b4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.