René's URL Explorer Experiment


Title: fix rlocus timeout due to inefficient _default_wn calculation by murrayrm · Pull Request #527 · python-control/python-control · GitHub

Open Graph Title: fix rlocus timeout due to inefficient _default_wn calculation by murrayrm · Pull Request #527 · python-control/python-control

X Title: fix rlocus timeout due to inefficient _default_wn calculation by murrayrm · Pull Request #527 · python-control/python-control

Description: This PR fixes an obscure bug that got pointed out to me a year ago in e-mail from a colleague in Costa Rica: I have a piece of code that I run for my students. I downloaded the latest control module and it does not print the root locus any more. I think it gets stuck in an iterative process. Nothing changed in the code. I suppose something in the updated version is causing the problem. Has anybody else made a complaint about the root locus? Turns out that the problem was that he had a very unusual pole/zero pattern in which the algorithm for computing the default natural frequencies to use in plotting the grid was introduced in PR #138. The code essentially used the x-axis major ticks as the starting point for the natural frequencies and then added additional ticks to "complete" the frequencies on the y axis. The problem was that if the x-axis had tick marks that were orders of magnitude different that the y-axis, this could generate a lot of additional natural frequencies (which were subsequently removed a later point in the code). I didn't want to spend a lot of time on this fix, so I basically put in a check to see when you might end up generating an excessive number of ticks based on this heuristic and switched things so that if that happens, you use the y-axis ticks as the starting point. There's a unit test to make sure it is working right (that also covers the new code).

Open Graph Description: This PR fixes an obscure bug that got pointed out to me a year ago in e-mail from a colleague in Costa Rica: I have a piece of code that I run for my students. I downloaded the latest control modu...

X Description: This PR fixes an obscure bug that got pointed out to me a year ago in e-mail from a colleague in Costa Rica: I have a piece of code that I run for my students. I downloaded the latest control modu...

Opengraph URL: https://github.com/python-control/python-control/pull/527

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ad8d8916-d4c7-d387-e40e-9dbfb5cc0343
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE2CC:316698:E6C527:13436A7:697C069C
html-safe-nonce0ca80a6e8d04c196b93dc6949278618c2d084cfc7088674e21002fb892b8c1c7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkNDOjMxNjY5ODpFNkM1Mjc6MTM0MzZBNzo2OTdDMDY5QyIsInZpc2l0b3JfaWQiOiI4OTkyMTM5NzkxMjA1OTI2NTU2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacde61425ea1558a809fe114bd2736fc6368f56ed6899890783044fc721d7e465d
hovercard-subject-tagpull_request:564516586
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/527/files
twitter:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
og:image:altThis PR fixes an obscure bug that got pointed out to me a year ago in e-mail from a colleague in Costa Rica: I have a piece of code that I run for my students. I downloaded the latest control modu...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneda4f0ee56809799586f8ee546b27f94fe9b5893edfbf87732e82be45be013b52
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2d0972e08a3f8dfff1c4bf1f3d026a7d3a209c26
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/527/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F527%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F527%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/527/files
Reloadhttps://github.com/python-control/python-control/pull/527/files
Reloadhttps://github.com/python-control/python-control/pull/527/files
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
bnavigatorhttps://github.com/bnavigator
python-control:masterhttps://github.com/python-control/python-control/tree/master
murrayrm:fix_rlocus_timeouthttps://github.com/murrayrm/python-control/tree/fix_rlocus_timeout
Conversation 1 https://github.com/python-control/python-control/pull/527
Commits 1 https://github.com/python-control/python-control/pull/527/commits
Checks 0 https://github.com/python-control/python-control/pull/527/checks
Files changed https://github.com/python-control/python-control/pull/527/files
Please reload this pagehttps://github.com/python-control/python-control/pull/527/files
fix rlocus timeout due to inefficient _default_wn calculation https://github.com/python-control/python-control/pull/527/files#top
Show all changes 1 commit https://github.com/python-control/python-control/pull/527/files
4ef4906 fix rlocus timeout due to inefficient _default_wn calculation murrayrm Jan 30, 2021 https://github.com/python-control/python-control/pull/527/commits/4ef490620efef1b20f291acd4b1446dc37aa6527
Clear filters https://github.com/python-control/python-control/pull/527/files
Please reload this pagehttps://github.com/python-control/python-control/pull/527/files
Please reload this pagehttps://github.com/python-control/python-control/pull/527/files
rlocus.py https://github.com/python-control/python-control/pull/527/files#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee
rlocus_test.py https://github.com/python-control/python-control/pull/527/files#diff-14191ee376d7e0c4ef10224e6883edc949e6195f7700198a8599b57cf96fd414
control/rlocus.pyhttps://github.com/python-control/python-control/pull/527/files#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee
View file https://github.com/murrayrm/python-control/blob/4ef490620efef1b20f291acd4b1446dc37aa6527/control/rlocus.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/527/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/527/files#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee
https://github.com/python-control/python-control/pull/527/files#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee
https://github.com/python-control/python-control/pull/527/files#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee
https://github.com/python-control/python-control/pull/527/files#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee
https://github.com/python-control/python-control/pull/527/files#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee
https://github.com/python-control/python-control/pull/527/files#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee
https://github.com/python-control/python-control/pull/527/files#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee
control/tests/rlocus_test.pyhttps://github.com/python-control/python-control/pull/527/files#diff-14191ee376d7e0c4ef10224e6883edc949e6195f7700198a8599b57cf96fd414
View file https://github.com/murrayrm/python-control/blob/4ef490620efef1b20f291acd4b1446dc37aa6527/control/tests/rlocus_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/527/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/527/files#diff-14191ee376d7e0c4ef10224e6883edc949e6195f7700198a8599b57cf96fd414
https://github.com/python-control/python-control/pull/527/files#diff-14191ee376d7e0c4ef10224e6883edc949e6195f7700198a8599b57cf96fd414
https://github.com/python-control/python-control/pull/527/files#diff-14191ee376d7e0c4ef10224e6883edc949e6195f7700198a8599b57cf96fd414
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.