| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e309c945-b63e-d91e-a66b-e85fdefaca60 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E258:241DC6:99B85B:D13380:697B086C |
| html-safe-nonce | fc925ed64be3448e272b57f1ea82e35472e1ca4598bdf708273c77acdf0ddeeb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjU4OjI0MURDNjo5OUI4NUI6RDEzMzgwOjY5N0IwODZDIiwidmlzaXRvcl9pZCI6IjgwMTg4OTQwNDcyNDQxMjYzMTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 79dced18af5aa744ca94c9a1ce58ceb089ade1cc536ca75381663666fb7d20ab |
| hovercard-subject-tag | pull_request:555491598 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-control/python-control/509/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9505ccfd0f6da62c53985377a98198d996c1fb0b7f85e50b4e1f11950bf51def/python-control/python-control/pull/509 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9505ccfd0f6da62c53985377a98198d996c1fb0b7f85e50b4e1f11950bf51def/python-control/python-control/pull/509 |
| og:image:alt | This PR resolves issue #244. It looks like the only issue was that converting a constant to a state space object was creating an extra state and this state had to then be removed. By creating a s... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | murrayrm |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7ce8ed0a54c4730aeca4e6abacfc6490365fc42e25480b86883054df3f9181c8 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d7bfc78137af9a4828305e52ab993fce981d7085 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python-control/python-control/pull/509#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F509 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F509 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-control%2Fpython-control |
| Reload | https://github.com/python-control/python-control/pull/509 |
| Reload | https://github.com/python-control/python-control/pull/509 |
| Reload | https://github.com/python-control/python-control/pull/509 |
|
python-control
| https://github.com/python-control |
| python-control | https://github.com/python-control/python-control |
|
Notifications
| https://github.com/login?return_to=%2Fpython-control%2Fpython-control |
|
Fork
447
| https://github.com/login?return_to=%2Fpython-control%2Fpython-control |
|
Star
2k
| https://github.com/login?return_to=%2Fpython-control%2Fpython-control |
|
Code
| https://github.com/python-control/python-control |
|
Issues
87
| https://github.com/python-control/python-control/issues |
|
Pull requests
8
| https://github.com/python-control/python-control/pulls |
|
Discussions
| https://github.com/python-control/python-control/discussions |
|
Actions
| https://github.com/python-control/python-control/actions |
|
Projects
0
| https://github.com/python-control/python-control/projects |
|
Wiki
| https://github.com/python-control/python-control/wiki |
|
Security
0
| https://github.com/python-control/python-control/security |
|
Insights
| https://github.com/python-control/python-control/pulse |
|
Code
| https://github.com/python-control/python-control |
|
Issues
| https://github.com/python-control/python-control/issues |
|
Pull requests
| https://github.com/python-control/python-control/pulls |
|
Discussions
| https://github.com/python-control/python-control/discussions |
|
Actions
| https://github.com/python-control/python-control/actions |
|
Projects
| https://github.com/python-control/python-control/projects |
|
Wiki
| https://github.com/python-control/python-control/wiki |
|
Security
| https://github.com/python-control/python-control/security |
|
Insights
| https://github.com/python-control/python-control/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python-control/python-control/pull/509#issue-comment-box |
| bnavigator | https://github.com/bnavigator |
| python-control:master | https://github.com/python-control/python-control/tree/master |
| murrayrm:dont_remove_useless_states | https://github.com/murrayrm/python-control/tree/dont_remove_useless_states |
|
change default value of statesp.remove_useless_states to False
| https://github.com/python-control/python-control/pull/509#top |
| bnavigator | https://github.com/bnavigator |
| python-control:master | https://github.com/python-control/python-control/tree/master |
| murrayrm:dont_remove_useless_states | https://github.com/murrayrm/python-control/tree/dont_remove_useless_states |
|
Conversation
2
| https://github.com/python-control/python-control/pull/509 |
|
Commits
2
| https://github.com/python-control/python-control/pull/509/commits |
|
Checks
0
| https://github.com/python-control/python-control/pull/509/checks |
|
Files changed
| https://github.com/python-control/python-control/pull/509/files |
| Please reload this page | https://github.com/python-control/python-control/pull/509 |
| https://github.co/hiddenchars |
| https://github.com/python-control/python-control/pull/{{ revealButtonHref }} |
|
| https://github.com/murrayrm |
| murrayrm | https://github.com/murrayrm |
| Jan 15, 2021 | https://github.com/python-control/python-control/pull/509#issue-786648649 |
| Please reload this page | https://github.com/python-control/python-control/pull/509 |
| #244 | https://github.com/python-control/python-control/issues/244 |
| Please reload this page | https://github.com/python-control/python-control/pull/509 |
|
| https://github.com/murrayrm |
| change default value of statesp.remove_useless_states to False | https://github.com/python-control/python-control/pull/509/commits/114bce6499a05f4fd3d4d2dee2818e9aaa9964f2 |
| 114bce6 | https://github.com/python-control/python-control/pull/509/commits/114bce6499a05f4fd3d4d2dee2818e9aaa9964f2 |
| https://github.com/coveralls |
| coveralls | https://github.com/coveralls |
| Jan 15, 2021 | https://github.com/python-control/python-control/pull/509#issuecomment-760696263 |
| Please reload this page | https://github.com/python-control/python-control/pull/509 |
| https://coveralls.io/builds/36359911 |
| b7945f3 | https://github.com/python-control/python-control/commit/b7945f3b39ef61d88e6a4ce6137e3de1c281aedd |
| ad0a0eb | https://github.com/python-control/python-control/commit/ad0a0eb0970fe6031ad8c95fd52027699009806e |
| Please reload this page | https://github.com/python-control/python-control/pull/509 |
| https://github.com/sawyerbfuller |
| sawyerbfuller | https://github.com/sawyerbfuller |
|
Jan 15, 2021
| https://github.com/python-control/python-control/pull/509#pullrequestreview-569161644 |
|
View reviewed changes
| https://github.com/python-control/python-control/pull/509/files/114bce6499a05f4fd3d4d2dee2818e9aaa9964f2 |
| https://github.com/bnavigator |
| bnavigator | https://github.com/bnavigator |
|
Jan 15, 2021
| https://github.com/python-control/python-control/pull/509#pullrequestreview-569203017 |
|
View reviewed changes
| https://github.com/python-control/python-control/pull/509/files/114bce6499a05f4fd3d4d2dee2818e9aaa9964f2 |
| control/tests/statesp_test.py | https://github.com/python-control/python-control/pull/509/files/114bce6499a05f4fd3d4d2dee2818e9aaa9964f2#diff-4c76080acbdea36493458693d93ec10e4e10b2e04ce01c56e8a81567cc1ea0d6 |
| bnavigator | https://github.com/bnavigator |
| Jan 15, 2021 | https://github.com/python-control/python-control/pull/509#discussion_r558264123 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python-control/python-control/pull/509 |
|
| https://github.com/murrayrm |
| added missing unit test | https://github.com/python-control/python-control/pull/509/commits/b7945f3b39ef61d88e6a4ce6137e3de1c281aedd |
| b7945f3 | https://github.com/python-control/python-control/pull/509/commits/b7945f3b39ef61d88e6a4ce6137e3de1c281aedd |
| https://github.com/bnavigator |
| bnavigator | https://github.com/bnavigator |
| b47ed08 | https://github.com/python-control/python-control/commit/b47ed087d20dc036624964b6b8a4c3642303c6d9 |
| Jan 15, 2021 | https://github.com/python-control/python-control/pull/509#event-4212917394 |
| https://github.com/murrayrm |
| murrayrm | https://github.com/murrayrm |
| January 15, 2021 22:03 | https://github.com/python-control/python-control/pull/509#event-4213118287 |
| https://github.com/murrayrm |
| murrayrm | https://github.com/murrayrm |
|
Jan 18, 2021
| https://github.com/python-control/python-control/pull/509#ref-issue-380643422 |
|
StateSpace constructor should not call _remove_useless_states
#244
| https://github.com/python-control/python-control/issues/244 |
| https://github.com/bnavigator |
| bnavigator | https://github.com/bnavigator |
|
Jan 30, 2021
| https://github.com/python-control/python-control/pull/509#ref-issue-797516727 |
|
Undesired model reduction
#526
| https://github.com/python-control/python-control/issues/526 |
| https://github.com/murrayrm |
| murrayrm | https://github.com/murrayrm |
| 0.9.0 | https://github.com/python-control/python-control/milestone/8 |
| Mar 20, 2021 | https://github.com/python-control/python-control/pull/509#event-4485758695 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F509 |
|
| https://github.com/bnavigator |
|
bnavigator
| https://github.com/bnavigator |
|
| https://github.com/python-control/python-control/pull/509/files/114bce6499a05f4fd3d4d2dee2818e9aaa9964f2 |
|
| https://github.com/sawyerbfuller |
|
sawyerbfuller
| https://github.com/sawyerbfuller |
|
| https://github.com/python-control/python-control/pull/509/files/114bce6499a05f4fd3d4d2dee2818e9aaa9964f2 |
|
0.9.0
| https://github.com/python-control/python-control/milestone/8 |
| Please reload this page | https://github.com/python-control/python-control/pull/509 |
|
| https://github.com/murrayrm |
|
| https://github.com/coveralls |
|
| https://github.com/bnavigator |
|
| https://github.com/sawyerbfuller |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |