René's URL Explorer Experiment


Title: generate error for tf2ss of non-proper transfer function by murrayrm · Pull Request #492 · python-control/python-control · GitHub

Open Graph Title: generate error for tf2ss of non-proper transfer function by murrayrm · Pull Request #492 · python-control/python-control

X Title: generate error for tf2ss of non-proper transfer function by murrayrm · Pull Request #492 · python-control/python-control

Description: This PR resolves issue #399 when tf2io is called with a non-proper transfer function (which cannot be represented as a state space system). The underlying issue turned out to be in tf2ss, which had the same bug and was probably introduced in PR #370 when we started allowing non-proper transfer functions. Added unit tests to catch the case and then fixed them by generating a ValueError when you try to convert a non-proper transfer function into a StateSpace object. Also did some PEP8 cleanup on statesp.py.

Open Graph Description: This PR resolves issue #399 when tf2io is called with a non-proper transfer function (which cannot be represented as a state space system). The underlying issue turned out to be in tf2ss, which ha...

X Description: This PR resolves issue #399 when tf2io is called with a non-proper transfer function (which cannot be represented as a state space system). The underlying issue turned out to be in tf2ss, which ha...

Opengraph URL: https://github.com/python-control/python-control/pull/492

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d8db2d5a-8574-b76b-3502-4bf4d138b1f6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE004:1857DE:1F72D84:2C61470:697A565D
html-safe-nonce4d2d9520f8016923d38934de9078052e50a33793769a70b9a646df30ae4821c2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDA0OjE4NTdERToxRjcyRDg0OjJDNjE0NzA6Njk3QTU2NUQiLCJ2aXNpdG9yX2lkIjoiMjkwMjcxNTUwMDg3MTcwMjEwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac164df950c94a75950ecd62ccb77ccbffb3d73c90fd30641ce3ce9a0be4eaa000
hovercard-subject-tagpull_request:547265455
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/492/files
twitter:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
og:image:altThis PR resolves issue #399 when tf2io is called with a non-proper transfer function (which cannot be represented as a state space system). The underlying issue turned out to be in tf2ss, which ha...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonea2296221ffa83b7f45f8ba9b62e1aed869492cb43693309e51b8111607e38282
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release46d8a07df71eb59259545c68ce36abf1075d2fca
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/492/changes#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F492%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F492%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/492/changes
Reloadhttps://github.com/python-control/python-control/pull/492/changes
Reloadhttps://github.com/python-control/python-control/pull/492/changes
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
bnavigatorhttps://github.com/bnavigator
python-control:masterhttps://github.com/python-control/python-control/tree/master
murrayrm:iosys-nonproper-tfhttps://github.com/murrayrm/python-control/tree/iosys-nonproper-tf
Conversation 3 https://github.com/python-control/python-control/pull/492
Commits 2 https://github.com/python-control/python-control/pull/492/commits
Checks 0 https://github.com/python-control/python-control/pull/492/checks
Files changed https://github.com/python-control/python-control/pull/492/files
Please reload this pagehttps://github.com/python-control/python-control/pull/492/changes
generate error for tf2ss of non-proper transfer function https://github.com/python-control/python-control/pull/492/changes#top
Show all changes 2 commits https://github.com/python-control/python-control/pull/492/files
8c707dd generate error for tf2ss of non-proper transfer function + PEP8 cleanup murrayrm Dec 31, 2020 https://github.com/python-control/python-control/pull/492/commits/8c707dd91459ed888fe459985fa3891315040fec
9c409eb Merge branch 'master' into iosys-nonproper-tf bnavigator Dec 31, 2020 https://github.com/python-control/python-control/pull/492/commits/9c409ebfcac4dfc54847058b77b574911e9365e1
Clear filters https://github.com/python-control/python-control/pull/492/files
Please reload this pagehttps://github.com/python-control/python-control/pull/492/changes
Please reload this pagehttps://github.com/python-control/python-control/pull/492/changes
statesp.py https://github.com/python-control/python-control/pull/492/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
convert_test.py https://github.com/python-control/python-control/pull/492/changes#diff-cebcec17ebc58131080d1e205ff7eb7dd87a5354def1adb46964e2a5c08a2140
iosys_test.py https://github.com/python-control/python-control/pull/492/changes#diff-2d9f6fd1b76261b8663bd7fa89565809a728c32edd8b0f6e095177f80b6e5100
Please reload this pagehttps://github.com/python-control/python-control/pull/492/changes
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.