René's URL Explorer Experiment


Title: Fix pzmap grid (matplotlib angle_helper) by bnavigator · Pull Request #456 · python-control/python-control · GitHub

Open Graph Title: Fix pzmap grid (matplotlib angle_helper) by bnavigator · Pull Request #456 · python-control/python-control

X Title: Fix pzmap grid (matplotlib angle_helper) by bnavigator · Pull Request #456 · python-control/python-control

Description: CI runs started to fail today with: Traceback (most recent call last): 959 File "pvtol-nested.py", line 169, in 960 P, Z = pzmap(T, plot=True, grid=True) 961 File "/home/travis/build/python-control/python-control/control/pzmap.py", line 106, in pzmap 962 ax, fig = sgrid() 963 File "/home/travis/build/python-control/python-control/control/grid.py", line 82, in sgrid 964 ax.axis["wnxneg"] = axis = ax.new_floating_axis(0, 180) 965 File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/mpl_toolkits/axisartist/axislines.py", line 575, in new_floating_axis 966 axes=self) 967 File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/mpl_toolkits/axisartist/grid_helper_curvelinear.py", line 350, in new_floating_axis 968 axisline = AxisArtist(axes, _helper) 969 File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/mpl_toolkits/axisartist/axis_artist.py", line 746, in __init__ 970 self._init_line() 971 File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/mpl_toolkits/axisartist/axis_artist.py", line 887, in _init_line 972 self._axis_artist_helper.get_line(self.axes), 973 File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/mpl_toolkits/axisartist/grid_helper_curvelinear.py", line 270, in get_line 974 self.update_lim(axes) 975 File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/mpl_toolkits/axisartist/grid_helper_curvelinear.py", line 101, in update_lim 976 self.grid_helper.update_lim(axes) 977 File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/mpl_toolkits/axisartist/axislines.py", line 327, in update_lim 978 self._update(x1, x2, y1, y2) 979 File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/mpl_toolkits/axisartist/grid_helper_curvelinear.py", line 319, in _update 980 self._update_grid(x1, y1, x2, y2) 981 File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/mpl_toolkits/axisartist/grid_helper_curvelinear.py", line 367, in _update_grid 982 self.grid_info = self.grid_finder.get_grid_info(x1, y1, x2, y2) 983 File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/mpl_toolkits/axisartist/grid_finder.py", line 104, in get_grid_info 984 extremes = self.extreme_finder(self.inv_transform_xy, x1, y1, x2, y2) 985 File "/home/travis/build/python-control/python-control/control/grid.py", line 44, in __call__ 986 self._adjust_extremes(lon_min, lon_max, lat_min, lat_max) 987AttributeError: 'ModifiedExtremeFinderCycle' object has no attribute '_adjust_extremes' Apparently Matplotlib removed the private function _adjust_extremes between 3.2 and 3.3 (I could not find the commit yet. Clicking blame on github doesn't work. Their git history is weird). The specific branch of pzmap and this portion of grid.py are not covered by the unit tests. Hence it was not discovered until now, when conda updated matplotlib and it fails in the pvtol-nested.pyexample.

Open Graph Description: CI runs started to fail today with: Traceback (most recent call last): 959 File "pvtol-nested.py", line 169, in <module> 960 P, Z = pzmap(T, plot=True, grid=True) 961 File &quo...

X Description: CI runs started to fail today with: Traceback (most recent call last): 959 File &quot;pvtol-nested.py&quot;, line 169, in &lt;module&gt; 960 P, Z = pzmap(T, plot=True, grid=True...

Opengraph URL: https://github.com/python-control/python-control/pull/456

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:79ed9c8e-d400-e408-8daf-a00098bcaa5a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA024:E89DE:1E0EBB:299B8E:697BBAE6
html-safe-nonce207b083afca8bc09441bba341c42ebd9bb0a932a04a864782e241bb0e1b93680
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDI0OkU4OURFOjFFMEVCQjoyOTlCOEU6Njk3QkJBRTYiLCJ2aXNpdG9yX2lkIjoiMTYyMjg2ODc0OTA3MTM5OTY1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac13c4d4c2e2f8b1ab8ec2a4228c06c2bd20ef48a1196a2537bf68e603f13de886
hovercard-subject-tagpull_request:471192951
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/456/files
twitter:imagehttps://avatars.githubusercontent.com/u/4623504?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4623504?s=400&v=4
og:image:altCI runs started to fail today with: Traceback (most recent call last): 959 File "pvtol-nested.py", line 169, in <module> 960 P, Z = pzmap(T, plot=True, grid=True) 961 File &quo...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneab413746e1b95376981dfec4a04b2384a611b96affe802ee3ee6d752200afbb1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebea0e0f1995ab0bb7fa336572c353032cf897ec1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/456/changes#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F456%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F456%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/456/changes
Reloadhttps://github.com/python-control/python-control/pull/456/changes
Reloadhttps://github.com/python-control/python-control/pull/456/changes
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
bnavigatorhttps://github.com/bnavigator
python-control:masterhttps://github.com/python-control/python-control/tree/master
bnavigator:fix-mpl-gridhttps://github.com/bnavigator/python-control/tree/fix-mpl-grid
Conversation 5 https://github.com/python-control/python-control/pull/456
Commits 5 https://github.com/python-control/python-control/pull/456/commits
Checks 0 https://github.com/python-control/python-control/pull/456/checks
Files changed https://github.com/python-control/python-control/pull/456/files
Please reload this pagehttps://github.com/python-control/python-control/pull/456/changes
Fix pzmap grid (matplotlib angle_helper) https://github.com/python-control/python-control/pull/456/changes#top
Show all changes 5 commits https://github.com/python-control/python-control/pull/456/files
df0051c update mpl_toolkit function bnavigator Aug 20, 2020 https://github.com/python-control/python-control/pull/456/commits/df0051c2849bc7accf772ee80faeb752b0478002
abc0c3c fix grid formatter bnavigator Aug 20, 2020 https://github.com/python-control/python-control/pull/456/commits/abc0c3c002b485b2a05101a8459628ad9eafe333
bdbd198 fix wrong config read on pzmap bnavigator Aug 20, 2020 https://github.com/python-control/python-control/pull/456/commits/bdbd1985bbb07f5877825f956aeb13ab765094f4
2ca5220 add pzmap_test bnavigator Aug 20, 2020 https://github.com/python-control/python-control/pull/456/commits/2ca522083594993c91db98f700ce8c43b86a77fd
5632796 test for correct grid and no plot. fix pzmap config handling bnavigator Aug 20, 2020 https://github.com/python-control/python-control/pull/456/commits/5632796bea9d6047b2b5cfdf0df4b54545840905
Clear filters https://github.com/python-control/python-control/pull/456/files
Please reload this pagehttps://github.com/python-control/python-control/pull/456/changes
Please reload this pagehttps://github.com/python-control/python-control/pull/456/changes
grid.py https://github.com/python-control/python-control/pull/456/changes#diff-2a2bfe804c121e19d428ee5dcb9410d07ba02ef20f3080cc5175faf78076bbdd
pzmap.py https://github.com/python-control/python-control/pull/456/changes#diff-fdd48a8f4e62116d8bb53ab21c499352f4dcb4b95f632e002126d869a10ba722
conftest.py https://github.com/python-control/python-control/pull/456/changes#diff-46cc9b089adc87a3de027b2fed38cb50baf58ec8ac60d6ce9459d7501ba001cb
pzmap_test.py https://github.com/python-control/python-control/pull/456/changes#diff-4f4187c4a377622a547d531dfcc044558eabeb876cbb61623768fa9581d3ea08
control/grid.pyhttps://github.com/python-control/python-control/pull/456/changes#diff-2a2bfe804c121e19d428ee5dcb9410d07ba02ef20f3080cc5175faf78076bbdd
View file https://github.com/bnavigator/python-control/blob/5632796bea9d6047b2b5cfdf0df4b54545840905/control/grid.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/456/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/456/changes#diff-2a2bfe804c121e19d428ee5dcb9410d07ba02ef20f3080cc5175faf78076bbdd
https://github.com/python-control/python-control/pull/456/changes#diff-2a2bfe804c121e19d428ee5dcb9410d07ba02ef20f3080cc5175faf78076bbdd
https://github.com/python-control/python-control/pull/456/changes#diff-2a2bfe804c121e19d428ee5dcb9410d07ba02ef20f3080cc5175faf78076bbdd
control/pzmap.pyhttps://github.com/python-control/python-control/pull/456/changes#diff-fdd48a8f4e62116d8bb53ab21c499352f4dcb4b95f632e002126d869a10ba722
View file https://github.com/bnavigator/python-control/blob/5632796bea9d6047b2b5cfdf0df4b54545840905/control/pzmap.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/456/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/456/changes#diff-fdd48a8f4e62116d8bb53ab21c499352f4dcb4b95f632e002126d869a10ba722
https://github.com/python-control/python-control/pull/456/changes#diff-fdd48a8f4e62116d8bb53ab21c499352f4dcb4b95f632e002126d869a10ba722
https://github.com/python-control/python-control/pull/456/changes#diff-fdd48a8f4e62116d8bb53ab21c499352f4dcb4b95f632e002126d869a10ba722
https://github.com/python-control/python-control/pull/456/changes#diff-fdd48a8f4e62116d8bb53ab21c499352f4dcb4b95f632e002126d869a10ba722
control/tests/conftest.pyhttps://github.com/python-control/python-control/pull/456/changes#diff-46cc9b089adc87a3de027b2fed38cb50baf58ec8ac60d6ce9459d7501ba001cb
View file https://github.com/bnavigator/python-control/blob/5632796bea9d6047b2b5cfdf0df4b54545840905/control/tests/conftest.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/456/{{ revealButtonHref }}
control/tests/pzmap_test.pyhttps://github.com/python-control/python-control/pull/456/changes#diff-4f4187c4a377622a547d531dfcc044558eabeb876cbb61623768fa9581d3ea08
View file https://github.com/bnavigator/python-control/blob/5632796bea9d6047b2b5cfdf0df4b54545840905/control/tests/pzmap_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/456/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.