René's URL Explorer Experiment


Title: improved default time vector for time response functions that takes zeros into account. by sawyerbfuller · Pull Request #454 · python-control/python-control · GitHub

Open Graph Title: improved default time vector for time response functions that takes zeros into account. by sawyerbfuller · Pull Request #454 · python-control/python-control

X Title: improved default time vector for time response functions that takes zeros into account. by sawyerbfuller · Pull Request #454 · python-control/python-control

Description: Improves the calculation of the default time vector used in timeresp functions, e.g. step_response. Inspired by problems that appeared in #440 with pole-zero cancellations confusing the step response default time vector computation. I combined the logic & glue from #420 with Ilayn's code from here that does a more thorough job computing default trinal and dt: https://github.com/ilayn/harold/blob/master/harold/_time_domain.py#L280-L454 a bit of docstring cleanup too. @ilayn please let me know if you're not ok with having your code pasted in like this (I noted in the code that it is your work), or if licensing information needs to be added, thanks.

Open Graph Description: Improves the calculation of the default time vector used in timeresp functions, e.g. step_response. Inspired by problems that appeared in #440 with pole-zero cancellations confusing the step respon...

X Description: Improves the calculation of the default time vector used in timeresp functions, e.g. step_response. Inspired by problems that appeared in #440 with pole-zero cancellations confusing the step respon...

Opengraph URL: https://github.com/python-control/python-control/pull/454

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e1c1574f-6680-fbc6-af8a-59ed7066007a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id838E:DEBC:4FD12C:6F2F5B:697B46D1
html-safe-nonceef293b54809a0629cf4253f49699cc7f251e0189cb7854cf5b0e93f6dddfb47c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzhFOkRFQkM6NEZEMTJDOjZGMkY1Qjo2OTdCNDZEMSIsInZpc2l0b3JfaWQiOiI4NTAzMDg5NTUxODg1NjgyMzg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac62cbbb68109db14885819d7d48fff6c70180b6f1eadbc979a367de23ec529a78
hovercard-subject-tagpull_request:469236307
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/454/files
twitter:imagehttps://avatars.githubusercontent.com/u/58706249?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/58706249?s=400&v=4
og:image:altImproves the calculation of the default time vector used in timeresp functions, e.g. step_response. Inspired by problems that appeared in #440 with pole-zero cancellations confusing the step respon...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None6fe64d94889230be19a900846cfc91707e7dd4206878d6c208922b46a6b0735d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release35925b5d54d957e7d3b7f55916450a693827ca42
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/454/changes#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F454%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F454%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/454/changes
Reloadhttps://github.com/python-control/python-control/pull/454/changes
Reloadhttps://github.com/python-control/python-control/pull/454/changes
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
murrayrmhttps://github.com/murrayrm
python-control:masterhttps://github.com/python-control/python-control/tree/master
sawyerbfuller:better-tfinalhttps://github.com/sawyerbfuller/python-control/tree/better-tfinal
Conversation 29 https://github.com/python-control/python-control/pull/454
Commits 7 https://github.com/python-control/python-control/pull/454/commits
Checks 0 https://github.com/python-control/python-control/pull/454/checks
Files changed https://github.com/python-control/python-control/pull/454/files
Please reload this pagehttps://github.com/python-control/python-control/pull/454/changes
improved default time vector for time response functions that takes zeros into account. https://github.com/python-control/python-control/pull/454/changes#top
Show all changes 7 commits https://github.com/python-control/python-control/pull/454/files
9658e0f beginnings of code starts with a docstring sawyerbfuller Aug 17, 2020 https://github.com/python-control/python-control/pull/454/commits/9658e0f55759b5c511bb152941329df47c978975
afdc5e3 first commit that adds ilayn's default time for step code bnavigator Aug 18, 2020 https://github.com/python-control/python-control/pull/454/commits/afdc5e34857a79c8bef438e136075cb53034188d
a6cac86 Update control/timeresp.py sawyerbfuller Aug 19, 2020 https://github.com/python-control/python-control/pull/454/commits/a6cac86a4252be4e22800c7c9c00c798918821b0
65ee5ed removed one more unicode symbol sawyerbfuller Aug 19, 2020 https://github.com/python-control/python-control/pull/454/commits/65ee5ed6130f9a279ef5d76e6eabbf3544166ba1
3d25b8b more unicode expulsion sawyerbfuller Aug 19, 2020 https://github.com/python-control/python-control/pull/454/commits/3d25b8b06d2e42da3b78da67f139ead92c8d1ab9
23d90d6 curse you python 2. removed '@' sign sawyerbfuller Aug 19, 2020 https://github.com/python-control/python-control/pull/454/commits/23d90d652113c15fd8e28b6ade1b37f0b3cd1e8f
c588cdc Update control/xferfcn.py sawyerbfuller Aug 24, 2020 https://github.com/python-control/python-control/pull/454/commits/c588cdcc674a8b7bb42db22a3b4939120d22e272
Clear filters https://github.com/python-control/python-control/pull/454/files
Please reload this pagehttps://github.com/python-control/python-control/pull/454/changes
Please reload this pagehttps://github.com/python-control/python-control/pull/454/changes
statesp.py https://github.com/python-control/python-control/pull/454/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
sisotool_test.py https://github.com/python-control/python-control/pull/454/changes#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92
timeresp_test.py https://github.com/python-control/python-control/pull/454/changes#diff-ecf5a23a5f3aa1be4faff8673255c1610fd61b011b8ed010e1dc1497e3d8a9b1
timeresp.py https://github.com/python-control/python-control/pull/454/changes#diff-3200453f1cf62f183f04dbf39d1129d91245c53a9f74675cee6bd384351c45b4
xferfcn.py https://github.com/python-control/python-control/pull/454/changes#diff-0dd9424d3024fc1d5cc8fd67d13efe5703318c4c705526ab0ae216de69ce3de7
control/statesp.pyhttps://github.com/python-control/python-control/pull/454/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
View file https://github.com/sawyerbfuller/python-control/blob/c588cdcc674a8b7bb42db22a3b4939120d22e272/control/statesp.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/454/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/454/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/454/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
control/tests/sisotool_test.pyhttps://github.com/python-control/python-control/pull/454/changes#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92
View file https://github.com/sawyerbfuller/python-control/blob/c588cdcc674a8b7bb42db22a3b4939120d22e272/control/tests/sisotool_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/454/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/454/changes#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92
https://github.com/python-control/python-control/pull/454/changes#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92
https://github.com/python-control/python-control/pull/454/changes#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92
https://github.com/python-control/python-control/pull/454/changes#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92
control/tests/timeresp_test.pyhttps://github.com/python-control/python-control/pull/454/changes#diff-ecf5a23a5f3aa1be4faff8673255c1610fd61b011b8ed010e1dc1497e3d8a9b1
View file https://github.com/sawyerbfuller/python-control/blob/c588cdcc674a8b7bb42db22a3b4939120d22e272/control/tests/timeresp_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/454/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/454/changes#diff-ecf5a23a5f3aa1be4faff8673255c1610fd61b011b8ed010e1dc1497e3d8a9b1
https://github.com/python-control/python-control/pull/454/changes#diff-ecf5a23a5f3aa1be4faff8673255c1610fd61b011b8ed010e1dc1497e3d8a9b1
https://github.com/python-control/python-control/pull/454/changes#diff-ecf5a23a5f3aa1be4faff8673255c1610fd61b011b8ed010e1dc1497e3d8a9b1
https://github.com/python-control/python-control/pull/454/changes#diff-ecf5a23a5f3aa1be4faff8673255c1610fd61b011b8ed010e1dc1497e3d8a9b1
https://github.com/python-control/python-control/pull/454/changes#diff-ecf5a23a5f3aa1be4faff8673255c1610fd61b011b8ed010e1dc1497e3d8a9b1
https://github.com/python-control/python-control/pull/454/changes#diff-ecf5a23a5f3aa1be4faff8673255c1610fd61b011b8ed010e1dc1497e3d8a9b1
Please reload this pagehttps://github.com/python-control/python-control/pull/454/changes
https://github.com/python-control/python-control/pull/454/changes#diff-ecf5a23a5f3aa1be4faff8673255c1610fd61b011b8ed010e1dc1497e3d8a9b1
Please reload this pagehttps://github.com/python-control/python-control/pull/454/changes
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.