Title: fix impulse size for discrete-time impulse response by sawyerbfuller · Pull Request #447 · python-control/python-control · GitHub
Open Graph Title: fix impulse size for discrete-time impulse response by sawyerbfuller · Pull Request #447 · python-control/python-control
X Title: fix impulse size for discrete-time impulse response by sawyerbfuller · Pull Request #447 · python-control/python-control
Description: The input impulse used to drive the impulse response of a discrete-time system should be unit area rather than unit height. With this change, the discrete-time system's impulse response matches the cont-time systems's, if the discrete time system was sampled with 'impulse-equivalent' approximation according to: sysd = sys.sample(0.1, 'impulse') A new unit test checks this. (this is consistent with MATLAB behavior) Update: rewrote summary, last version was written after a long work session and it shows : )
Open Graph Description: The input impulse used to drive the impulse response of a discrete-time system should be unit area rather than unit height. With this change, the discrete-time system's impulse response matches...
X Description: The input impulse used to drive the impulse response of a discrete-time system should be unit area rather than unit height. With this change, the discrete-time system's impulse response mat...
Opengraph URL: https://github.com/python-control/python-control/pull/447
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:a55e3966-5220-ab93-2411-0f30ff719835 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | A17C:37296A:49F5474:646BDB5:697CAF0B |
| html-safe-nonce | 739da1a8698a507eb5ed5e7a77c3ad2684766ca28d3b85e9b5cd6ee0b74ab91d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTdDOjM3Mjk2QTo0OUY1NDc0OjY0NkJEQjU6Njk3Q0FGMEIiLCJ2aXNpdG9yX2lkIjoiNzQzOTc1MDI5MzI5NTUwOTI1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c6eafc61b49a9937961046ceb38d3c6c7c6980f68602e3a761c1f7ef24343387 |
| hovercard-subject-tag | pull_request:465311866 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/447/checks |
| twitter:image | https://avatars.githubusercontent.com/u/58706249?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/58706249?s=400&v=4 |
| og:image:alt | The input impulse used to drive the impulse response of a discrete-time system should be unit area rather than unit height. With this change, the discrete-time system's impulse response matches... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5bdfd06d077d4bc79a8063f7549f208cda3158f1322903029653dc97f57b937a |
| turbo-cache-control | no-preview |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f8a309d88087f59ff1a2f2cd9e9e79ed01a7b84e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width