René's URL Explorer Experiment


Title: fix impulse size for discrete-time impulse response by sawyerbfuller · Pull Request #447 · python-control/python-control · GitHub

Open Graph Title: fix impulse size for discrete-time impulse response by sawyerbfuller · Pull Request #447 · python-control/python-control

X Title: fix impulse size for discrete-time impulse response by sawyerbfuller · Pull Request #447 · python-control/python-control

Description: The input impulse used to drive the impulse response of a discrete-time system should be unit area rather than unit height. With this change, the discrete-time system's impulse response matches the...

Open Graph Description: The input impulse used to drive the impulse response of a discrete-time system should be unit area rather than unit height. With this change, the discrete-time system's impulse response matches...

X Description: The input impulse used to drive the impulse response of a discrete-time system should be unit area rather than unit height. With this change, the discrete-time system's impulse response mat...

Opengraph URL: https://github.com/python-control/python-control/pull/447

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:87374f0e-d0f6-2ca5-ae87-aa7bce3950d4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE520:3464BF:3426368:459FCB2:697AF17B
html-safe-nonced78226e84f5db0c1bc44e226be152c4c77f172464b1454870ef164de55e0b5d6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTIwOjM0NjRCRjozNDI2MzY4OjQ1OUZDQjI6Njk3QUYxN0IiLCJ2aXNpdG9yX2lkIjoiMTUzNjg2MDI4OTUwNzE5MzIxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaceb51324524112257c9ba579d3bf3f3c298d5c9ee4966260506f5b10a705287d6
hovercard-subject-tagpull_request:465311866
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-control/python-control/447/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ceb513eb4c44cc7039d6b604748d28fb230a0a678edaa714ab170cb05ee284c5/python-control/python-control/pull/447
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ceb513eb4c44cc7039d6b604748d28fb230a0a678edaa714ab170cb05ee284c5/python-control/python-control/pull/447
og:image:altThe input impulse used to drive the impulse response of a discrete-time system should be unit area rather than unit height. With this change, the discrete-time system's impulse response matches...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesawyerbfuller
hostnamegithub.com
expected-hostnamegithub.com
None7ce8ed0a54c4730aeca4e6abacfc6490365fc42e25480b86883054df3f9181c8
turbo-cache-controlno-preview
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released7bfc78137af9a4828305e52ab993fce981d7085
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/447#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F447
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F447
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/447
Reloadhttps://github.com/python-control/python-control/pull/447
Reloadhttps://github.com/python-control/python-control/pull/447
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python-control/python-control/pull/447#issue-comment-box
bnavigatorhttps://github.com/bnavigator
python-control:masterhttps://github.com/python-control/python-control/tree/master
sawyerbfuller:fix-dt-impulse-sizehttps://github.com/sawyerbfuller/python-control/tree/fix-dt-impulse-size
fix impulse size for discrete-time impulse response https://github.com/python-control/python-control/pull/447#top
bnavigatorhttps://github.com/bnavigator
python-control:masterhttps://github.com/python-control/python-control/tree/master
sawyerbfuller:fix-dt-impulse-sizehttps://github.com/sawyerbfuller/python-control/tree/fix-dt-impulse-size
Conversation 3 https://github.com/python-control/python-control/pull/447
Commits 2 https://github.com/python-control/python-control/pull/447/commits
Checks 0 https://github.com/python-control/python-control/pull/447/checks
Files changed https://github.com/python-control/python-control/pull/447/files
Please reload this pagehttps://github.com/python-control/python-control/pull/447
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/{{ revealButtonHref }}
https://github.com/sawyerbfuller
sawyerbfullerhttps://github.com/sawyerbfuller
Aug 10, 2020https://github.com/python-control/python-control/pull/447#issue-675908421
Please reload this pagehttps://github.com/python-control/python-control/pull/447
Please reload this pagehttps://github.com/python-control/python-control/pull/447
https://github.com/sawyerbfuller
code fix and unit testhttps://github.com/python-control/python-control/pull/447/commits/dec1455c38a4d5324c5a0cbb8a4d96aa42fdf105
dec1455https://github.com/python-control/python-control/pull/447/commits/dec1455c38a4d5324c5a0cbb8a4d96aa42fdf105
https://github.com/bnavigator
bnavigatorhttps://github.com/bnavigator
Aug 10, 2020 https://github.com/python-control/python-control/pull/447#pullrequestreview-464395969
View reviewed changes https://github.com/python-control/python-control/pull/447/files/dec1455c38a4d5324c5a0cbb8a4d96aa42fdf105
control/tests/timeresp_test.pyhttps://github.com/python-control/python-control/pull/447/files/dec1455c38a4d5324c5a0cbb8a4d96aa42fdf105#diff-ecf5a23a5f3aa1be4faff8673255c1610fd61b011b8ed010e1dc1497e3d8a9b1
Please reload this pagehttps://github.com/python-control/python-control/pull/447
https://github.com/sawyerbfuller
suggested fix to unit testhttps://github.com/python-control/python-control/pull/447/commits/0b85e3b13538257aab64b910ab4dace7a7146831
0b85e3bhttps://github.com/python-control/python-control/pull/447/commits/0b85e3b13538257aab64b910ab4dace7a7146831
https://github.com/coveralls
coverallshttps://github.com/coveralls
Aug 10, 2020https://github.com/python-control/python-control/pull/447#issuecomment-671583826
https://coveralls.io/builds/32658663
0b85e3bhttps://github.com/python-control/python-control/commit/0b85e3b13538257aab64b910ab4dace7a7146831
d3142ffhttps://github.com/python-control/python-control/commit/d3142ff24c7af5e2c0843fd16d0e1be82b322bb9
Please reload this pagehttps://github.com/python-control/python-control/pull/447
https://github.com/bnavigator
bnavigatorhttps://github.com/bnavigator
Aug 17, 2020 https://github.com/python-control/python-control/pull/447#pullrequestreview-468592199
View reviewed changes https://github.com/python-control/python-control/pull/447/files/0b85e3b13538257aab64b910ab4dace7a7146831
https://github.com/bnavigator
bnavigatorhttps://github.com/bnavigator
0.9.0https://github.com/python-control/python-control/milestone/8
Aug 17, 2020https://github.com/python-control/python-control/pull/447#event-3662534852
https://github.com/bnavigator
bnavigatorhttps://github.com/bnavigator
daf2536https://github.com/python-control/python-control/commit/daf25361b8f285f549cf620e9fcaf88f9177065e
Dec 28, 2020https://github.com/python-control/python-control/pull/447#event-4153299078
bnavigatorhttps://github.com/bnavigator
Dec 29, 2020 https://github.com/python-control/python-control/pull/447#ref-commit-06aaec3
https://github.com/bnavigator
Stop testing Python 2.7, 3.5 and scipy 0.19https://github.com/python-control/python-control/commit/06aaec32e30c541f0b4e4749a0a7ab0a3f8a1379
06aaec3https://github.com/python-control/python-control/commit/06aaec32e30c541f0b4e4749a0a7ab0a3f8a1379
#447https://github.com/python-control/python-control/pull/447
Stop testing Python 2.7 and scipy 0.19 #481 https://github.com/python-control/python-control/pull/481
skip impulse sampling for old scipy #482 https://github.com/python-control/python-control/pull/482
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F447
https://github.com/bnavigator
bnavigator https://github.com/bnavigator
https://github.com/python-control/python-control/pull/447/files/0b85e3b13538257aab64b910ab4dace7a7146831
0.9.0 https://github.com/python-control/python-control/milestone/8
Please reload this pagehttps://github.com/python-control/python-control/pull/447
https://github.com/sawyerbfuller
https://github.com/coveralls
https://github.com/bnavigator
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.