René's URL Explorer Experiment


Title: Default dt is 0 by sawyerbfuller · Pull Request #431 · python-control/python-control · GitHub

Open Graph Title: Default dt is 0 by sawyerbfuller · Pull Request #431 · python-control/python-control

X Title: Default dt is 0 by sawyerbfuller · Pull Request #431 · python-control/python-control

Description: Changes the new default to be dt=0 (continuous-time), rather than dt=None (timebase unspecified) for state space, transfer function, and input output systems. This follows matlab convention as discussed in issue #422 new default is dt=0 in these three modules (edit: setting now is in a single location: defaults['control.default_dt']) to make interconnection behavior match what is described in conventions, a new function: lti.common_timebase(dt1, dt2) was introduced. It performs logic to correctly combine timebases of combined systems. The new function now correctly allows discrete-time systems with unspecified sampling time (dt=True) to be combined with systems with specified sampling time (dt!=0, dt!=None, eg dt=0.1). new functions _isstaticgain (edit: now is a method is_static_gain) were added to detect upon initialization whether a state space or transfer function is a static gain. If so, dt=None for such systems so they may be combined with either discrete- or continuous-time systems. I needed to take dt out of the arguments list in iosys init functions because library-wide defaults are not available when modules are first imported, which is when default values in function declarations are evaluated. My solution was to move the dt keyword in the **kwargs dict. fixes to unit tests use_legacy_defaults('0.8.3') reverts to old default behavior of dt=None

Open Graph Description: Changes the new default to be dt=0 (continuous-time), rather than dt=None (timebase unspecified) for state space, transfer function, and input output systems. This follows matlab convention as disc...

X Description: Changes the new default to be dt=0 (continuous-time), rather than dt=None (timebase unspecified) for state space, transfer function, and input output systems. This follows matlab convention as disc...

Opengraph URL: https://github.com/python-control/python-control/pull/431

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a33629fd-549f-50ea-162f-39e3da5c1ec1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD19E:3C1E6B:2338AC:310FAA:697BBAE8
html-safe-nonce979522c7decfc59e0fb8851f323f3de413e6721ac03e63d2a0c15c38c05cd7f4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTlFOjNDMUU2QjoyMzM4QUM6MzEwRkFBOjY5N0JCQUU4IiwidmlzaXRvcl9pZCI6IjM0OTg4NDcyMjQ4NjU3MzMzNTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8c6bb6f9a1750769612a06f5c8568c7340b63167499311cf854dd7d6df0faea3
hovercard-subject-tagpull_request:451518984
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/431/files
twitter:imagehttps://avatars.githubusercontent.com/u/58706249?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/58706249?s=400&v=4
og:image:altChanges the new default to be dt=0 (continuous-time), rather than dt=None (timebase unspecified) for state space, transfer function, and input output systems. This follows matlab convention as disc...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneab413746e1b95376981dfec4a04b2384a611b96affe802ee3ee6d752200afbb1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebea0e0f1995ab0bb7fa336572c353032cf897ec1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/431/changes#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F431%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F431%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/431/changes
Reloadhttps://github.com/python-control/python-control/pull/431/changes
Reloadhttps://github.com/python-control/python-control/pull/431/changes
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
sawyerbfullerhttps://github.com/sawyerbfuller
python-control:masterhttps://github.com/python-control/python-control/tree/master
sawyerbfuller:default_dt_0https://github.com/sawyerbfuller/python-control/tree/default_dt_0
Conversation 30 https://github.com/python-control/python-control/pull/431
Commits 12 https://github.com/python-control/python-control/pull/431/commits
Checks 0 https://github.com/python-control/python-control/pull/431/checks
Files changed https://github.com/python-control/python-control/pull/431/files
Please reload this pagehttps://github.com/python-control/python-control/pull/431/changes
Default dt is 0 https://github.com/python-control/python-control/pull/431/changes#top
Show all changes 12 commits https://github.com/python-control/python-control/pull/431/files
0113f99 set default dt to be 0 instead of None. Now need to fix resulting uni… sawyerbfuller Jul 17, 2020 https://github.com/python-control/python-control/pull/431/commits/0113f9925a119b8fa3fce0c815f9b3c205d5d000
9aed7cc changes so that a default dt=0 passes unit tests. fixed code everywhe… sawyerbfuller Jul 17, 2020 https://github.com/python-control/python-control/pull/431/commits/9aed7cce5bd87d49fcbae69da887afbd92fbf9f1
7a9bcd4 small bugfix to xferfcn._evalfr to correctly give it dt value sawyerbfuller Jul 18, 2020 https://github.com/python-control/python-control/pull/431/commits/7a9bcd405c70b72f89a767117813e76628abe655
d59e57a removed a brittle unit test dependency that is already tested elsewhere sawyerbfuller Jul 18, 2020 https://github.com/python-control/python-control/pull/431/commits/d59e57a5deb9d38f0dd93ea14dcda1b5e703ff13
c96465d improved unit test suggestd by ben greiner sawyerbfuller Jul 20, 2020 https://github.com/python-control/python-control/pull/431/commits/c96465dcaa36431d55335f086326c4a23f00bc9f
2ec1653 re-incorporated lti.timebaseEqual, with a pendingDeprecationWarning sawyerbfuller Jul 20, 2020 https://github.com/python-control/python-control/pull/431/commits/2ec165300f9ffbfdbe16970c76fffe9a181a8de1
1e001ee changes to enable package-wide default, 'control.default_dt') sawyerbfuller Jul 20, 2020 https://github.com/python-control/python-control/pull/431/commits/1e001ee44e649384bf8beeea3ea3f9b614ea3288
f5c3fac fixes to docstrings and conventions.rst to match convention of dt=0 a… sawyerbfuller Jul 20, 2020 https://github.com/python-control/python-control/pull/431/commits/f5c3face51e5a1a1151529b5a2ea1d83805d3fc0
c6787cc remove extraneous file sawyerbfuller Jul 21, 2020 https://github.com/python-control/python-control/pull/431/commits/c6787cc6f4ab1ac0e3d1899c2a31d8644b83ced9
606975d new method is_static_gain() for state space and transfer function sys… sawyerbfuller Jul 22, 2020 https://github.com/python-control/python-control/pull/431/commits/606975d5918582c03258edb800d0b9385212b204
2bd912d added keyword arguments to xferfcn.tf and statesp.ss to set dt sawyerbfuller Jul 22, 2020 https://github.com/python-control/python-control/pull/431/commits/2bd912d03fda63c285f84508e97e73f136edad58
dc53eb9 unit tests for is_static_gain system method and dt keyword in system … sawyerbfuller Jul 23, 2020 https://github.com/python-control/python-control/pull/431/commits/dc53eb96bd4900729bc75a45ad68a4da4bb5bd41
Clear filters https://github.com/python-control/python-control/pull/431/files
Please reload this pagehttps://github.com/python-control/python-control/pull/431/changes
Please reload this pagehttps://github.com/python-control/python-control/pull/431/changes
config.py https://github.com/python-control/python-control/pull/431/changes#diff-d1ad1d32d49067e21beadf8da713ffdea3d1673aedb13dbbf54028cb7e8e4cb5
dtime.py https://github.com/python-control/python-control/pull/431/changes#diff-2729e420fd787e2a9296e7f1a2603218c904ec8120c8dfb2e6c3778bc0a1b253
iosys.py https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
lti.py https://github.com/python-control/python-control/pull/431/changes#diff-9eb79d97f0ecfaf506be3bac9ab8573caf6301e9685c8bfa3e91632402fa4e5a
statesp.py https://github.com/python-control/python-control/pull/431/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
config_test.py https://github.com/python-control/python-control/pull/431/changes#diff-5eadccfa15bf2713ea447a592131d9404915a826d9b41f54d5ef4b2631f24067
discrete_test.py https://github.com/python-control/python-control/pull/431/changes#diff-b045dd59ba4d891e79551a3ecefb413f26380b5e65553c4874e406374ce5cd68
matlab_test.py https://github.com/python-control/python-control/pull/431/changes#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
statesp_test.py https://github.com/python-control/python-control/pull/431/changes#diff-4c76080acbdea36493458693d93ec10e4e10b2e04ce01c56e8a81567cc1ea0d6
xferfcn_test.py https://github.com/python-control/python-control/pull/431/changes#diff-df824c2e70c14dd722d8f5b8d418f28180aa0d1a8dffa5e4b6271740d58cb2b2
xferfcn.py https://github.com/python-control/python-control/pull/431/changes#diff-0dd9424d3024fc1d5cc8fd67d13efe5703318c4c705526ab0ae216de69ce3de7
conventions.rst https://github.com/python-control/python-control/pull/431/changes#diff-04f5af9adedfe548dc7beedc5952a1aff00fb279a868e337028b2487e655e2f4
control/config.pyhttps://github.com/python-control/python-control/pull/431/changes#diff-d1ad1d32d49067e21beadf8da713ffdea3d1673aedb13dbbf54028cb7e8e4cb5
View file https://github.com/sawyerbfuller/python-control/blob/dc53eb96bd4900729bc75a45ad68a4da4bb5bd41/control/config.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/431/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/431/changes#diff-d1ad1d32d49067e21beadf8da713ffdea3d1673aedb13dbbf54028cb7e8e4cb5
https://github.com/python-control/python-control/pull/431/changes#diff-d1ad1d32d49067e21beadf8da713ffdea3d1673aedb13dbbf54028cb7e8e4cb5
https://github.com/python-control/python-control/pull/431/changes#diff-d1ad1d32d49067e21beadf8da713ffdea3d1673aedb13dbbf54028cb7e8e4cb5
https://github.com/python-control/python-control/pull/431/changes#diff-d1ad1d32d49067e21beadf8da713ffdea3d1673aedb13dbbf54028cb7e8e4cb5
https://github.com/python-control/python-control/pull/431/changes#diff-d1ad1d32d49067e21beadf8da713ffdea3d1673aedb13dbbf54028cb7e8e4cb5
control/dtime.pyhttps://github.com/python-control/python-control/pull/431/changes#diff-2729e420fd787e2a9296e7f1a2603218c904ec8120c8dfb2e6c3778bc0a1b253
View file https://github.com/sawyerbfuller/python-control/blob/dc53eb96bd4900729bc75a45ad68a4da4bb5bd41/control/dtime.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/431/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/431/changes#diff-2729e420fd787e2a9296e7f1a2603218c904ec8120c8dfb2e6c3778bc0a1b253
https://github.com/python-control/python-control/pull/431/changes#diff-2729e420fd787e2a9296e7f1a2603218c904ec8120c8dfb2e6c3778bc0a1b253
https://github.com/python-control/python-control/pull/431/changes#diff-2729e420fd787e2a9296e7f1a2603218c904ec8120c8dfb2e6c3778bc0a1b253
control/iosys.pyhttps://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
View file https://github.com/sawyerbfuller/python-control/blob/dc53eb96bd4900729bc75a45ad68a4da4bb5bd41/control/iosys.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/431/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/431/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
Please reload this pagehttps://github.com/python-control/python-control/pull/431/changes
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.