René's URL Explorer Experiment


Title: Fixed InterconnectedSystems name bugs. by samlaf · Pull Request #400 · python-control/python-control · GitHub

Open Graph Title: Fixed InterconnectedSystems name bugs. by samlaf · Pull Request #400 · python-control/python-control

X Title: Fixed InterconnectedSystems name bugs. by samlaf · Pull Request #400 · python-control/python-control

Description: 3 fixes to InterconnectedSystem's init: It wasn't setting the name properly It also wasn't setting the output and input names properly I also made it so that instead of using generic state names, it uses subsys.statename when available For example, if we Interconnected these two systems System: predprey Inputs (1): u, Outputs (2): H, L, States (2): H, L, System: control Inputs (3): Ld, u1, u2, Outputs (1): y[0], States (0): we would get System: (None) # point (1) Inputs (0): Outputs (3): # point (2) States (2): x[0], x[1], # point (3) Now instead, we get System: io_closed Inputs (0): Outputs (3): y[0], y[1], y[2], States (2): predpreyH, predpreyL,

Open Graph Description: 3 fixes to InterconnectedSystem's init: It wasn't setting the name properly It also wasn't setting the output and input names properly I also made it so that instead of using generic s...

X Description: 3 fixes to InterconnectedSystem's init: It wasn't setting the name properly It also wasn't setting the output and input names properly I also made it so that instead of usi...

Opengraph URL: https://github.com/python-control/python-control/pull/400

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:961ec82e-7a6d-d9a9-c717-5d696f34e056
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA0C:28F8F8:23A93C:314B44:697BBAE7
html-safe-nonce9bb540abfda51e9604663f77aa1403bea96f539b00b4f9e64dd8e476d51b559e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTBDOjI4RjhGODoyM0E5M0M6MzE0QjQ0OjY5N0JCQUU3IiwidmlzaXRvcl9pZCI6IjEwODM2NjQ3MjkyMzE4MzM4MzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd211ae06b85d93c81d438d90f920ee2bdca52da6f73467f3b37bd74ab25fe7ad
hovercard-subject-tagpull_request:417750070
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/400/files
twitter:imagehttps://avatars.githubusercontent.com/u/9342524?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9342524?s=400&v=4
og:image:alt3 fixes to InterconnectedSystem's init: It wasn't setting the name properly It also wasn't setting the output and input names properly I also made it so that instead of using generic s...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneab413746e1b95376981dfec4a04b2384a611b96affe802ee3ee6d752200afbb1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebea0e0f1995ab0bb7fa336572c353032cf897ec1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/400/changes#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F400%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F400%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/400/changes
Reloadhttps://github.com/python-control/python-control/pull/400/changes
Reloadhttps://github.com/python-control/python-control/pull/400/changes
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
murrayrmhttps://github.com/murrayrm
python-control:masterhttps://github.com/python-control/python-control/tree/master
samlaf:interconnectedsystemshttps://github.com/samlaf/python-control/tree/interconnectedsystems
Conversation 48 https://github.com/python-control/python-control/pull/400
Commits 16 https://github.com/python-control/python-control/pull/400/commits
Checks 0 https://github.com/python-control/python-control/pull/400/checks
Files changed https://github.com/python-control/python-control/pull/400/files
Please reload this pagehttps://github.com/python-control/python-control/pull/400/changes
Fixed InterconnectedSystems name bugs. https://github.com/python-control/python-control/pull/400/changes#top
Show all changes 16 commits https://github.com/python-control/python-control/pull/400/files
672f229 Made sure interconnectedsystems keeps names of parts. samlaf May 14, 2020 https://github.com/python-control/python-control/pull/400/commits/672f229f48f499530ff39acb0a2cbc2ae4d32c5b
15a442a Update control/iosys.py samlaf May 18, 2020 https://github.com/python-control/python-control/pull/400/commits/15a442a7d8c6bd8b49f1bb73731e181530171c46
77f9441 Update control/iosys.py samlaf May 18, 2020 https://github.com/python-control/python-control/pull/400/commits/77f944128d5ce305cc7be7a45ef486369b623bae
d45a6c0 Fixed signal names for InterconnectedSystems. samlaf May 20, 2020 https://github.com/python-control/python-control/pull/400/commits/d45a6c08e942ee3e18a093e5969f53738391df01
b688729 Merge branch 'interconnectedsystems' of https://github.com/samlaf/pyt… samlaf May 20, 2020 https://github.com/python-control/python-control/pull/400/commits/b68872927b79cf5c10dbf7ae27f93affbefb5ffe
c8fba97 Update control/iosys.py samlaf Jul 15, 2020 https://github.com/python-control/python-control/pull/400/commits/c8fba9718469abe2d1fe086d7397804e08655449
bd38dea Update control/iosys.py samlaf Jul 15, 2020 https://github.com/python-control/python-control/pull/400/commits/bd38dea13f8aae265b256482b02d063e00f2f672
35676f2 Fixed some naming convention problems and added unit tests for naming… samlaf Jul 16, 2020 https://github.com/python-control/python-control/pull/400/commits/35676f27d65afd88211de413651b1d2eea404204
90705d4 Merge branch 'interconnectedsystems' of https://github.com/samlaf/pyt… samlaf Jul 16, 2020 https://github.com/python-control/python-control/pull/400/commits/90705d416a8181dcf3631948dd2ef14d154a5d80
69cc8c5 Removed for loops from tests to get better error messages samlaf Jul 19, 2020 https://github.com/python-control/python-control/pull/400/commits/69cc8c559f30ce4f5ebec3768f137537222337ac
e76a4f8 Update control/iosys.py samlaf Jul 19, 2020 https://github.com/python-control/python-control/pull/400/commits/e76a4f8ec9ad30e3d7fc6baacd269013c65abbed
abb1f19 Changed a lot of naming convention code/unit test following pull-requ… samlaf Jul 19, 2020 https://github.com/python-control/python-control/pull/400/commits/abb1f19176e13a1a7e5f608282b9235b626eb220
f955b3a Merge branch 'interconnectedsystems' of https://github.com/samlaf/pyt… samlaf Jul 19, 2020 https://github.com/python-control/python-control/pull/400/commits/f955b3a421c0045061a9b4f1656b226a979e0c3d
3ec2f02 Fixed system naming conventions and unit tests. Still need to do sign… samlaf Jul 19, 2020 https://github.com/python-control/python-control/pull/400/commits/3ec2f025505a9247e5d8a6449a2728977cd50c8a
8c957b2 Merge branch 'master' into interconnectedsystems murrayrm Jul 20, 2020 https://github.com/python-control/python-control/pull/400/commits/8c957b2bed12e842d624fdc91429ffc68591aa53
b2c8d44 Finished test_signals_naming_convention unit test samlaf Jul 20, 2020 https://github.com/python-control/python-control/pull/400/commits/b2c8d44ed1d08439336b705b292920f6d6da210e
Clear filters https://github.com/python-control/python-control/pull/400/files
Please reload this pagehttps://github.com/python-control/python-control/pull/400/changes
Please reload this pagehttps://github.com/python-control/python-control/pull/400/changes
iosys.py https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
iosys_test.py https://github.com/python-control/python-control/pull/400/changes#diff-2d9f6fd1b76261b8663bd7fa89565809a728c32edd8b0f6e095177f80b6e5100
timeresp.py https://github.com/python-control/python-control/pull/400/changes#diff-3200453f1cf62f183f04dbf39d1129d91245c53a9f74675cee6bd384351c45b4
control/iosys.pyhttps://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
View file https://github.com/samlaf/python-control/blob/b2c8d44ed1d08439336b705b292920f6d6da210e/control/iosys.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/400/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
Please reload this pagehttps://github.com/python-control/python-control/pull/400/changes
Please reload this pagehttps://github.com/python-control/python-control/pull/400/changes
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
samlafhttps://github.com/samlaf
Jul 15, 2020https://github.com/python-control/python-control/pull/400/changes#r455291216
Please reload this pagehttps://github.com/python-control/python-control/pull/400/changes
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@murrayrmhttps://github.com/murrayrm
Please reload this pagehttps://github.com/python-control/python-control/pull/400/changes
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
https://github.com/python-control/python-control/pull/400/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1
Please reload this pagehttps://github.com/python-control/python-control/pull/400/changes
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.