Title: Fix slycot link error by murrayrm · Pull Request #353 · python-control/python-control · GitHub
Open Graph Title: Fix slycot link error by murrayrm · Pull Request #353 · python-control/python-control
X Title: Fix slycot link error by murrayrm · Pull Request #353 · python-control/python-control
Description: This PR address a problem in the slycot build process (documented here) in which building slycot from source is currently failing. This is related to issue #349 where coveralls was reporting a decrease in coverage (because slycot was not present => some code was not being tested). To fix this, I changed the .travis.yml file to use the conda-forge version of slycot by default. This is probably the better thing to do in any case, since that is how most users are likely to get slycot. I also added two "optional" (allowed to fail) builds that create the slycot package from source code, as was originally done. I put in one for python-2.7 (still working) and one for python-3.7 (failing). I didn't squash the commits when I created this PR, but suggest doing that when it is merged.
Open Graph Description: This PR address a problem in the slycot build process (documented here) in which building slycot from source is currently failing. This is related to issue #349 where coveralls was reporting a dec...
X Description: This PR address a problem in the slycot build process (documented here) in which building slycot from source is currently failing. This is related to issue #349 where coveralls was reporting a dec...
Opengraph URL: https://github.com/python-control/python-control/pull/353
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:2fae7496-9daa-64a7-ea3a-94977813440b |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | A26C:3CAE76:2024BEA:2A9CE13:697D3B91 |
| html-safe-nonce | 2e6c4b0f9d26811c95903884805b12f2ccac0397dd1e7c014bfe76cd99351667 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjZDOjNDQUU3NjoyMDI0QkVBOjJBOUNFMTM6Njk3RDNCOTEiLCJ2aXNpdG9yX2lkIjoiMjE4MTMwNzUwOTM2MzI2MDMwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 09e791b353cc078a124ac8735d9ab8ec51808254d321a44fcce04ada786b3995 |
| hovercard-subject-tag | pull_request:357582721 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/353/checks |
| twitter:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| og:image:alt | This PR address a problem in the slycot build process (documented here) in which building slycot from source is currently failing. This is related to issue #349 where coveralls was reporting a dec... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c2b1f969137add620c89ee43eff21bca11243467 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width