René's URL Explorer Experiment


Title: Fix slycot link error by murrayrm · Pull Request #353 · python-control/python-control · GitHub

Open Graph Title: Fix slycot link error by murrayrm · Pull Request #353 · python-control/python-control

X Title: Fix slycot link error by murrayrm · Pull Request #353 · python-control/python-control

Description: This PR address a problem in the slycot build process (documented here) in which building slycot from source is currently failing. This is related to issue #349 where coveralls was reporting a decrease in coverage (because slycot was not present => some code was not being tested). To fix this, I changed the .travis.yml file to use the conda-forge version of slycot by default. This is probably the better thing to do in any case, since that is how most users are likely to get slycot. I also added two "optional" (allowed to fail) builds that create the slycot package from source code, as was originally done. I put in one for python-2.7 (still working) and one for python-3.7 (failing). I didn't squash the commits when I created this PR, but suggest doing that when it is merged.

Open Graph Description: This PR address a problem in the slycot build process (documented here) in which building slycot from source is currently failing. This is related to issue #349 where coveralls was reporting a dec...

X Description: This PR address a problem in the slycot build process (documented here) in which building slycot from source is currently failing. This is related to issue #349 where coveralls was reporting a dec...

Opengraph URL: https://github.com/python-control/python-control/pull/353

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8b485bdd-063f-e220-5cbf-51efe44ba040
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB47A:2D5837:C3FB78:FAB084:697E0A51
html-safe-noncead708b3c6459e7237c716a39b96ac175a85fb149bd7f52df4e1b47d855b03e82
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDdBOjJENTgzNzpDM0ZCNzg6RkFCMDg0OjY5N0UwQTUxIiwidmlzaXRvcl9pZCI6IjY3NDA3NzI1MTgxMzExNjQ5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9a624a597a7274b6160aa9e72ca6df662fe4fc36c8ab571a2ef4256f0835c57f
hovercard-subject-tagpull_request:357582721
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/353/files
twitter:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
og:image:altThis PR address a problem in the slycot build process (documented here) in which building slycot from source is currently failing. This is related to issue #349 where coveralls was reporting a dec...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7c85641c598ad130c74f7bcc27f58575cac69551
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/353/changes#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F353%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F353%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/353/changes
Reloadhttps://github.com/python-control/python-control/pull/353/changes
Reloadhttps://github.com/python-control/python-control/pull/353/changes
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 448 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 9 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
murrayrmhttps://github.com/murrayrm
python-control:masterhttps://github.com/python-control/python-control/tree/master
murrayrm:fix_slycot_link_errorhttps://github.com/murrayrm/python-control/tree/fix_slycot_link_error
Conversation 4 https://github.com/python-control/python-control/pull/353
Commits 7 https://github.com/python-control/python-control/pull/353/commits
Checks 0 https://github.com/python-control/python-control/pull/353/checks
Files changed https://github.com/python-control/python-control/pull/353/files
Please reload this pagehttps://github.com/python-control/python-control/pull/353/changes
Fix slycot link error https://github.com/python-control/python-control/pull/353/changes#top
Show all changes 7 commits https://github.com/python-control/python-control/pull/353/files
5fa1744 updated .travis.yml to fix slycot issues murrayrm Dec 28, 2019 https://github.com/python-control/python-control/pull/353/commits/5fa17443d493dfa772b8134abe2c61f4ca23402f
d5cdc09 switch to using conda-forge for slycot, with optional build against s… murrayrm Dec 28, 2019 https://github.com/python-control/python-control/pull/353/commits/d5cdc094c1a59ee18684918436a71fcbbce51cad
901afec update comment format in .travis.yml murrayrm Dec 28, 2019 https://github.com/python-control/python-control/pull/353/commits/901afecca100045962001fa3e3d2f272d041e651
e1924da else if -> elif in .travis.yml murrayrm Dec 28, 2019 https://github.com/python-control/python-control/pull/353/commits/e1924da2dd2c680b5f102d0d6283607a569453da
bc82eb4 second attempt to add optional tests against slycot source murrayrm Dec 28, 2019 https://github.com/python-control/python-control/pull/353/commits/bc82eb4402f25828bc87f7dc903f9c7640097ced
6f14bc3 TRV: SLCOT -> SLYCOT in .travis.yml murrayrm Dec 28, 2019 https://github.com/python-control/python-control/pull/353/commits/6f14bc3feb79980b1a9549c5876a98c8757e3d73
6eea90c TRV: remove extra spaces in .travis.xml murrayrm Dec 29, 2019 https://github.com/python-control/python-control/pull/353/commits/6eea90c5b8345171a31a807baad3804293eadbaa
Clear filters https://github.com/python-control/python-control/pull/353/files
Please reload this pagehttps://github.com/python-control/python-control/pull/353/changes
Please reload this pagehttps://github.com/python-control/python-control/pull/353/changes
.travis.ymlhttps://github.com/python-control/python-control/pull/353/changes#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485
View file https://github.com/murrayrm/python-control/blob/6eea90c5b8345171a31a807baad3804293eadbaa/.travis.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/353/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/353/changes#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485
https://github.com/python-control/python-control/pull/353/changes#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485
https://github.com/python-control/python-control/pull/353/changes#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485
https://github.com/python-control/python-control/pull/353/changes#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.