Title: fix time series inconsistency between continuous and discrete time simulations by murrayrm · Pull Request #295 · python-control/python-control · GitHub
Open Graph Title: fix time series inconsistency between continuous and discrete time simulations by murrayrm · Pull Request #295 · python-control/python-control
X Title: fix time series inconsistency between continuous and discrete time simulations by murrayrm · Pull Request #295 · python-control/python-control
Description: As pointed out in issue #239, there is an inconsistency between the way that continuous time simulations and discrete time simulations return their outputs for single output systems. In continuous time, the code follows the documentation and the following works: t, y = step_response(sys) plot(t, y) However, in discrete time simulations the returned value for y had shape (1, len(t)), which meant that you had to do the following for discrete time systems: t, y = step_response(sysd) plot(t, y[0]) The problem was that for continuous time simulations forced_response() (the ultimate function that gets called) had an np.squeeze() at the end but this wasn't present for discrete time simulations. This PR fixes that problem so that the behavior is consistent, resolving the bug in issue #239. Other small changes: Added unit tests that catch the original bug Added a squeeze keyword that controls whether this behavior is implemented (default = True). Did some PEP8 cleanup on timeresponse.py Note that this may make some existing code break since discrete time simulations can now return an output that is a 1D array instead of 2D. The fix is either to remove the output index (y[0] becomes y) or set the squeeze keyword to False).
Open Graph Description: As pointed out in issue #239, there is an inconsistency between the way that continuous time simulations and discrete time simulations return their outputs for single output systems. In continuous...
X Description: As pointed out in issue #239, there is an inconsistency between the way that continuous time simulations and discrete time simulations return their outputs for single output systems. In continuous...
Opengraph URL: https://github.com/python-control/python-control/pull/295
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:09955136-8ea5-389a-3e1a-16ab2acf0194 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 82E0:96F73:FDDC1B:161D081:697BA322 |
| html-safe-nonce | eb4e94f42608a0a8e61bc4059c98f2c99d314496137a49a3e3de36a5f64ce03b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkUwOjk2RjczOkZEREMxQjoxNjFEMDgxOjY5N0JBMzIyIiwidmlzaXRvcl9pZCI6Ijg4NjA2Mjk5OTcxMzYzNTYxMzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 17016d163413588f27927ae989b12d625c414cd1bc4d8498b1de11d5087b90c3 |
| hovercard-subject-tag | pull_request:272221587 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/295/files |
| twitter:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| og:image:alt | As pointed out in issue #239, there is an inconsistency between the way that continuous time simulations and discrete time simulations return their outputs for single output systems. In continuous... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7ba9ae7380317898f1b98f4cf41e78605ff2d68007cb4db4e46bdaf7e9423d2e |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d52dd9b71f0e5da9cfd694fb2faae78a81d8e46f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width