René's URL Explorer Experiment


Title: TransferFunction _common_den rewrite - issue #194 by repagh · Pull Request #206 · python-control/python-control · GitHub

Open Graph Title: TransferFunction _common_den rewrite - issue #194 by repagh · Pull Request #206 · python-control/python-control

X Title: TransferFunction _common_den rewrite - issue #194 by repagh · Pull Request #206 · python-control/python-control

Description: On my machines I got a consistent issue #194 error. (Mac OSX and Linux). After playing around with the seed in convert_test.py, I got slightly different results for the tests. I inspected _common_den (xferfcn.py) with the debugger, and found that in some cases a lot of cancelling poles would be added; the sorting for pole comparison did not consistently work. I then re-thought and re-worked the _common_den function, instead of sorting, cycling through all known poles, comparing to poles in the current denominator, marking which ones are found -- to prevent accepting double poles, and remembering which ones are not found. The whole thing is a lot shorter, and I believe also a lot more robust. I hope this eliminates the elusive #194

Open Graph Description: On my machines I got a consistent issue #194 error. (Mac OSX and Linux). After playing around with the seed in convert_test.py, I got slightly different results for the tests. I inspected _common_d...

X Description: On my machines I got a consistent issue #194 error. (Mac OSX and Linux). After playing around with the seed in convert_test.py, I got slightly different results for the tests. I inspected _common_d...

Opengraph URL: https://github.com/python-control/python-control/pull/206

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ed1994b5-d34f-2189-06d1-1583d65c089f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9160:30BEE7:2B9CAF:3C1A43:697B41F2
html-safe-nonce28f04a459dc56e9a12b0066c774298548daf1ee7a2b64c99aed9a20d2166025d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTYwOjMwQkVFNzoyQjlDQUY6M0MxQTQzOjY5N0I0MUYyIiwidmlzaXRvcl9pZCI6Ijc3Mzc1NDE3NDc2ODQzNjA2OTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7ede13807580aafbdeb2b4fb662aeb7a5b681d26f329e6c145285486996bd3d8
hovercard-subject-tagpull_request:191291785
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/206/files
twitter:imagehttps://avatars.githubusercontent.com/u/2794509?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2794509?s=400&v=4
og:image:altOn my machines I got a consistent issue #194 error. (Mac OSX and Linux). After playing around with the seed in convert_test.py, I got slightly different results for the tests. I inspected _common_d...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None6fe64d94889230be19a900846cfc91707e7dd4206878d6c208922b46a6b0735d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release15736a47b83581130a149aa1b928696bea06adde
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/206/changes#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F206%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F206%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/206/changes
Reloadhttps://github.com/python-control/python-control/pull/206/changes
Reloadhttps://github.com/python-control/python-control/pull/206/changes
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
murrayrmhttps://github.com/murrayrm
python-control:masterhttps://github.com/python-control/python-control/tree/master
Conversation 13 https://github.com/python-control/python-control/pull/206
Commits 13 https://github.com/python-control/python-control/pull/206/commits
Checks 0 https://github.com/python-control/python-control/pull/206/checks
Files changed https://github.com/python-control/python-control/pull/206/files
Please reload this pagehttps://github.com/python-control/python-control/pull/206/changes
TransferFunction _common_den rewrite - issue #194 https://github.com/python-control/python-control/pull/206/changes#top
Show all changes 13 commits https://github.com/python-control/python-control/pull/206/files
237597e partial changes, not complete, to num/den combination repagh May 29, 2018 https://github.com/python-control/python-control/pull/206/commits/237597e412118633cb0e6d50becc82c5471d3ef1
5acb42c have replaced the _common_den function internals. Passes tests repagh May 29, 2018 https://github.com/python-control/python-control/pull/206/commits/5acb42cde6428d9860bce084ed617fbb220c3cb7
05a6934 Merge branch 'master' into tf-combination repagh May 29, 2018 https://github.com/python-control/python-control/pull/206/commits/05a6934423fbb5330633c5b150edecb9c143e6e4
a0810db make xferfcn.py python2 compatible again repagh May 29, 2018 https://github.com/python-control/python-control/pull/206/commits/a0810db1c16663460cf7169694053dfeef40362e
f4c230c Merge branch 'tf-combination' of https://github.com/repagh/python-con… repagh May 29, 2018 https://github.com/python-control/python-control/pull/206/commits/f4c230cb961746f0138cd58dbfeb3521b256105e
492635c somewhere halfway repagh Jun 4, 2018 https://github.com/python-control/python-control/pull/206/commits/492635c70686dfb2c217af92df4e4b123cc1a284
324c573 still not figured out repagh Jun 6, 2018 https://github.com/python-control/python-control/pull/206/commits/324c5730adbf5ca5556e2fa3c0742cca4b6935e8
0722cf3 work in progress repagh Jun 14, 2018 https://github.com/python-control/python-control/pull/206/commits/0722cf361e228b4f0923f627962cd435a3092805
dfb1507 more work in progress repagh Jun 15, 2018 https://github.com/python-control/python-control/pull/206/commits/dfb1507d7a8a62a43be95ce36ec0277e21335bc3
50c9bf5 working tf -> ss transformation now, also solved #111 repagh Jun 20, 2018 https://github.com/python-control/python-control/pull/206/commits/50c9bf50988bfb9cd0fdeed93e2febbaa4fb90cb
92a3354 disabled MIMO test when no slycot repagh Jun 20, 2018 https://github.com/python-control/python-control/pull/206/commits/92a33541da4fe2d4b4f5f5647caa0ba6ebf8daa2
7e594c4 - do not cancel pole/zero pairs before calculating pole() in xferfcn.py repagh Jun 26, 2018 https://github.com/python-control/python-control/pull/206/commits/7e594c461a9d6fc0ffa24d4cebd186a1e3c44fe3
732c924 - change testModred; that one did state removal on a system repagh Jul 1, 2018 https://github.com/python-control/python-control/pull/206/commits/732c924d67bede6f3f0d065959dc10a5c46259dd
Clear filters https://github.com/python-control/python-control/pull/206/files
Please reload this pagehttps://github.com/python-control/python-control/pull/206/changes
Please reload this pagehttps://github.com/python-control/python-control/pull/206/changes
statesp.py https://github.com/python-control/python-control/pull/206/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
convert_test.py https://github.com/python-control/python-control/pull/206/changes#diff-cebcec17ebc58131080d1e205ff7eb7dd87a5354def1adb46964e2a5c08a2140
discrete_test.py https://github.com/python-control/python-control/pull/206/changes#diff-b045dd59ba4d891e79551a3ecefb413f26380b5e65553c4874e406374ce5cd68
matlab_test.py https://github.com/python-control/python-control/pull/206/changes#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
xferfcn_test.py https://github.com/python-control/python-control/pull/206/changes#diff-df824c2e70c14dd722d8f5b8d418f28180aa0d1a8dffa5e4b6271740d58cb2b2
xferfcn.py https://github.com/python-control/python-control/pull/206/changes#diff-0dd9424d3024fc1d5cc8fd67d13efe5703318c4c705526ab0ae216de69ce3de7
control/statesp.pyhttps://github.com/python-control/python-control/pull/206/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
View file https://github.com/python-control/python-control/blob/732c924d67bede6f3f0d065959dc10a5c46259dd/control/statesp.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/206/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/206/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/206/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/206/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
control/tests/convert_test.pyhttps://github.com/python-control/python-control/pull/206/changes#diff-cebcec17ebc58131080d1e205ff7eb7dd87a5354def1adb46964e2a5c08a2140
View file https://github.com/python-control/python-control/blob/732c924d67bede6f3f0d065959dc10a5c46259dd/control/tests/convert_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/206/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/206/changes#diff-cebcec17ebc58131080d1e205ff7eb7dd87a5354def1adb46964e2a5c08a2140
https://github.com/python-control/python-control/pull/206/changes#diff-cebcec17ebc58131080d1e205ff7eb7dd87a5354def1adb46964e2a5c08a2140
https://github.com/python-control/python-control/pull/206/changes#diff-cebcec17ebc58131080d1e205ff7eb7dd87a5354def1adb46964e2a5c08a2140
https://github.com/python-control/python-control/pull/206/changes#diff-cebcec17ebc58131080d1e205ff7eb7dd87a5354def1adb46964e2a5c08a2140
https://github.com/python-control/python-control/pull/206/changes#diff-cebcec17ebc58131080d1e205ff7eb7dd87a5354def1adb46964e2a5c08a2140
https://github.com/python-control/python-control/pull/206/changes#diff-cebcec17ebc58131080d1e205ff7eb7dd87a5354def1adb46964e2a5c08a2140
https://github.com/python-control/python-control/pull/206/changes#diff-cebcec17ebc58131080d1e205ff7eb7dd87a5354def1adb46964e2a5c08a2140
https://github.com/python-control/python-control/pull/206/changes#diff-cebcec17ebc58131080d1e205ff7eb7dd87a5354def1adb46964e2a5c08a2140
control/tests/discrete_test.pyhttps://github.com/python-control/python-control/pull/206/changes#diff-b045dd59ba4d891e79551a3ecefb413f26380b5e65553c4874e406374ce5cd68
View file https://github.com/python-control/python-control/blob/732c924d67bede6f3f0d065959dc10a5c46259dd/control/tests/discrete_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/206/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/206/changes#diff-b045dd59ba4d891e79551a3ecefb413f26380b5e65553c4874e406374ce5cd68
https://github.com/python-control/python-control/pull/206/changes#diff-b045dd59ba4d891e79551a3ecefb413f26380b5e65553c4874e406374ce5cd68
control/tests/matlab_test.pyhttps://github.com/python-control/python-control/pull/206/changes#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
View file https://github.com/python-control/python-control/blob/732c924d67bede6f3f0d065959dc10a5c46259dd/control/tests/matlab_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/206/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/206/changes#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
https://github.com/python-control/python-control/pull/206/changes#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
control/tests/xferfcn_test.pyhttps://github.com/python-control/python-control/pull/206/changes#diff-df824c2e70c14dd722d8f5b8d418f28180aa0d1a8dffa5e4b6271740d58cb2b2
View file https://github.com/python-control/python-control/blob/732c924d67bede6f3f0d065959dc10a5c46259dd/control/tests/xferfcn_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/206/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/206/changes#diff-df824c2e70c14dd722d8f5b8d418f28180aa0d1a8dffa5e4b6271740d58cb2b2
https://github.com/python-control/python-control/pull/206/changes#diff-df824c2e70c14dd722d8f5b8d418f28180aa0d1a8dffa5e4b6271740d58cb2b2
Please reload this pagehttps://github.com/python-control/python-control/pull/206/changes
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.