René's URL Explorer Experiment


Title: Update evalfr() to be consistent with MATLAB usage by murrayrm · Pull Request #179 · python-control/python-control · GitHub

Open Graph Title: Update evalfr() to be consistent with MATLAB usage by murrayrm · Pull Request #179 · python-control/python-control

X Title: Update evalfr() to be consistent with MATLAB usage by murrayrm · Pull Request #179 · python-control/python-control

Description: This PR addresses issue #22, in which it was pointed out that the evalfr() method in the TransferFunction and StateSpace objects takes different arguments than the evalfr() function. Specifically, the evalfr method takes a real argument (the frequency at which you want to evaluate the frequency response) and the evalfr function takes a complex argument (consistent with MATLAB usage). This PR makes the following changes to the code base: Renamed evalfr() in the FRD, StateSpace and TransferFunction classes to _evalfr() and put a deprecation warning for use of the evalfr() method. Changed calls to evalfr() in frdata.py and margins.py to use _evalfr() Added unit tests for the the new methods + warnings These changes eliminate the inconsistency in the argument form between the (MATLAB compatible) evalfr() function and the evalfr() methods for LTI objects. The _evalfr() method retains the original functionality, since it is used for computing stability margins and for converting objects to FRD form.

Open Graph Description: This PR addresses issue #22, in which it was pointed out that the evalfr() method in the TransferFunction and StateSpace objects takes different arguments than the evalfr() function. Specifically,...

X Description: This PR addresses issue #22, in which it was pointed out that the evalfr() method in the TransferFunction and StateSpace objects takes different arguments than the evalfr() function. Specifically,...

Opengraph URL: https://github.com/python-control/python-control/pull/179

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2ea9f853-8ccd-b41f-edd4-cb5655f4ad61
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD00E:70D2D:15EFC41:1DCCF60:697A957A
html-safe-nonce9114e087b39f38a726ac50826b6c89245a9806520330753da5146f149d7289a0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDBFOjcwRDJEOjE1RUZDNDE6MURDQ0Y2MDo2OTdBOTU3QSIsInZpc2l0b3JfaWQiOiIzMjU3NDc2NDgzODA2NTY1NzU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac780082f83f23cd91017d6a02d8a009e8c2974962137ee81ef5bfb9a874eb456f
hovercard-subject-tagpull_request:161486910
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/179/files
twitter:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
og:image:altThis PR addresses issue #22, in which it was pointed out that the evalfr() method in the TransferFunction and StateSpace objects takes different arguments than the evalfr() function. Specifically,...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0912f2a9aa0160e08239520d461a4b4c4ce1caa972a8370b7442b94a38a194c5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef8f5270c10a913bfa56f2dad4b864f1cda383754
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/179/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F179%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F179%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/179/files
Reloadhttps://github.com/python-control/python-control/pull/179/files
Reloadhttps://github.com/python-control/python-control/pull/179/files
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
murrayrmhttps://github.com/murrayrm
python-control:masterhttps://github.com/python-control/python-control/tree/master
murrayrm:update_evalfrhttps://github.com/murrayrm/python-control/tree/update_evalfr
Conversation 1 https://github.com/python-control/python-control/pull/179
Commits 5 https://github.com/python-control/python-control/pull/179/commits
Checks 0 https://github.com/python-control/python-control/pull/179/checks
Files changed https://github.com/python-control/python-control/pull/179/files
Please reload this pagehttps://github.com/python-control/python-control/pull/179/files
Update evalfr() to be consistent with MATLAB usage https://github.com/python-control/python-control/pull/179/files#top
Show all changes 5 commits https://github.com/python-control/python-control/pull/179/files
558c1b9 Merge branch 'master' of https://github.com/python-control/python-con… murrayrm Jan 2, 2018 https://github.com/python-control/python-control/pull/179/commits/558c1b9f1a4af44cbd5745106716ff75931e6353
54d41aa Merge branch 'master' of https://github.com/python-control/python-con… murrayrm Jan 2, 2018 https://github.com/python-control/python-control/pull/179/commits/54d41aa5e9855f720eeb899537456da9695ffa04
9405886 Merge branch 'master' of https://github.com/python-control/python-con… murrayrm Jan 3, 2018 https://github.com/python-control/python-control/pull/179/commits/94058864892b345aae304db6bba2658a9e1c00da
ee30983 Merge branch 'master' of https://github.com/python-control/python-con… murrayrm Jan 5, 2018 https://github.com/python-control/python-control/pull/179/commits/ee30983b83b1f0aba01c4ad247d959e78ea2f3a1
2915baf Update evalfr usage for consistency with MATLAB murrayrm Jan 6, 2018 https://github.com/python-control/python-control/pull/179/commits/2915bafa80c2e4e49259e1b7c61b26bb0150b3fe
Clear filters https://github.com/python-control/python-control/pull/179/files
Please reload this pagehttps://github.com/python-control/python-control/pull/179/files
Please reload this pagehttps://github.com/python-control/python-control/pull/179/files
frdata.py https://github.com/python-control/python-control/pull/179/files#diff-cacf59417131c19becd6fba4dde9e979bed49ce572eb24f0f62bd2af460d83d1
margins.py https://github.com/python-control/python-control/pull/179/files#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088
statesp.py https://github.com/python-control/python-control/pull/179/files#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
statesp_test.py https://github.com/python-control/python-control/pull/179/files#diff-4c76080acbdea36493458693d93ec10e4e10b2e04ce01c56e8a81567cc1ea0d6
xferfcn_test.py https://github.com/python-control/python-control/pull/179/files#diff-df824c2e70c14dd722d8f5b8d418f28180aa0d1a8dffa5e4b6271740d58cb2b2
xferfcn.py https://github.com/python-control/python-control/pull/179/files#diff-0dd9424d3024fc1d5cc8fd67d13efe5703318c4c705526ab0ae216de69ce3de7
control/frdata.pyhttps://github.com/python-control/python-control/pull/179/files#diff-cacf59417131c19becd6fba4dde9e979bed49ce572eb24f0f62bd2af460d83d1
View file https://github.com/murrayrm/python-control/blob/2915bafa80c2e4e49259e1b7c61b26bb0150b3fe/control/frdata.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/179/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/179/files#diff-cacf59417131c19becd6fba4dde9e979bed49ce572eb24f0f62bd2af460d83d1
https://github.com/python-control/python-control/pull/179/files#diff-cacf59417131c19becd6fba4dde9e979bed49ce572eb24f0f62bd2af460d83d1
https://github.com/python-control/python-control/pull/179/files#diff-cacf59417131c19becd6fba4dde9e979bed49ce572eb24f0f62bd2af460d83d1
https://github.com/python-control/python-control/pull/179/files#diff-cacf59417131c19becd6fba4dde9e979bed49ce572eb24f0f62bd2af460d83d1
https://github.com/python-control/python-control/pull/179/files#diff-cacf59417131c19becd6fba4dde9e979bed49ce572eb24f0f62bd2af460d83d1
https://github.com/python-control/python-control/pull/179/files#diff-cacf59417131c19becd6fba4dde9e979bed49ce572eb24f0f62bd2af460d83d1
https://github.com/python-control/python-control/pull/179/files#diff-cacf59417131c19becd6fba4dde9e979bed49ce572eb24f0f62bd2af460d83d1
https://github.com/python-control/python-control/pull/179/files#diff-cacf59417131c19becd6fba4dde9e979bed49ce572eb24f0f62bd2af460d83d1
control/margins.pyhttps://github.com/python-control/python-control/pull/179/files#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088
View file https://github.com/murrayrm/python-control/blob/2915bafa80c2e4e49259e1b7c61b26bb0150b3fe/control/margins.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/179/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/179/files#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088
https://github.com/python-control/python-control/pull/179/files#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088
https://github.com/python-control/python-control/pull/179/files#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088
https://github.com/python-control/python-control/pull/179/files#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088
https://github.com/python-control/python-control/pull/179/files#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088
https://github.com/python-control/python-control/pull/179/files#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088
https://github.com/python-control/python-control/pull/179/files#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088
control/statesp.pyhttps://github.com/python-control/python-control/pull/179/files#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
View file https://github.com/murrayrm/python-control/blob/2915bafa80c2e4e49259e1b7c61b26bb0150b3fe/control/statesp.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/179/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/179/files#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/179/files#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/179/files#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/179/files#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/179/files#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/179/files#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/179/files#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/179/files#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
control/tests/statesp_test.pyhttps://github.com/python-control/python-control/pull/179/files#diff-4c76080acbdea36493458693d93ec10e4e10b2e04ce01c56e8a81567cc1ea0d6
View file https://github.com/murrayrm/python-control/blob/2915bafa80c2e4e49259e1b7c61b26bb0150b3fe/control/tests/statesp_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/179/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/179/files#diff-4c76080acbdea36493458693d93ec10e4e10b2e04ce01c56e8a81567cc1ea0d6
https://github.com/python-control/python-control/pull/179/files#diff-4c76080acbdea36493458693d93ec10e4e10b2e04ce01c56e8a81567cc1ea0d6
https://github.com/python-control/python-control/pull/179/files#diff-4c76080acbdea36493458693d93ec10e4e10b2e04ce01c56e8a81567cc1ea0d6
https://github.com/python-control/python-control/pull/179/files#diff-4c76080acbdea36493458693d93ec10e4e10b2e04ce01c56e8a81567cc1ea0d6
control/tests/xferfcn_test.pyhttps://github.com/python-control/python-control/pull/179/files#diff-df824c2e70c14dd722d8f5b8d418f28180aa0d1a8dffa5e4b6271740d58cb2b2
View file https://github.com/murrayrm/python-control/blob/2915bafa80c2e4e49259e1b7c61b26bb0150b3fe/control/tests/xferfcn_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/179/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/179/files#diff-df824c2e70c14dd722d8f5b8d418f28180aa0d1a8dffa5e4b6271740d58cb2b2
https://github.com/python-control/python-control/pull/179/files#diff-df824c2e70c14dd722d8f5b8d418f28180aa0d1a8dffa5e4b6271740d58cb2b2
https://github.com/python-control/python-control/pull/179/files#diff-df824c2e70c14dd722d8f5b8d418f28180aa0d1a8dffa5e4b6271740d58cb2b2
https://github.com/python-control/python-control/pull/179/files#diff-df824c2e70c14dd722d8f5b8d418f28180aa0d1a8dffa5e4b6271740d58cb2b2
https://github.com/python-control/python-control/pull/179/files#diff-df824c2e70c14dd722d8f5b8d418f28180aa0d1a8dffa5e4b6271740d58cb2b2
control/xferfcn.pyhttps://github.com/python-control/python-control/pull/179/files#diff-0dd9424d3024fc1d5cc8fd67d13efe5703318c4c705526ab0ae216de69ce3de7
View file https://github.com/murrayrm/python-control/blob/2915bafa80c2e4e49259e1b7c61b26bb0150b3fe/control/xferfcn.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/179/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/179/files#diff-0dd9424d3024fc1d5cc8fd67d13efe5703318c4c705526ab0ae216de69ce3de7
https://github.com/python-control/python-control/pull/179/files#diff-0dd9424d3024fc1d5cc8fd67d13efe5703318c4c705526ab0ae216de69ce3de7
https://github.com/python-control/python-control/pull/179/files#diff-0dd9424d3024fc1d5cc8fd67d13efe5703318c4c705526ab0ae216de69ce3de7
https://github.com/python-control/python-control/pull/179/files#diff-0dd9424d3024fc1d5cc8fd67d13efe5703318c4c705526ab0ae216de69ce3de7
https://github.com/python-control/python-control/pull/179/files#diff-0dd9424d3024fc1d5cc8fd67d13efe5703318c4c705526ab0ae216de69ce3de7
https://github.com/python-control/python-control/pull/179/files#diff-0dd9424d3024fc1d5cc8fd67d13efe5703318c4c705526ab0ae216de69ce3de7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.