René's URL Explorer Experiment


Title: Update place to use scipy.signal.place_poles by rabraker · Pull Request #176 · python-control/python-control · GitHub

Open Graph Title: Update place to use scipy.signal.place_poles by rabraker · Pull Request #176 · python-control/python-control

X Title: Update place to use scipy.signal.place_poles by rabraker · Pull Request #176 · python-control/python-control

Description: This PR addresses issue #117 by using the place_poles function in scipy.signals. Aside from just being run in matlab_test.py, there wasn't, as far as I could tell, a unit test for place previously, so I added one. The one limitation of the algorithm used in scipy.signals is that it can't place multiple poles at the same location for SISO systems, which made the "test" in matlab_tests.place fail, so I modified the requested pole location there. Also worth pointing that the previous implementation would fail for discrete time systems because the slycot function needed to be called with a different flag and the alpha parameter needed to be computed differently.

Open Graph Description: This PR addresses issue #117 by using the place_poles function in scipy.signals. Aside from just being run in matlab_test.py, there wasn't, as far as I could tell, a unit test for place previo...

X Description: This PR addresses issue #117 by using the place_poles function in scipy.signals. Aside from just being run in matlab_test.py, there wasn't, as far as I could tell, a unit test for place pr...

Opengraph URL: https://github.com/python-control/python-control/pull/176

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8bfd3bfb-5eee-2880-574f-9205509755c2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBF5C:2D9D8E:17BF84D:1FF9732:697A989D
html-safe-nonce05121121eae1fdbc73be053be0833455dbd51d232522ba91833f6dc0cd3d3363
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjVDOjJEOUQ4RToxN0JGODREOjFGRjk3MzI6Njk3QTk4OUQiLCJ2aXNpdG9yX2lkIjoiNjA5NTI4NTk2ODk4MDA1NjIyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb790713e8fea01cfb100b3604b6f2c59f660757b109ec71869979e4962d080a6
hovercard-subject-tagpull_request:160862150
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/176/files
twitter:imagehttps://avatars.githubusercontent.com/u/10984684?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10984684?s=400&v=4
og:image:altThis PR addresses issue #117 by using the place_poles function in scipy.signals. Aside from just being run in matlab_test.py, there wasn't, as far as I could tell, a unit test for place previo...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef73c0dfa17dfe2bc934284d1387c1cedefe723d2133ede564feefd2cbeb98e55
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release58b9322bb0d01c6949be2239e39780fa702e604c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/176/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F176%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F176%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/176/files
Reloadhttps://github.com/python-control/python-control/pull/176/files
Reloadhttps://github.com/python-control/python-control/pull/176/files
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
murrayrmhttps://github.com/murrayrm
python-control:masterhttps://github.com/python-control/python-control/tree/master
rabraker:update_placehttps://github.com/rabraker/python-control/tree/update_place
Conversation 17 https://github.com/python-control/python-control/pull/176
Commits 6 https://github.com/python-control/python-control/pull/176/commits
Checks 0 https://github.com/python-control/python-control/pull/176/checks
Files changed https://github.com/python-control/python-control/pull/176/files
Please reload this pagehttps://github.com/python-control/python-control/pull/176/files
Update place to use scipy.signal.place_poles https://github.com/python-control/python-control/pull/176/files#top
Show all changes 6 commits https://github.com/python-control/python-control/pull/176/files
99302cd Modify statefbk.place to use the YT algorithm implemented in scipy.si… rabraker Jan 3, 2018 https://github.com/python-control/python-control/pull/176/commits/99302cdb44558d757865cd3a15c450a9d0d2ed8c
186d6d8 YT algo cannot place multiple poles at the same location when rk(B)=1… rabraker Jan 3, 2018 https://github.com/python-control/python-control/pull/176/commits/186d6d8e8468cbd8b5d7c0c435dbb9f085e5455f
311e9e2 Keep the original place code in a new function, place_varga. The scip… rabraker Jan 3, 2018 https://github.com/python-control/python-control/pull/176/commits/311e9e2d5330bc1d45dd38f2c00183db961290ad
100eb1f Added 'see also' to doc-strings rabraker Jan 3, 2018 https://github.com/python-control/python-control/pull/176/commits/100eb1f85542ae24382ac6dfe165af2cb4a05ff7
45fdea9 Added tests for acker, and place_varga. Added an assert_raises test f… rabraker Jan 4, 2018 https://github.com/python-control/python-control/pull/176/commits/45fdea97f426b5f37aa13b139ca524277a70ad04
70ecf75 Forgot to check that slycot is installed in testPlace_varga() rabraker Jan 4, 2018 https://github.com/python-control/python-control/pull/176/commits/70ecf7544b15a0b913eb04db0d92c234990e860b
Clear filters https://github.com/python-control/python-control/pull/176/files
Please reload this pagehttps://github.com/python-control/python-control/pull/176/files
Please reload this pagehttps://github.com/python-control/python-control/pull/176/files
statefbk.py https://github.com/python-control/python-control/pull/176/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
matlab_test.py https://github.com/python-control/python-control/pull/176/files#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
statefbk_test.py https://github.com/python-control/python-control/pull/176/files#diff-90f212319faaca2098d93d660936eab8762ef555c04db53a4b76e6ece773fc1d
control/statefbk.pyhttps://github.com/python-control/python-control/pull/176/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
View file https://github.com/rabraker/python-control/blob/70ecf7544b15a0b913eb04db0d92c234990e860b/control/statefbk.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/176/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/176/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
https://github.com/python-control/python-control/pull/176/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
https://github.com/python-control/python-control/pull/176/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
control/tests/matlab_test.pyhttps://github.com/python-control/python-control/pull/176/files#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
View file https://github.com/rabraker/python-control/blob/70ecf7544b15a0b913eb04db0d92c234990e860b/control/tests/matlab_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/176/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/176/files#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
https://github.com/python-control/python-control/pull/176/files#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
control/tests/statefbk_test.pyhttps://github.com/python-control/python-control/pull/176/files#diff-90f212319faaca2098d93d660936eab8762ef555c04db53a4b76e6ece773fc1d
View file https://github.com/rabraker/python-control/blob/70ecf7544b15a0b913eb04db0d92c234990e860b/control/tests/statefbk_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/176/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/176/files#diff-90f212319faaca2098d93d660936eab8762ef555c04db53a4b76e6ece773fc1d
https://github.com/python-control/python-control/pull/176/files#diff-90f212319faaca2098d93d660936eab8762ef555c04db53a4b76e6ece773fc1d
https://github.com/python-control/python-control/pull/176/files#diff-90f212319faaca2098d93d660936eab8762ef555c04db53a4b76e6ece773fc1d
murrayrmhttps://github.com/murrayrm
Jan 4, 2018https://github.com/python-control/python-control/pull/176/files#r159582299
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-control/python-control/pull/176/files
rabrakerhttps://github.com/rabraker
Jan 4, 2018https://github.com/python-control/python-control/pull/176/files#r159695167
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
(line 125)https://github.com/python-control/python-control/blob/df4ee828ec443a816c52285bc8df2589706ee132/control/tests/statefbk_test.py#L125
Please reload this pagehttps://github.com/python-control/python-control/pull/176/files
https://github.com/python-control/python-control/pull/176/files#diff-90f212319faaca2098d93d660936eab8762ef555c04db53a4b76e6ece773fc1d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.