René's URL Explorer Experiment


Title: Update place to use scipy.signal.place_poles by rabraker · Pull Request #176 · python-control/python-control · GitHub

Open Graph Title: Update place to use scipy.signal.place_poles by rabraker · Pull Request #176 · python-control/python-control

X Title: Update place to use scipy.signal.place_poles by rabraker · Pull Request #176 · python-control/python-control

Description: The Python Control Systems Library is a Python module that implements basic operations for analysis and design of feedback control systems. - Update place to use scipy.signal.place_poles by rabraker · Pull Request #176 · python-control/python-control

Open Graph Description: This PR addresses issue #117 by using the place_poles function in scipy.signals. Aside from just being run in matlab_test.py, there wasn't, as far as I could tell, a unit test for place previo...

X Description: This PR addresses issue #117 by using the place_poles function in scipy.signals. Aside from just being run in matlab_test.py, there wasn't, as far as I could tell, a unit test for place pr...

Opengraph URL: https://github.com/python-control/python-control/pull/176

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:7b0873ca-2840-b4f8-ea31-8c3b0e5f4b2a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC40E:5F4A4:73C87E:A09C2E:697A6BB7
html-safe-nonce056481c53194a9a09823f1308a4629e574ead06c8dc96222a03d1c0ff873b0f6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDBFOjVGNEE0OjczQzg3RTpBMDlDMkU6Njk3QTZCQjciLCJ2aXNpdG9yX2lkIjoiNzMwMjgxMDI0NzUxOTQzMTYwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca2bb15c35a9c91382ef5cc787da44efd7d9d8b59d8db3d65b477d81ef746409c
hovercard-subject-tagpull_request:160862150
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/176/commits
twitter:imagehttps://opengraph.githubassets.com/c90d44791a34f5db1b40f6af7b7675919e16c51725513fda97dee393950e185e/python-control/python-control/pull/176
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c90d44791a34f5db1b40f6af7b7675919e16c51725513fda97dee393950e185e/python-control/python-control/pull/176
og:image:altThis PR addresses issue #117 by using the place_poles function in scipy.signals. Aside from just being run in matlab_test.py, there wasn't, as far as I could tell, a unit test for place previo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerabraker
hostnamegithub.com
expected-hostnamegithub.com
None4f4c032790588250388c2e36a0e1ea776c0a3f887d37d994e1ac3d7ea79d34ef
turbo-cache-controlno-cache
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release06b3a5a9a6214e1e06e508d250d778cbaf17c577
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/176/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F176%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F176%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/176/commits
Reloadhttps://github.com/python-control/python-control/pull/176/commits
Reloadhttps://github.com/python-control/python-control/pull/176/commits
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
murrayrmhttps://github.com/murrayrm
python-control:masterhttps://github.com/python-control/python-control/tree/master
rabraker:update_placehttps://github.com/rabraker/python-control/tree/update_place
Conversationhttps://github.com/python-control/python-control/pull/176
Commits6 (6)https://github.com/python-control/python-control/pull/176/commits
Checkshttps://github.com/python-control/python-control/pull/176/checks
Files changedhttps://github.com/python-control/python-control/pull/176/changes
Update place to use scipy.signal.place_poleshttps://github.com/python-control/python-control/pull/176/commits#top
murrayrmhttps://github.com/murrayrm
python-control:masterhttps://github.com/python-control/python-control/tree/master
rabraker:update_placehttps://github.com/rabraker/python-control/tree/update_place
Modify statefbk.place to use the YT algorithm implemented in scipy.signals.place_poleshttps://github.com/python-control/python-control/pull/176/commits/99302cdb44558d757865cd3a15c450a9d0d2ed8c
https://github.com/rabraker
rabrakerhttps://github.com/python-control/python-control/commits?author=rabraker
99302cdhttps://github.com/python-control/python-control/pull/176/commits/99302cdb44558d757865cd3a15c450a9d0d2ed8c
https://github.com/python-control/python-control/tree/99302cdb44558d757865cd3a15c450a9d0d2ed8c
YT algo cannot place multiple poles at the same location when rk(B)=1. Also, aadd tests for control dimension checks.https://github.com/python-control/python-control/pull/176/commits/186d6d8e8468cbd8b5d7c0c435dbb9f085e5455f
https://github.com/rabraker
rabrakerhttps://github.com/python-control/python-control/commits?author=rabraker
186d6d8https://github.com/python-control/python-control/pull/176/commits/186d6d8e8468cbd8b5d7c0c435dbb9f085e5455f
https://github.com/python-control/python-control/tree/186d6d8e8468cbd8b5d7c0c435dbb9f085e5455f
Keep the original place code in a new function, place_varga. The scipy implementation of YT stays in place() properhttps://github.com/python-control/python-control/pull/176/commits/311e9e2d5330bc1d45dd38f2c00183db961290ad
https://github.com/rabraker
rabrakerhttps://github.com/python-control/python-control/commits?author=rabraker
311e9e2https://github.com/python-control/python-control/pull/176/commits/311e9e2d5330bc1d45dd38f2c00183db961290ad
https://github.com/python-control/python-control/tree/311e9e2d5330bc1d45dd38f2c00183db961290ad
Added 'see also' to doc-stringshttps://github.com/python-control/python-control/pull/176/commits/100eb1f85542ae24382ac6dfe165af2cb4a05ff7
https://github.com/rabraker
rabrakerhttps://github.com/python-control/python-control/commits?author=rabraker
100eb1fhttps://github.com/python-control/python-control/pull/176/commits/100eb1f85542ae24382ac6dfe165af2cb4a05ff7
https://github.com/python-control/python-control/tree/100eb1f85542ae24382ac6dfe165af2cb4a05ff7
Added tests for acker, and place_varga. Added an assert_raises test for repeated poles in place. Added placeholder tests in matlab_test for place and acker and reverted the repeated pole test for p…https://github.com/python-control/python-control/pull/176/commits/45fdea97f426b5f37aa13b139ca524277a70ad04
https://github.com/rabraker
rabrakerhttps://github.com/python-control/python-control/commits?author=rabraker
45fdea9https://github.com/python-control/python-control/pull/176/commits/45fdea97f426b5f37aa13b139ca524277a70ad04
https://github.com/python-control/python-control/tree/45fdea97f426b5f37aa13b139ca524277a70ad04
Forgot to check that slycot is installed in testPlace_varga()https://github.com/python-control/python-control/pull/176/commits/70ecf7544b15a0b913eb04db0d92c234990e860b
https://github.com/rabraker
rabrakerhttps://github.com/python-control/python-control/commits?author=rabraker
70ecf75https://github.com/python-control/python-control/pull/176/commits/70ecf7544b15a0b913eb04db0d92c234990e860b
https://github.com/python-control/python-control/tree/70ecf7544b15a0b913eb04db0d92c234990e860b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.