Title: Update place to use scipy.signal.place_poles by rabraker · Pull Request #176 · python-control/python-control · GitHub
Open Graph Title: Update place to use scipy.signal.place_poles by rabraker · Pull Request #176 · python-control/python-control
X Title: Update place to use scipy.signal.place_poles by rabraker · Pull Request #176 · python-control/python-control
Description: This PR addresses issue #117 by using the place_poles function in scipy.signals. Aside from just being run in matlab_test.py, there wasn't, as far as I could tell, a unit test for place previously, so I added one. The one limitation of the algorithm used in scipy.signals is that it can't place multiple poles at the same location for SISO systems, which made the "test" in matlab_tests.place fail, so I modified the requested pole location there. Also worth pointing that the previous implementation would fail for discrete time systems because the slycot function needed to be called with a different flag and the alpha parameter needed to be computed differently.
Open Graph Description: This PR addresses issue #117 by using the place_poles function in scipy.signals. Aside from just being run in matlab_test.py, there wasn't, as far as I could tell, a unit test for place previo...
X Description: This PR addresses issue #117 by using the place_poles function in scipy.signals. Aside from just being run in matlab_test.py, there wasn't, as far as I could tell, a unit test for place pr...
Opengraph URL: https://github.com/python-control/python-control/pull/176
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:fd45aab3-6b50-f3bc-fb8d-1c3bfdafaf43 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | DF82:32DC25:12EABF6:1B1929B:697A38AA |
| html-safe-nonce | 4bb1605c8f1dde121b29bf9f1311318901bac9558c0fa17c6aa5ed55bcdcc315 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjgyOjMyREMyNToxMkVBQkY2OjFCMTkyOUI6Njk3QTM4QUEiLCJ2aXNpdG9yX2lkIjoiMzAzNTE3NTAxMDk5NDYzMjg3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | abe9cd27eeeae229475b753ae4715905bd85814c70efaf2c18216faf78b8096a |
| hovercard-subject-tag | pull_request:160862150 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/176/checks |
| twitter:image | https://avatars.githubusercontent.com/u/10984684?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/10984684?s=400&v=4 |
| og:image:alt | This PR addresses issue #117 by using the place_poles function in scipy.signals. Aside from just being run in matlab_test.py, there wasn't, as far as I could tell, a unit test for place previo... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | af6de804ceb83ad30bb9b348cdeaccaa30cdcb566762d5e74e21e2bad88885d0 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2d980605f0959039ddebcbcf522b072508302977 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width