René's URL Explorer Experiment


Title: Update place to use scipy.signal.place_poles by rabraker · Pull Request #176 · python-control/python-control · GitHub

Open Graph Title: Update place to use scipy.signal.place_poles by rabraker · Pull Request #176 · python-control/python-control

X Title: Update place to use scipy.signal.place_poles by rabraker · Pull Request #176 · python-control/python-control

Description: This PR addresses issue #117 by using the place_poles function in scipy.signals. Aside from just being run in matlab_test.py, there wasn't, as far as I could tell, a unit test for place previously...

Open Graph Description: This PR addresses issue #117 by using the place_poles function in scipy.signals. Aside from just being run in matlab_test.py, there wasn't, as far as I could tell, a unit test for place previo...

X Description: This PR addresses issue #117 by using the place_poles function in scipy.signals. Aside from just being run in matlab_test.py, there wasn't, as far as I could tell, a unit test for place pr...

Opengraph URL: https://github.com/python-control/python-control/pull/176

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3f6c063a-3ff7-3379-9326-39fdd88da49e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD03E:9D1FC:60674F:8A60DD:697A1CBA
html-safe-nonce4c23c98463134b38dfbef2f2bfe53d20c1314e667d3f670bc2990c2e20f3e65b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDNFOjlEMUZDOjYwNjc0Rjo4QTYwREQ6Njk3QTFDQkEiLCJ2aXNpdG9yX2lkIjoiMzg0NjYwODgzMjc0MjE2OTc4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac516b953bcb20a7a0e110d239a535fa3fc7dbe9007acecb5e7e5ccc9ae236180b
hovercard-subject-tagpull_request:160862150
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-control/python-control/176/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c90d44791a34f5db1b40f6af7b7675919e16c51725513fda97dee393950e185e/python-control/python-control/pull/176
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c90d44791a34f5db1b40f6af7b7675919e16c51725513fda97dee393950e185e/python-control/python-control/pull/176
og:image:altThis PR addresses issue #117 by using the place_poles function in scipy.signals. Aside from just being run in matlab_test.py, there wasn't, as far as I could tell, a unit test for place previo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerabraker
hostnamegithub.com
expected-hostnamegithub.com
None24021c77440f544078f9cbe80d78a2fb16ccff65fca92deda9da3c51d1cdc5fc
turbo-cache-controlno-preview
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2841ead760bbcdca99003cf970f91348178160c3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/176#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F176
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F176
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/176
Reloadhttps://github.com/python-control/python-control/pull/176
Reloadhttps://github.com/python-control/python-control/pull/176
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python-control/python-control/pull/176#issue-comment-box
murrayrmhttps://github.com/murrayrm
python-control:masterhttps://github.com/python-control/python-control/tree/master
rabraker:update_placehttps://github.com/rabraker/python-control/tree/update_place
Update place to use scipy.signal.place_poles https://github.com/python-control/python-control/pull/176#top
murrayrmhttps://github.com/murrayrm
python-control:masterhttps://github.com/python-control/python-control/tree/master
rabraker:update_placehttps://github.com/rabraker/python-control/tree/update_place
Conversation 17 https://github.com/python-control/python-control/pull/176
Commits 6 https://github.com/python-control/python-control/pull/176/commits
Checks 0 https://github.com/python-control/python-control/pull/176/checks
Files changed https://github.com/python-control/python-control/pull/176/files
Please reload this pagehttps://github.com/python-control/python-control/pull/176
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/{{ revealButtonHref }}
https://github.com/rabraker
rabrakerhttps://github.com/rabraker
Jan 3, 2018https://github.com/python-control/python-control/pull/176#issue-285619419
#117https://github.com/python-control/python-control/issues/117
Please reload this pagehttps://github.com/python-control/python-control/pull/176
rabrakerhttps://github.com/rabraker
January 2, 2018 17:17https://github.com/python-control/python-control/pull/176#commits-pushed-99302cd
https://github.com/rabraker
Modify statefbk.place to use the YT algorithm implemented in scipy.si…https://github.com/python-control/python-control/pull/176/commits/99302cdb44558d757865cd3a15c450a9d0d2ed8c
99302cdhttps://github.com/python-control/python-control/pull/176/commits/99302cdb44558d757865cd3a15c450a9d0d2ed8c
https://github.com/rabraker
YT algo cannot place multiple poles at the same location when rk(B)=1…https://github.com/python-control/python-control/pull/176/commits/186d6d8e8468cbd8b5d7c0c435dbb9f085e5455f
186d6d8https://github.com/python-control/python-control/pull/176/commits/186d6d8e8468cbd8b5d7c0c435dbb9f085e5455f
https://github.com/coveralls
coverallshttps://github.com/coveralls
Jan 3, 2018https://github.com/python-control/python-control/pull/176#issuecomment-354955746
Please reload this pagehttps://github.com/python-control/python-control/pull/176
https://coveralls.io/builds/14877669
186d6d8https://github.com/python-control/python-control/commit/186d6d8e8468cbd8b5d7c0c435dbb9f085e5455f
df4ee82https://github.com/python-control/python-control/commit/df4ee828ec443a816c52285bc8df2589706ee132
Please reload this pagehttps://github.com/python-control/python-control/pull/176
https://github.com/murrayrm
murrayrmhttps://github.com/murrayrm
Jan 3, 2018https://github.com/python-control/python-control/pull/176#issuecomment-355053945
Please reload this pagehttps://github.com/python-control/python-control/pull/176
#117https://github.com/python-control/python-control/issues/117
@rabrakerhttps://github.com/rabraker
@vmatoshttps://github.com/vmatos
@robertobucherhttps://github.com/robertobucher
Please reload this pagehttps://github.com/python-control/python-control/pull/176
https://github.com/cwrowley
cwrowleyhttps://github.com/cwrowley
Jan 3, 2018https://github.com/python-control/python-control/pull/176#issuecomment-355056802
Please reload this pagehttps://github.com/python-control/python-control/pull/176
https://github.com/rabraker
rabrakerhttps://github.com/rabraker
Jan 3, 2018https://github.com/python-control/python-control/pull/176#issuecomment-355076651
Please reload this pagehttps://github.com/python-control/python-control/pull/176
https://github.com/ilayn
ilaynhttps://github.com/ilayn
Jan 3, 2018https://github.com/python-control/python-control/pull/176#issuecomment-355082318
Please reload this pagehttps://github.com/python-control/python-control/pull/176
https://github.com/murrayrm
murrayrmhttps://github.com/murrayrm
Jan 3, 2018https://github.com/python-control/python-control/pull/176#issuecomment-355088866
Please reload this pagehttps://github.com/python-control/python-control/pull/176
@rabrakerhttps://github.com/rabraker
@ilaynhttps://github.com/ilayn
Please reload this pagehttps://github.com/python-control/python-control/pull/176
https://github.com/rabraker
rabrakerhttps://github.com/rabraker
Jan 3, 2018https://github.com/python-control/python-control/pull/176#issuecomment-355096714
Please reload this pagehttps://github.com/python-control/python-control/pull/176
https://github.com/rabraker
Keep the original place code in a new function, place_varga. The scip…https://github.com/python-control/python-control/pull/176/commits/311e9e2d5330bc1d45dd38f2c00183db961290ad
311e9e2https://github.com/python-control/python-control/pull/176/commits/311e9e2d5330bc1d45dd38f2c00183db961290ad
https://github.com/coveralls
coverallshttps://github.com/coveralls
Jan 3, 2018https://github.com/python-control/python-control/pull/176#issuecomment-355111543
Please reload this pagehttps://github.com/python-control/python-control/pull/176
https://coveralls.io/builds/14887265
311e9e2https://github.com/python-control/python-control/commit/311e9e2d5330bc1d45dd38f2c00183db961290ad
df4ee82https://github.com/python-control/python-control/commit/df4ee828ec443a816c52285bc8df2589706ee132
Please reload this pagehttps://github.com/python-control/python-control/pull/176
https://github.com/rabraker
rabrakerhttps://github.com/rabraker
Jan 3, 2018 https://github.com/python-control/python-control/pull/176#ref-issue-285803519
place function fails for simple case #177 https://github.com/python-control/python-control/issues/177
https://github.com/rabraker
rabrakerhttps://github.com/rabraker
Jan 3, 2018https://github.com/python-control/python-control/pull/176#issuecomment-355121978
bug reporthttps://github.com/python-control/python-control/issues/177
Please reload this pagehttps://github.com/python-control/python-control/pull/176
https://github.com/rabraker
Added 'see also' to doc-stringshttps://github.com/python-control/python-control/pull/176/commits/100eb1f85542ae24382ac6dfe165af2cb4a05ff7
100eb1fhttps://github.com/python-control/python-control/pull/176/commits/100eb1f85542ae24382ac6dfe165af2cb4a05ff7
https://github.com/coveralls
coverallshttps://github.com/coveralls
Jan 3, 2018https://github.com/python-control/python-control/pull/176#issuecomment-355155246
Please reload this pagehttps://github.com/python-control/python-control/pull/176
https://coveralls.io/builds/14890572
100eb1fhttps://github.com/python-control/python-control/commit/100eb1f85542ae24382ac6dfe165af2cb4a05ff7
df4ee82https://github.com/python-control/python-control/commit/df4ee828ec443a816c52285bc8df2589706ee132
Please reload this pagehttps://github.com/python-control/python-control/pull/176
https://github.com/murrayrm
murrayrmhttps://github.com/murrayrm
Jan 4, 2018 https://github.com/python-control/python-control/pull/176#pullrequestreview-86554184
View reviewed changes https://github.com/python-control/python-control/pull/176/files/100eb1f85542ae24382ac6dfe165af2cb4a05ff7
control/tests/matlab_test.pyhttps://github.com/python-control/python-control/pull/176/files/100eb1f85542ae24382ac6dfe165af2cb4a05ff7#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
murrayrmhttps://github.com/murrayrm
Jan 4, 2018https://github.com/python-control/python-control/pull/176#discussion_r159582260
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-control/python-control/pull/176
rabrakerhttps://github.com/rabraker
Jan 4, 2018https://github.com/python-control/python-control/pull/176#discussion_r159692961
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-control/python-control/pull/176
control/tests/statefbk_test.pyhttps://github.com/python-control/python-control/pull/176/files/100eb1f85542ae24382ac6dfe165af2cb4a05ff7#diff-90f212319faaca2098d93d660936eab8762ef555c04db53a4b76e6ece773fc1d
murrayrmhttps://github.com/murrayrm
Jan 4, 2018https://github.com/python-control/python-control/pull/176#discussion_r159582299
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-control/python-control/pull/176
rabrakerhttps://github.com/rabraker
Jan 4, 2018https://github.com/python-control/python-control/pull/176#discussion_r159695167
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
(line 125)https://github.com/python-control/python-control/blob/df4ee828ec443a816c52285bc8df2589706ee132/control/tests/statefbk_test.py#L125
Please reload this pagehttps://github.com/python-control/python-control/pull/176
rabrakerhttps://github.com/rabraker
January 4, 2018 09:15https://github.com/python-control/python-control/pull/176#commits-pushed-45fdea9
https://github.com/rabraker
Added tests for acker, and place_varga. Added an assert_raises test f…https://github.com/python-control/python-control/pull/176/commits/45fdea97f426b5f37aa13b139ca524277a70ad04
45fdea9https://github.com/python-control/python-control/pull/176/commits/45fdea97f426b5f37aa13b139ca524277a70ad04
https://github.com/rabraker
Forgot to check that slycot is installed in testPlace_varga()https://github.com/python-control/python-control/pull/176/commits/70ecf7544b15a0b913eb04db0d92c234990e860b
70ecf75https://github.com/python-control/python-control/pull/176/commits/70ecf7544b15a0b913eb04db0d92c234990e860b
https://github.com/coveralls
coverallshttps://github.com/coveralls
Jan 4, 2018https://github.com/python-control/python-control/pull/176#issuecomment-355329446
Please reload this pagehttps://github.com/python-control/python-control/pull/176
https://coveralls.io/builds/14901572
45fdea9https://github.com/python-control/python-control/commit/45fdea97f426b5f37aa13b139ca524277a70ad04
df4ee82https://github.com/python-control/python-control/commit/df4ee828ec443a816c52285bc8df2589706ee132
Please reload this pagehttps://github.com/python-control/python-control/pull/176
https://github.com/coveralls
coverallshttps://github.com/coveralls
Jan 4, 2018https://github.com/python-control/python-control/pull/176#issuecomment-355333421
Please reload this pagehttps://github.com/python-control/python-control/pull/176
https://coveralls.io/builds/14901813
70ecf75https://github.com/python-control/python-control/commit/70ecf7544b15a0b913eb04db0d92c234990e860b
df4ee82https://github.com/python-control/python-control/commit/df4ee828ec443a816c52285bc8df2589706ee132
Please reload this pagehttps://github.com/python-control/python-control/pull/176
https://github.com/ilayn
ilaynhttps://github.com/ilayn
Jan 4, 2018https://github.com/python-control/python-control/pull/176#issuecomment-355410749
Please reload this pagehttps://github.com/python-control/python-control/pull/176
https://github.com/murrayrm
murrayrmhttps://github.com/murrayrm
7c5f28dhttps://github.com/python-control/python-control/commit/7c5f28da492a16e0160b14025ea4aff17286a290
Jan 5, 2018https://github.com/python-control/python-control/pull/176#event-1410732570
https://github.com/rabraker
rabrakerhttps://github.com/rabraker
January 5, 2018 08:39https://github.com/python-control/python-control/pull/176#event-1410900518
https://github.com/murrayrm
murrayrmhttps://github.com/murrayrm
Dec 23, 2018 https://github.com/python-control/python-control/pull/176#ref-issue-393724193
Figure out a way to specify which algorithm to run when multiple choices are available #255 https://github.com/python-control/python-control/issues/255
https://github.com/pierre-haessig
pierre-haessighttps://github.com/pierre-haessig
May 15, 2024 https://github.com/python-control/python-control/pull/176#ref-pullrequest-2297228956
add place_varga in API doc #1004 https://github.com/python-control/python-control/pull/1004
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F176
https://github.com/murrayrm
murrayrm https://github.com/murrayrm
https://github.com/python-control/python-control/pull/176/files/100eb1f85542ae24382ac6dfe165af2cb4a05ff7
Please reload this pagehttps://github.com/python-control/python-control/pull/176
https://github.com/rabraker
https://github.com/coveralls
https://github.com/murrayrm
https://github.com/cwrowley
https://github.com/ilayn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.