Title: Fixes for SciPy 1.0 compatibility by murrayrm · Pull Request #170 · python-control/python-control · GitHub
Open Graph Title: Fixes for SciPy 1.0 compatibility by murrayrm · Pull Request #170 · python-control/python-control
X Title: Fixes for SciPy 1.0 compatibility by murrayrm · Pull Request #170 · python-control/python-control
Description: This PR fixes the SciPy 1.0 compatibility issues raised in issue #164. There are two main changes: Updated statesp.py and xferfcn.py to use the new forms of the scipy.signal library, for which the lti class no longer has accessors for num, den, etc. The fix is to directly call the ss2tf and tf2ss functions. Also had to add a check for scalars that are of a numpy data type, specifically for int64. Prior to Python 3, checking against int worked correctly, but this is no longer the case. As a fix, I added checks throughout the library against numpy.number, which captures all scalar data types in numpy. I also checked (manually) to insure that this version works against scipy-0.19.0, which should mean it is OK for backward compatibility (this can be checked with PR #169 is merged).
Open Graph Description: This PR fixes the SciPy 1.0 compatibility issues raised in issue #164. There are two main changes: Updated statesp.py and xferfcn.py to use the new forms of the scipy.signal library, for which t...
X Description: This PR fixes the SciPy 1.0 compatibility issues raised in issue #164. There are two main changes: Updated statesp.py and xferfcn.py to use the new forms of the scipy.signal library, for which t...
Opengraph URL: https://github.com/python-control/python-control/pull/170
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:8d64f82c-4194-56c4-5eec-f88e7432dd37 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | DDB8:2ED767:3DC878B:5330F13:697B0C82 |
| html-safe-nonce | addcf8fe2b43bb32f0ba96d314c5607ec86331aa9052733d86700107a726fd65 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREI4OjJFRDc2NzozREM4NzhCOjUzMzBGMTM6Njk3QjBDODIiLCJ2aXNpdG9yX2lkIjoiNDg2MzkwNjIwMDgzMzE2NjQ2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e7433a60fd440dab6a48a8be04882f560801c8060c993a535e5b4ed5ff956cf4 |
| hovercard-subject-tag | pull_request:159973680 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/170/checks |
| twitter:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| og:image:alt | This PR fixes the SciPy 1.0 compatibility issues raised in issue #164. There are two main changes: Updated statesp.py and xferfcn.py to use the new forms of the scipy.signal library, for which t... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7ce8ed0a54c4730aeca4e6abacfc6490365fc42e25480b86883054df3f9181c8 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d7bfc78137af9a4828305e52ab993fce981d7085 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width