| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:7127e05c-d5cb-71ab-6522-1d6cbbf0b291 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D192:30D095:562319:729C87:697D233F |
| html-safe-nonce | 67f19582e1ff0c08c4f11234e8de8f6748582be47110970bc14d280c3da9e736 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTkyOjMwRDA5NTo1NjIzMTk6NzI5Qzg3OjY5N0QyMzNGIiwidmlzaXRvcl9pZCI6IjQ5MjM2MTQyMDM1NzA1MTE5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7f0a8dd5d55b45bfc291ca7e200e81cc284590728ac5e0c747e895edcc6bd7d9 |
| hovercard-subject-tag | pull_request:111686573 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/138/files |
| twitter:image | https://avatars.githubusercontent.com/u/22224387?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/22224387?s=400&v=4 |
| og:image:alt | Add gains up to a tolerance is achived.
@slivingston I wait for reviews. I have a file with some examples that are an exersice taken from Franklyn book. Let me know if you need it to test the algor... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 85f2067815dbbcfc3c95ddc086aaa4bb85c804c8c1fb2c0a58abac2793271b0b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2c8ad0f3fda6467e88f69a0b1fb9a04f96d34a4d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python-control/python-control/pull/138/changes#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F138%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F138%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control |
| Reload | https://github.com/python-control/python-control/pull/138/changes |
| Reload | https://github.com/python-control/python-control/pull/138/changes |
| Reload | https://github.com/python-control/python-control/pull/138/changes |
|
python-control
| https://github.com/python-control |
| python-control | https://github.com/python-control/python-control |
|
Notifications
| https://github.com/login?return_to=%2Fpython-control%2Fpython-control |
|
Fork
447
| https://github.com/login?return_to=%2Fpython-control%2Fpython-control |
|
Star
2k
| https://github.com/login?return_to=%2Fpython-control%2Fpython-control |
|
Code
| https://github.com/python-control/python-control |
|
Issues
87
| https://github.com/python-control/python-control/issues |
|
Pull requests
8
| https://github.com/python-control/python-control/pulls |
|
Discussions
| https://github.com/python-control/python-control/discussions |
|
Actions
| https://github.com/python-control/python-control/actions |
|
Projects
0
| https://github.com/python-control/python-control/projects |
|
Wiki
| https://github.com/python-control/python-control/wiki |
|
Security
0
| https://github.com/python-control/python-control/security |
|
Insights
| https://github.com/python-control/python-control/pulse |
|
Code
| https://github.com/python-control/python-control |
|
Issues
| https://github.com/python-control/python-control/issues |
|
Pull requests
| https://github.com/python-control/python-control/pulls |
|
Discussions
| https://github.com/python-control/python-control/discussions |
|
Actions
| https://github.com/python-control/python-control/actions |
|
Projects
| https://github.com/python-control/python-control/projects |
|
Wiki
| https://github.com/python-control/python-control/wiki |
|
Security
| https://github.com/python-control/python-control/security |
|
Insights
| https://github.com/python-control/python-control/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose |
| murrayrm | https://github.com/murrayrm |
| python-control:master | https://github.com/python-control/python-control/tree/master |
|
Conversation
24
| https://github.com/python-control/python-control/pull/138 |
|
Commits
21
| https://github.com/python-control/python-control/pull/138/commits |
|
Checks
0
| https://github.com/python-control/python-control/pull/138/checks |
|
Files changed
| https://github.com/python-control/python-control/pull/138/files |
| Please reload this page | https://github.com/python-control/python-control/pull/138/changes |
|
add unsupervised calculation on gains for root locus plot.
| https://github.com/python-control/python-control/pull/138/changes#top |
|
Show all changes
21 commits
| https://github.com/python-control/python-control/pull/138/files |
|
ffc3041
add unsupervised calculation on gains for root locus plot.
gonmolina Mar 21, 2017
| https://github.com/python-control/python-control/pull/138/commits/ffc304158d0016089fcc7698bcd4a01f2f45c1d1 |
|
2aada8b
fix bug concatenating zero dimensional array
gonmolina Mar 21, 2017
| https://github.com/python-control/python-control/pull/138/commits/2aada8b1e0aaa73211fcccbfb79d02ccc5fbdbd0 |
|
7130434
fix bug concatenating zero dimensional when test in matlab_test.py
gonmolina Mar 21, 2017
| https://github.com/python-control/python-control/pull/138/commits/71304344ffe724840e2af200d891fc9bc1d96b43 |
|
8b829cc
fix bug with array==0! problem test in matlab_test.py
gonmolina Mar 21, 2017
| https://github.com/python-control/python-control/pull/138/commits/8b829ccfcc051483c277c899af39e748a362a260 |
|
d4cbc95
fix bug with axis limits with no asymptotes
gonmolina Mar 23, 2017
| https://github.com/python-control/python-control/pull/138/commits/d4cbc958a123e864307a60d9a88bf1ea2d5ee4ee |
|
6d55d57
fix bug calculating kmax
gonmolina Mar 23, 2017
| https://github.com/python-control/python-control/pull/138/commits/6d55d573d3618ed3ba25030beaf042bb1bc41b68 |
|
01e33ea
add unsupervised calculation on gains for root locus plot.
gonmolina Mar 21, 2017
| https://github.com/python-control/python-control/pull/138/commits/01e33ea6ef9e606a36909e36129fe9fa85e6fdcc |
|
95d6908
fix bug with axis limits with no asymptotes
gonmolina Mar 23, 2017
| https://github.com/python-control/python-control/pull/138/commits/95d69080af42a541ae98b2142d1a99ec377397d0 |
|
1b20bd4
add sgrid to rlocus plot, to the last version of unsupervised gains.
gonmolina Mar 31, 2017
| https://github.com/python-control/python-control/pull/138/commits/1b20bd4e97adda170d9b2d4148b206287a81588d |
|
5e47d1f
add origin to rlocus plot and x=0 line (zeta =0 grid line).
gonmolina Mar 31, 2017
| https://github.com/python-control/python-control/pull/138/commits/5e47d1f128f1d2a573218e47c170d52ae02c00cd |
|
ebd3904
add grid arguments in docstring.
gonmolina Mar 31, 2017
| https://github.com/python-control/python-control/pull/138/commits/ebd39047108c35712cfc67fe819f3186e85c256c |
|
3fb2c86
Merge remote-tracking branch 'origin/unsup_rlocus_gain_selection' int…
gonmolina Mar 31, 2017
| https://github.com/python-control/python-control/pull/138/commits/3fb2c868fbaeec8df928ebfe17d664640405f242 |
|
de87bb0
reorder code that calculate defaults damp coefficents constant lines …
gonmolina Apr 2, 2017
| https://github.com/python-control/python-control/pull/138/commits/de87bb0ff1b8bace2efc78efd45d19c81bd5affc |
|
5438746
formatting code to make easier sgrid() function in future.
gonmolina Apr 2, 2017
| https://github.com/python-control/python-control/pull/138/commits/5438746ba1b7ce69bf9b9f26d727c5fe79c7b893 |
|
1e356b8
trying that algorithm work with 0 degrees root locus with equal numbe…
gonmolina Jun 8, 2017
| https://github.com/python-control/python-control/pull/138/commits/1e356b8515436a61dd443b1468bcd702a07d4437 |
|
6c813ce
adding some support for 0 degrees root locus.
gonmolina Jun 13, 2017
| https://github.com/python-control/python-control/pull/138/commits/6c813ce107cc121ee96e9cafa9c280c8e5b9cc38 |
|
6e4d14f
add book reference of root locus calculation.
gonmolina Jun 13, 2017
| https://github.com/python-control/python-control/pull/138/commits/6e4d14f105c75dbbb0a4c1d121c4f82bb5492d5e |
|
a680c6a
fix minor bug when fartest point is zero.
gonmolina Jun 14, 2017
| https://github.com/python-control/python-control/pull/138/commits/a680c6a234e9a022b64b15ab1053b3c7a419bb6b |
|
81b73a6
fix minor bugs when that solves problems in paricular cases
gonmolina Jun 17, 2017
| https://github.com/python-control/python-control/pull/138/commits/81b73a6b6e949e7666692821c45d834c8169958d |
|
62ed2aa
Fixed requested issues.
gonmolina Jun 30, 2017
| https://github.com/python-control/python-control/pull/138/commits/62ed2aac9aaa0423e0aa5d781ec6cfb050a6c775 |
|
4eedde4
fix build problem (numerical problem)
gonmolina Jul 1, 2017
| https://github.com/python-control/python-control/pull/138/commits/4eedde4bf8844a28f9a583d83fee4b3a450d5f1c |
|
Clear filters
| https://github.com/python-control/python-control/pull/138/files |
| Please reload this page | https://github.com/python-control/python-control/pull/138/changes |
| Please reload this page | https://github.com/python-control/python-control/pull/138/changes |
| control/rlocus.py | https://github.com/python-control/python-control/pull/138/changes#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee |
|
View file
| https://github.com/python-control/python-control/blob/4eedde4bf8844a28f9a583d83fee4b3a450d5f1c/control/rlocus.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python-control/python-control/pull/138/{{ revealButtonHref }} |
|
| https://github.com/python-control/python-control/pull/138/changes#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee |
|
| https://github.com/python-control/python-control/pull/138/changes#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee |
|
| https://github.com/python-control/python-control/pull/138/changes#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee |
|
| https://github.com/python-control/python-control/pull/138/changes#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee |
|
| https://github.com/python-control/python-control/pull/138/changes#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee |
|
| https://github.com/python-control/python-control/pull/138/changes#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee |
|
| https://github.com/python-control/python-control/pull/138/changes#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee |
|
| https://github.com/python-control/python-control/pull/138/changes#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |