Title: Update Nyquist rescaling + other improvements by murrayrm · Pull Request #1155 · python-control/python-control · GitHub
Open Graph Title: Update Nyquist rescaling + other improvements by murrayrm · Pull Request #1155 · python-control/python-control
X Title: Update Nyquist rescaling + other improvements by murrayrm · Pull Request #1155 · python-control/python-control
Description: This PR addresses issue #1143 by changing the way that rescaling is handled in nyquist_plot. The prior code saturated the Nyquist curve at max_curve_magnitude, which would leave to confusing plots when the Nyquist curve had interesting features at large magnitude, since all of that detail was "collapsed" onto the limiting circle. In the new code, a 1-1 rescaling function is used that maps large magnitude features into a continuous range of magnitudes starting at a "blend point" and going out to max_curve_magnitude. The result is that the features of the Nyquist curve can be more easily visualized. The fraction of the Nyquist curve that is "blended" is set with a new parameter blend_fraction, that defaults to 0.20 (so the last 20% of the Nyquist curve prior to max_curve_magnitude is rescaled, with everything from the blend point to $\infty$ mapping from the blend point to max_curve_magnitude. Using the example that @JonHowMIT raised in issue #1143, we go from this: to this: The original behavior can be retained by setting blend_fraction=0. A few other changes that are also part of this PR: Updated max_curve_magnitude from a default of 20 to 15 (this allows the -1 point to be see better). Updated the default number of arrows from 2 to 3 (looked better in the gallery of plots available in control/tests/nyquist_test. Modified control/tests/nyquist_test to generate a gallery of plots when run as a script (via python or ipython). Changed the output of nyquist_plot to match its documentation. In particular, cplt.lines was returning a 1D array instead of a 2D array (as done in all other _plot functions). Updated unit tests and examples.
Open Graph Description: This PR addresses issue #1143 by changing the way that rescaling is handled in nyquist_plot. The prior code saturated the Nyquist curve at max_curve_magnitude, which would leave to confusing plots...
X Description: This PR addresses issue #1143 by changing the way that rescaling is handled in nyquist_plot. The prior code saturated the Nyquist curve at max_curve_magnitude, which would leave to confusing plots...
Opengraph URL: https://github.com/python-control/python-control/pull/1155
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d8175afb-e884-78db-70cc-a23f07a11d01 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E304:264316:101C868:156F3DA:697C0BE3 |
| html-safe-nonce | 57bce9355f7ec6e91efbfbdfbdf39e9f3fee83d3f5f3087c848bd53adefd679c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzA0OjI2NDMxNjoxMDFDODY4OjE1NkYzREE6Njk3QzBCRTMiLCJ2aXNpdG9yX2lkIjoiNDcyMzUxNTgwMTY2OTk5NTQ5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 20af1e91bcbe8cab9c3db108859a8b72a1793363aaf35d4d0ca85ed3c079fc17 |
| hovercard-subject-tag | pull_request:2609229889 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/1155/files |
| twitter:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| og:image:alt | This PR addresses issue #1143 by changing the way that rescaling is handled in nyquist_plot. The prior code saturated the Nyquist curve at max_curve_magnitude, which would leave to confusing plots... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | da4f0ee56809799586f8ee546b27f94fe9b5893edfbf87732e82be45be013b52 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3bd97d62125e07907af495e8aff5afc2a9f2a1a6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width
