| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cc72f68b-b49c-3951-784d-e21e2134b6ff |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C3C6:1C32A2:1DF0A11:2A71335:697A5356 |
| html-safe-nonce | 2481f504a201599de4aa30ba042449f4e5cfc5024cdba08a16434d236f15cfe3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0M2OjFDMzJBMjoxREYwQTExOjJBNzEzMzU6Njk3QTUzNTYiLCJ2aXNpdG9yX2lkIjoiNTM1ODM5NDEwOTI2ODIxODcxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 43829827743ae98e4d68c3bf090e378fb2b572432d45a1a29e5dfb59a6bc4e92 |
| hovercard-subject-tag | pull_request:2478921952 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-control/python-control/1146/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2e2d7c29dc5ee6c9d87cfb3723dbe0171daaab234eceea9b71f19ccf5f2d151c/python-control/python-control/pull/1146 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2e2d7c29dc5ee6c9d87cfb3723dbe0171daaab234eceea9b71f19ccf5f2d151c/python-control/python-control/pull/1146 |
| og:image:alt | Am relatively new to this toolbox, have been using it here and there and found #726.
This is an initial prototype Python implementation of disk margins, built on top of python-control and slycot. ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | josiahdelange |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6675d94efd2a33cdba9e6e611f931ac7eaa988d8fef14b7a663cc012c4501b42 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ca995a95b56cf8bd27cc89fcea65d2ad787f53c1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python-control/python-control/pull/1146#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F1146 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F1146 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-control%2Fpython-control |
| Reload | https://github.com/python-control/python-control/pull/1146 |
| Reload | https://github.com/python-control/python-control/pull/1146 |
| Reload | https://github.com/python-control/python-control/pull/1146 |
|
python-control
| https://github.com/python-control |
| python-control | https://github.com/python-control/python-control |
|
Notifications
| https://github.com/login?return_to=%2Fpython-control%2Fpython-control |
|
Fork
447
| https://github.com/login?return_to=%2Fpython-control%2Fpython-control |
|
Star
2k
| https://github.com/login?return_to=%2Fpython-control%2Fpython-control |
|
Code
| https://github.com/python-control/python-control |
|
Issues
87
| https://github.com/python-control/python-control/issues |
|
Pull requests
8
| https://github.com/python-control/python-control/pulls |
|
Discussions
| https://github.com/python-control/python-control/discussions |
|
Actions
| https://github.com/python-control/python-control/actions |
|
Projects
0
| https://github.com/python-control/python-control/projects |
|
Wiki
| https://github.com/python-control/python-control/wiki |
|
Security
0
| https://github.com/python-control/python-control/security |
|
Insights
| https://github.com/python-control/python-control/pulse |
|
Code
| https://github.com/python-control/python-control |
|
Issues
| https://github.com/python-control/python-control/issues |
|
Pull requests
| https://github.com/python-control/python-control/pulls |
|
Discussions
| https://github.com/python-control/python-control/discussions |
|
Actions
| https://github.com/python-control/python-control/actions |
|
Projects
| https://github.com/python-control/python-control/projects |
|
Wiki
| https://github.com/python-control/python-control/wiki |
|
Security
| https://github.com/python-control/python-control/security |
|
Insights
| https://github.com/python-control/python-control/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python-control/python-control/pull/1146#issue-comment-box |
| murrayrm | https://github.com/murrayrm |
| python-control:main | https://github.com/python-control/python-control/tree/main |
| josiahdelange:jdelange/disk-margins | https://github.com/josiahdelange/python-control/tree/jdelange/disk-margins |
|
Disk margin calculations
| https://github.com/python-control/python-control/pull/1146#top |
| murrayrm | https://github.com/murrayrm |
| python-control:main | https://github.com/python-control/python-control/tree/main |
| josiahdelange:jdelange/disk-margins | https://github.com/josiahdelange/python-control/tree/jdelange/disk-margins |
|
Conversation
39
| https://github.com/python-control/python-control/pull/1146 |
|
Commits
40
| https://github.com/python-control/python-control/pull/1146/commits |
|
Checks
14
| https://github.com/python-control/python-control/pull/1146/checks |
|
Files changed
| https://github.com/python-control/python-control/pull/1146/files |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| https://github.co/hiddenchars |
| https://github.com/python-control/python-control/pull/{{ revealButtonHref }} |
|
| https://github.com/josiahdelange |
| josiahdelange | https://github.com/josiahdelange |
| Apr 24, 2025 | https://github.com/python-control/python-control/pull/1146#issue-3017041886 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| #726 | https://github.com/python-control/python-control/issues/726 |
| published paper | https://arxiv.org/pdf/2003.04771 |
| example | https://www.mathworks.com/help/robust/ug/mimo-stability-margins-for-spinning-satellite.html |
| stability_margins | https://python-control.readthedocs.io/en/latest/generated/control.stability_margins.html |
| https://private-user-images.githubusercontent.com/7785578/436995069-0bed7d01-2343-494c-bc77-dc19038e3191.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njk2MjQ3MDYsIm5iZiI6MTc2OTYyNDQwNiwicGF0aCI6Ii83Nzg1NTc4LzQzNjk5NTA2OS0wYmVkN2QwMS0yMzQzLTQ5NGMtYmM3Ny1kYzE5MDM4ZTMxOTEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDEyOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjAxMjhUMTgyMDA2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZGI5MzFkZjMxZWVmZWU1YTk2YWExOTJjMGU1ZWM4OWZhMGI2YmNlNzc2OWRlMzMzMWJiYTM1OGZjNDIyMzkyNSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.P1gOvBMo94oBUp4lDwZMobTu8QjzivIAf3RrsR_aGSI |
| https://private-user-images.githubusercontent.com/7785578/436995179-906589ad-e4e2-4397-88db-483d0b549e25.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njk2MjQ3MDYsIm5iZiI6MTc2OTYyNDQwNiwicGF0aCI6Ii83Nzg1NTc4LzQzNjk5NTE3OS05MDY1ODlhZC1lNGUyLTQzOTctODhkYi00ODNkMGI1NDllMjUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDEyOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjAxMjhUMTgyMDA2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YzEzMzg2NjBmZmE4M2QxN2Y5YjRjYWQxMjNhNjE2MDA3MTcyMzQ0YTRlY2U2OWUyZTkxZDU5OTc5ZTczNTE2OSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.TT8vrsGRY389nmTMxhOCcx1kAJ3vgxjpLfBveSb9OMg |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| josiahdelange | https://github.com/josiahdelange |
| January 11, 2025 01:12 | https://github.com/python-control/python-control/pull/1146#commits-pushed-f6dada2 |
|
| https://github.com/josiahdelange |
| Initial version of disk margin calculation and example/test script | https://github.com/python-control/python-control/pull/1146/commits/f6dada2b7fb5a683169abb05faddd23d818a1389 |
| f6dada2 | https://github.com/python-control/python-control/pull/1146/commits/f6dada2b7fb5a683169abb05faddd23d818a1389 |
|
| https://github.com/josiahdelange |
| Merge remote-tracking branch 'origin' into jdelange/disk-margins | https://github.com/python-control/python-control/pull/1146/commits/bdb82a5861a3bef31a09baeb67096483c4961575 |
| bdb82a5 | https://github.com/python-control/python-control/pull/1146/commits/bdb82a5861a3bef31a09baeb67096483c4961575 |
|
| https://github.com/josiahdelange |
| Comment updates: update margins.py header, clarify import exception h… | https://github.com/python-control/python-control/pull/1146/commits/e46f824dd924b9b7ad2adfb283333341a18de819 |
| e46f824 | https://github.com/python-control/python-control/pull/1146/commits/e46f824dd924b9b7ad2adfb283333341a18de819 |
|
| https://github.com/josiahdelange |
| More work in progress on disk margin calculation, adding new prototyp… | https://github.com/python-control/python-control/pull/1146/commits/1e3af88cc9bfaf7ad3a27986b65ebf5458a6e644 |
| 1e3af88 | https://github.com/python-control/python-control/pull/1146/commits/1e3af88cc9bfaf7ad3a27986b65ebf5458a6e644 |
|
| https://github.com/josiahdelange |
| Add disk_margin_plot to subroutine list in comment header in margins.py | https://github.com/python-control/python-control/pull/1146/commits/ba157895fee83ecc15bd5c1bcd8f56f4e50778a5 |
| ba15789 | https://github.com/python-control/python-control/pull/1146/commits/ba157895fee83ecc15bd5c1bcd8f56f4e50778a5 |
|
| https://github.com/josiahdelange |
| Follow-on to | https://github.com/python-control/python-control/pull/1146/commits/e47ae02dad355468eafa1005fd580fc866b58725 |
| ba15789 | https://github.com/josiahdelange/python-control/commit/ba157895fee83ecc15bd5c1bcd8f56f4e50778a5 |
| , add disk_margin_plot to list of functions withi… | https://github.com/python-control/python-control/pull/1146/commits/e47ae02dad355468eafa1005fd580fc866b58725 |
| e47ae02 | https://github.com/python-control/python-control/pull/1146/commits/e47ae02dad355468eafa1005fd580fc866b58725 |
|
| https://github.com/josiahdelange |
| Merge branch 'python-control:main' into jdelange/disk-margins | https://github.com/python-control/python-control/pull/1146/commits/20686fe64193a4a6f71b17011fd84846d686260d |
| 20686fe | https://github.com/python-control/python-control/pull/1146/commits/20686fe64193a4a6f71b17011fd84846d686260d |
|
| https://github.com/josiahdelange |
| More work in progress on disk_margin_plot. Corrected a typo/bug in the | https://github.com/python-control/python-control/pull/1146/commits/f84221dcb1dbd5c978eef0f61be32d263b6fba37 |
| f84221d | https://github.com/python-control/python-control/pull/1146/commits/f84221dcb1dbd5c978eef0f61be32d263b6fba37 |
|
| https://github.com/josiahdelange |
| Merge branch 'jdelange/disk-margins' of github.com:josiahdelange/pyth… | https://github.com/python-control/python-control/pull/1146/commits/edf8040ce86b519bbff4fbbde230db06ad4237a8 |
| edf8040 | https://github.com/python-control/python-control/pull/1146/commits/edf8040ce86b519bbff4fbbde230db06ad4237a8 |
|
| https://github.com/josiahdelange |
| Merge remote-tracking branch 'origin/main' into jdelange/disk-margins | https://github.com/python-control/python-control/pull/1146/commits/9d554196eef327bd63f591395db5bedfaf36190d |
| 9d55419 | https://github.com/python-control/python-control/pull/1146/commits/9d554196eef327bd63f591395db5bedfaf36190d |
|
| https://github.com/josiahdelange |
| Further progress/debugging on disk margin calculation + plot utility | https://github.com/python-control/python-control/pull/1146/commits/2cf1545244b64f309fae6c3f56a65e4aae68bebb |
| 2cf1545 | https://github.com/python-control/python-control/pull/1146/commits/2cf1545244b64f309fae6c3f56a65e4aae68bebb |
|
| https://github.com/josiahdelange |
| Merge remote-tracking branch 'origin/main' into jdelange/disk-margins | https://github.com/python-control/python-control/pull/1146/commits/bbf37f0afd1e0ffcc462f6ddce89895a51063813 |
| bbf37f0 | https://github.com/python-control/python-control/pull/1146/commits/bbf37f0afd1e0ffcc462f6ddce89895a51063813 |
|
| https://github.com/josiahdelange |
| Clean up docstring/code for disk_margin_plot | https://github.com/python-control/python-control/pull/1146/commits/c3efe756180e6d863fb42c7b5a6fa09dbfe3a8c5 |
| c3efe75 | https://github.com/python-control/python-control/pull/1146/commits/c3efe756180e6d863fb42c7b5a6fa09dbfe3a8c5 |
|
| https://github.com/josiahdelange |
| Clean up docstring/code for disk_margin_plot | https://github.com/python-control/python-control/pull/1146/commits/63c8523303bb68745540a6e2c9f7344c44393ade |
| 63c8523 | https://github.com/python-control/python-control/pull/1146/commits/63c8523303bb68745540a6e2c9f7344c44393ade |
|
| https://github.com/josiahdelange |
| Remove debugging statements, update comments, add unit tests. | https://github.com/python-control/python-control/pull/1146/commits/cffc3e505bb8af9e8d634fe4a977018bd9716d9a |
| cffc3e5 | https://github.com/python-control/python-control/pull/1146/commits/cffc3e505bb8af9e8d634fe4a977018bd9716d9a |
|
| https://github.com/josiahdelange |
| Minor change to fix logic to find minimum across DGM, DPM numpy vectors | https://github.com/python-control/python-control/pull/1146/commits/91517f9c7eea26327abd1db9a1ab7afdd2b10e95 |
| 91517f9 | https://github.com/python-control/python-control/pull/1146/commits/91517f9c7eea26327abd1db9a1ab7afdd2b10e95 |
|
| https://github.com/josiahdelange |
| Rename disk margin example, since unit tests are now written in contr… | https://github.com/python-control/python-control/pull/1146/commits/86329e08024f357ee8b9c06ced5842b4a31c27a4 |
| 86329e0 | https://github.com/python-control/python-control/pull/1146/commits/86329e08024f357ee8b9c06ced5842b4a31c27a4 |
|
| https://github.com/josiahdelange |
| Remove unneeded dependencies from margins.py, used for debugging | https://github.com/python-control/python-control/pull/1146/commits/d92fb2045a786581741ddb703819f7ae5865a323 |
| d92fb20 | https://github.com/python-control/python-control/pull/1146/commits/d92fb2045a786581741ddb703819f7ae5865a323 |
|
| https://github.com/josiahdelange |
| Minor updates to docstrings | https://github.com/python-control/python-control/pull/1146/commits/b2a2edc620f26fed6e897f0269618899c3b2562b |
| b2a2edc | https://github.com/python-control/python-control/pull/1146/commits/b2a2edc620f26fed6e897f0269618899c3b2562b |
|
| https://github.com/josiahdelange |
| Undo | https://github.com/python-control/python-control/pull/1146/commits/1f0ee52af1c41a2d486ad91ac5e91211cde2a3aa |
| d92fb20 | https://github.com/josiahdelange/python-control/commit/d92fb2045a786581741ddb703819f7ae5865a323 |
| 1f0ee52 | https://github.com/python-control/python-control/pull/1146/commits/1f0ee52af1c41a2d486ad91ac5e91211cde2a3aa |
|
| https://github.com/josiahdelange |
| Minor tweaks to plots in example script for readability | https://github.com/python-control/python-control/pull/1146/commits/ba41e8c585b11309d0844b685b1676dbe760fd4c |
| ba41e8c | https://github.com/python-control/python-control/pull/1146/commits/ba41e8c585b11309d0844b685b1676dbe760fd4c |
|
| https://github.com/josiahdelange |
| Fix typo in disk_margin_plot. | https://github.com/python-control/python-control/pull/1146/commits/14eb315b69fb7e1257994a468c512879e367094e |
| 14eb315 | https://github.com/python-control/python-control/pull/1146/commits/14eb315b69fb7e1257994a468c512879e367094e |
| https://github.com/slivingston |
| slivingston | https://github.com/slivingston |
|
Apr 24, 2025
| https://github.com/python-control/python-control/pull/1146#pullrequestreview-2792485473 |
|
View reviewed changes
| https://github.com/python-control/python-control/pull/1146/files/14eb315b69fb7e1257994a468c512879e367094e |
| control/margins.py | https://github.com/python-control/python-control/pull/1146/files/14eb315b69fb7e1257994a468c512879e367094e#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| https://github.com/slivingston |
| slivingston | https://github.com/slivingston |
|
Apr 24, 2025
| https://github.com/python-control/python-control/pull/1146#pullrequestreview-2792496114 |
|
View reviewed changes
| https://github.com/python-control/python-control/pull/1146/files/14eb315b69fb7e1257994a468c512879e367094e |
| control/margins.py | https://github.com/python-control/python-control/pull/1146/files/14eb315b69fb7e1257994a468c512879e367094e#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| josiahdelange | https://github.com/josiahdelange |
| April 25, 2025 06:57 | https://github.com/python-control/python-control/pull/1146#commits-pushed-0bebc1d |
|
| https://github.com/josiahdelange |
| Fix mag2db import hack/workaround and trim down disk_margin docstring. | https://github.com/python-control/python-control/pull/1146/commits/0bebc1de9b2ebe28cd26d70ebcefd485bc057fea |
| 0bebc1d | https://github.com/python-control/python-control/pull/1146/commits/0bebc1de9b2ebe28cd26d70ebcefd485bc057fea |
|
| https://github.com/josiahdelange |
| Add input handling to disk_margin, clean up column width/comments | https://github.com/python-control/python-control/pull/1146/commits/87714bdaa3c7b23fa34990649242d602b51b0d0f |
| 87714bd | https://github.com/python-control/python-control/pull/1146/commits/87714bdaa3c7b23fa34990649242d602b51b0d0f |
|
| https://github.com/josiahdelange |
| Move disk_margin_plot out of the library into the example script | https://github.com/python-control/python-control/pull/1146/commits/c17910ff1e27b2db56661f70592c962680f538e1 |
| c17910f | https://github.com/python-control/python-control/pull/1146/commits/c17910ff1e27b2db56661f70592c962680f538e1 |
| https://github.com/josiahdelange |
| josiahdelange | https://github.com/josiahdelange |
| April 26, 2025 14:29 | https://github.com/python-control/python-control/pull/1146#event-17416662250 |
| josiahdelange | https://github.com/josiahdelange |
| April 26, 2025 10:32 | https://github.com/python-control/python-control/pull/1146#commits-pushed-5f34a7b |
|
| https://github.com/josiahdelange |
| Recommended changes from the linter | https://github.com/python-control/python-control/pull/1146/commits/5f34a7bea410715ee1389a36cd8de3e7001ebf34 |
| 5f34a7b | https://github.com/python-control/python-control/pull/1146/commits/5f34a7bea410715ee1389a36cd8de3e7001ebf34 |
|
| https://github.com/josiahdelange |
| Follow-on to | https://github.com/python-control/python-control/pull/1146/commits/f0e2d746a350f0a10c2a8883236f96a6bc6a373f |
| 5f34a7b | https://github.com/josiahdelange/python-control/commit/5f34a7bea410715ee1389a36cd8de3e7001ebf34 |
| f0e2d74 | https://github.com/python-control/python-control/pull/1146/commits/f0e2d746a350f0a10c2a8883236f96a6bc6a373f |
| josiahdelange | https://github.com/josiahdelange |
| April 26, 2025 11:09 | https://github.com/python-control/python-control/pull/1146#commits-pushed-a5fcb91 |
|
| https://github.com/josiahdelange |
| Add disk_margins to function list | https://github.com/python-control/python-control/pull/1146/commits/a5fcb91606c4f2e5223997f57d70a1aaff6dbd10 |
| a5fcb91 | https://github.com/python-control/python-control/pull/1146/commits/a5fcb91606c4f2e5223997f57d70a1aaff6dbd10 |
|
| https://github.com/josiahdelange |
| Whittle down the docstring from disk_margins | https://github.com/python-control/python-control/pull/1146/commits/077d538df502ee269b8e23fe172f392509c5c22c |
| 077d538 | https://github.com/python-control/python-control/pull/1146/commits/077d538df502ee269b8e23fe172f392509c5c22c |
|
| https://github.com/josiahdelange |
| Put more comments in the disk margin example, add example to document… | https://github.com/python-control/python-control/pull/1146/commits/8f0c037e0b72ac174764dd9a8feb94b251d9180c |
| 8f0c037 | https://github.com/python-control/python-control/pull/1146/commits/8f0c037e0b72ac174764dd9a8feb94b251d9180c |
|
| https://github.com/josiahdelange |
| Fixing docstrings | https://github.com/python-control/python-control/pull/1146/commits/ce80819300de7be5051f2ebed9d87b5793b2257d |
| ce80819 | https://github.com/python-control/python-control/pull/1146/commits/ce80819300de7be5051f2ebed9d87b5793b2257d |
| https://github.com/josiahdelange |
| josiahdelange | https://github.com/josiahdelange |
| Apr 26, 2025 | https://github.com/python-control/python-control/pull/1146#issuecomment-2832364031 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| https://github.com/josiahdelange |
| josiahdelange | https://github.com/josiahdelange |
| April 26, 2025 16:03 | https://github.com/python-control/python-control/pull/1146#event-17417292112 |
| josiahdelange | https://github.com/josiahdelange |
| April 26, 2025 14:49 | https://github.com/python-control/python-control/pull/1146#commits-pushed-397efab |
|
| https://github.com/josiahdelange |
| Corrected expected values for 'no-slycot' condition in newly-added un… | https://github.com/python-control/python-control/pull/1146/commits/397efabbe7ff9dcc11f2c4309ba73d63ed44d742 |
| 397efab | https://github.com/python-control/python-control/pull/1146/commits/397efabbe7ff9dcc11f2c4309ba73d63ed44d742 |
|
| https://github.com/josiahdelange |
| Attempt | https://github.com/python-control/python-control/pull/1146/commits/cc027126538301bd9b0fef625ad4f40303886d16 |
| python-control#2 | https://github.com/python-control/python-control/issues/2 |
| at | https://github.com/python-control/python-control/pull/1146/commits/cc027126538301bd9b0fef625ad4f40303886d16 |
| 397efab | https://github.com/josiahdelange/python-control/commit/397efabbe7ff9dcc11f2c4309ba73d63ed44d742 |
| , based on linter recommendation | https://github.com/python-control/python-control/pull/1146/commits/cc027126538301bd9b0fef625ad4f40303886d16 |
| cc02712 | https://github.com/python-control/python-control/pull/1146/commits/cc027126538301bd9b0fef625ad4f40303886d16 |
| https://github.com/coveralls |
| coveralls | https://github.com/coveralls |
| Apr 28, 2025 | https://github.com/python-control/python-control/pull/1146#issuecomment-2833821804 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| https://coveralls.io/builds/74332439 |
| bb06c9e | https://github.com/python-control/python-control/commit/bb06c9edc4670f94ad9551050d75cb3d47d2ec81 |
| 34c6d59 | https://github.com/python-control/python-control/commit/34c6d5922cf49b0be68849e116c610230e182eeb |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| https://github.com/murrayrm |
| murrayrm | https://github.com/murrayrm |
|
Apr 28, 2025
| https://github.com/python-control/python-control/pull/1146#pullrequestreview-2797848998 |
|
View reviewed changes
| https://github.com/python-control/python-control/pull/1146/files/cc027126538301bd9b0fef625ad4f40303886d16 |
| murrayrm | https://github.com/murrayrm |
| https://github.com/python-control/python-control/pull/1146#pullrequestreview-2797848998 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| control/tests/margin_test.py | https://github.com/python-control/python-control/pull/1146/files/cc027126538301bd9b0fef625ad4f40303886d16#diff-3c7b07fb37cfb63b385fb29c6c8086a3d55689d3249ff6c48434bee5764946bd |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| control/tests/margin_test.py | https://github.com/python-control/python-control/pull/1146/files/cc027126538301bd9b0fef625ad4f40303886d16#diff-3c7b07fb37cfb63b385fb29c6c8086a3d55689d3249ff6c48434bee5764946bd |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| control/margins.py | https://github.com/python-control/python-control/pull/1146/files/cc027126538301bd9b0fef625ad4f40303886d16#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| control/margins.py | https://github.com/python-control/python-control/pull/1146/files/cc027126538301bd9b0fef625ad4f40303886d16#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| control/margins.py | https://github.com/python-control/python-control/pull/1146/files/cc027126538301bd9b0fef625ad4f40303886d16#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| control/margins.py | https://github.com/python-control/python-control/pull/1146/files/cc027126538301bd9b0fef625ad4f40303886d16#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| control/margins.py | https://github.com/python-control/python-control/pull/1146/files/cc027126538301bd9b0fef625ad4f40303886d16#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| control/margins.py | https://github.com/python-control/python-control/pull/1146/files/cc027126538301bd9b0fef625ad4f40303886d16#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| control/margins.py | https://github.com/python-control/python-control/pull/1146/files/cc027126538301bd9b0fef625ad4f40303886d16#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| control/margins.py | https://github.com/python-control/python-control/pull/1146/files/cc027126538301bd9b0fef625ad4f40303886d16#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| josiahdelange | https://github.com/josiahdelange |
| April 28, 2025 20:04 | https://github.com/python-control/python-control/pull/1146#commits-pushed-e8897f6 |
|
| https://github.com/josiahdelange |
| Address | https://github.com/python-control/python-control/pull/1146/commits/e8897f6fb57d1c9f7b7409055383083cdb59ae68 |
| @murrayrm | https://github.com/murrayrm |
| review comments. | https://github.com/python-control/python-control/pull/1146/commits/e8897f6fb57d1c9f7b7409055383083cdb59ae68 |
| e8897f6 | https://github.com/python-control/python-control/pull/1146/commits/e8897f6fb57d1c9f7b7409055383083cdb59ae68 |
|
| https://github.com/josiahdelange |
| Update formatting per PEP8/ | https://github.com/python-control/python-control/pull/1146/commits/579f24b709cc07ec3349ac2c397db9c725bb47b4 |
| @murrayrm | https://github.com/murrayrm |
| review comments. Add additional … | https://github.com/python-control/python-control/pull/1146/commits/579f24b709cc07ec3349ac2c397db9c725bb47b4 |
| 579f24b | https://github.com/python-control/python-control/pull/1146/commits/579f24b709cc07ec3349ac2c397db9c725bb47b4 |
|
| https://github.com/josiahdelange |
| Follow-on to | https://github.com/python-control/python-control/pull/1146/commits/fe79760dcaafe6ada55dd40390e2b0e6a08b2b52 |
| e8897f6 | https://github.com/josiahdelange/python-control/commit/e8897f6fb57d1c9f7b7409055383083cdb59ae68 |
| : remove now-unnecessary import of importlib | https://github.com/python-control/python-control/pull/1146/commits/fe79760dcaafe6ada55dd40390e2b0e6a08b2b52 |
| fe79760 | https://github.com/python-control/python-control/pull/1146/commits/fe79760dcaafe6ada55dd40390e2b0e6a08b2b52 |
| https://github.com/josiahdelange |
| josiahdelange | https://github.com/josiahdelange |
| Apr 29, 2025 | https://github.com/python-control/python-control/pull/1146#issuecomment-2837159128 |
| @murrayrm | https://github.com/murrayrm |
| @slivingston | https://github.com/slivingston |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| https://github.com/murrayrm |
| murrayrm | https://github.com/murrayrm |
|
Jun 13, 2025
| https://github.com/python-control/python-control/pull/1146#pullrequestreview-2925810309 |
|
View reviewed changes
| https://github.com/python-control/python-control/pull/1146/files/fe79760dcaafe6ada55dd40390e2b0e6a08b2b52 |
| murrayrm | https://github.com/murrayrm |
| https://github.com/python-control/python-control/pull/1146#pullrequestreview-2925810309 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| control/margins.py | https://github.com/python-control/python-control/pull/1146/files/fe79760dcaafe6ada55dd40390e2b0e6a08b2b52#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| control/margins.py | https://github.com/python-control/python-control/pull/1146/files/fe79760dcaafe6ada55dd40390e2b0e6a08b2b52#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| control/margins.py | https://github.com/python-control/python-control/pull/1146/files/fe79760dcaafe6ada55dd40390e2b0e6a08b2b52#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| doc/functions.rst | https://github.com/python-control/python-control/pull/1146/files/fe79760dcaafe6ada55dd40390e2b0e6a08b2b52#diff-b6df90171a7b358fdf3cb7ec04a4c0731911997c09db1651ddcd4de2948528fb |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| examples/disk_margins.py | https://github.com/python-control/python-control/pull/1146/files/fe79760dcaafe6ada55dd40390e2b0e6a08b2b52#diff-bae60ad38d5f00e05f039c9bdd4a21fa2f3828574983e8dd93119a601ba3b81e |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| control/margins.py | https://github.com/python-control/python-control/pull/1146/files/fe79760dcaafe6ada55dd40390e2b0e6a08b2b52#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| control/margins.py | https://github.com/python-control/python-control/pull/1146/files/fe79760dcaafe6ada55dd40390e2b0e6a08b2b52#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| control/margins.py | https://github.com/python-control/python-control/pull/1146/files/fe79760dcaafe6ada55dd40390e2b0e6a08b2b52#diff-f6d94f1ff38967f73b006c0d051f68e0a86db247c36c226c6035f9615ad80088 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| josiahdelange | https://github.com/josiahdelange |
| June 21, 2025 20:00 | https://github.com/python-control/python-control/pull/1146#commits-pushed-b85147e |
|
| https://github.com/josiahdelange |
| Update formatting per | https://github.com/python-control/python-control/pull/1146/commits/b85147e7020c6a1e6bad9713cff5fed68e6c1de0 |
| @murrayrm | https://github.com/murrayrm |
| review comments | https://github.com/python-control/python-control/pull/1146/commits/b85147e7020c6a1e6bad9713cff5fed68e6c1de0 |
| b85147e | https://github.com/python-control/python-control/pull/1146/commits/b85147e7020c6a1e6bad9713cff5fed68e6c1de0 |
|
| https://github.com/josiahdelange |
| Merge branch 'python-control:main' into jdelange/disk-margins | https://github.com/python-control/python-control/pull/1146/commits/7186406b5b62f754750817a060249e48c280d533 |
| 7186406 | https://github.com/python-control/python-control/pull/1146/commits/7186406b5b62f754750817a060249e48c280d533 |
|
| https://github.com/josiahdelange |
| Remove temporarily-added string from docstring | https://github.com/python-control/python-control/pull/1146/commits/eb3af29c6cb17e399e50e46ab275e6f5b3bba74c |
| eb3af29 | https://github.com/python-control/python-control/pull/1146/commits/eb3af29c6cb17e399e50e46ab275e6f5b3bba74c |
|
| https://github.com/josiahdelange |
| Minor tweak to docstring to fit the word 'function' back into the des… | https://github.com/python-control/python-control/pull/1146/commits/bb06c9edc4670f94ad9551050d75cb3d47d2ec81 |
| bb06c9e | https://github.com/python-control/python-control/pull/1146/commits/bb06c9edc4670f94ad9551050d75cb3d47d2ec81 |
| https://github.com/josiahdelange |
| josiahdelange | https://github.com/josiahdelange |
| Jun 25, 2025 | https://github.com/python-control/python-control/pull/1146#issuecomment-3004854263 |
| @murrayrm | https://github.com/murrayrm |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| https://github.com/murrayrm |
| murrayrm | https://github.com/murrayrm |
| Jun 25, 2025 | https://github.com/python-control/python-control/pull/1146#issuecomment-3004870428 |
| #1161 | https://github.com/python-control/python-control/issues/1161 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| https://github.com/murrayrm |
| murrayrm | https://github.com/murrayrm |
| aa92b65 | https://github.com/python-control/python-control/commit/aa92b653d4f0ef17bf5e5e065bac562a8c8bd5ba |
| Jun 25, 2025 | https://github.com/python-control/python-control/pull/1146#event-18317367680 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
| https://github.com/murrayrm |
| murrayrm | https://github.com/murrayrm |
| 0.10.2 | https://github.com/python-control/python-control/milestone/16 |
| Jul 4, 2025 | https://github.com/python-control/python-control/pull/1146#event-18474975992 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F1146 |
|
| https://github.com/murrayrm |
|
murrayrm
| https://github.com/murrayrm |
|
| https://github.com/python-control/python-control/pull/1146/files/fe79760dcaafe6ada55dd40390e2b0e6a08b2b52 |
|
| https://github.com/slivingston |
|
slivingston
| https://github.com/slivingston |
|
| https://github.com/python-control/python-control/pull/1146/files/14eb315b69fb7e1257994a468c512879e367094e |
|
0.10.2
| https://github.com/python-control/python-control/milestone/16 |
| Please reload this page | https://github.com/python-control/python-control/pull/1146 |
|
| https://github.com/josiahdelange |
|
| https://github.com/coveralls |
|
| https://github.com/murrayrm |
|
| https://github.com/slivingston |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |