Title: fix ax processing bug in {nyquist,nichols,describing_function}_plot by murrayrm · Pull Request #1145 · python-control/python-control · GitHub
Open Graph Title: fix ax processing bug in {nyquist,nichols,describing_function}_plot by murrayrm · Pull Request #1145 · python-control/python-control
X Title: fix ax processing bug in {nyquist,nichols,describing_function}_plot by murrayrm · Pull Request #1145 · python-control/python-control
Description: This PR fixes #1144 (also pointed out in #1143) where the ax keyword was being ignored in the nyquist_plot command. Turns out that there were several related bugs: The Nichols grid was not being plotted in the proper location when ax was passed to nichols_plot. The describing function curve was not being plotted in the proper location when ax was passed to describing_funciton_plot. This PR fixes those bugs as well, and includes an updated unit test that picks up all three previous errors.
Open Graph Description: This PR fixes #1144 (also pointed out in #1143) where the ax keyword was being ignored in the nyquist_plot command. Turns out that there were several related bugs: The Nichols grid was not being p...
X Description: This PR fixes #1144 (also pointed out in #1143) where the ax keyword was being ignored in the nyquist_plot command. Turns out that there were several related bugs: The Nichols grid was not being p...
Opengraph URL: https://github.com/python-control/python-control/pull/1145
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:7ee0891f-72e6-d40f-4307-35c05d2e7bf3 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 9746:14F257:73B01F:9C650A:697AFFBE |
| html-safe-nonce | 81b5217090629901d965efa2658039326fb528b28b91f15a6e43a80448cf9791 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzQ2OjE0RjI1Nzo3M0IwMUY6OUM2NTBBOjY5N0FGRkJFIiwidmlzaXRvcl9pZCI6Ijc3OTI1NDM0MzY5MjY0ODM4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d65104f783b1ca9fc442abe5733c31c59c757ebebebe538b4e6299dd44dd99dd |
| hovercard-subject-tag | pull_request:2465010592 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/1145/checks |
| twitter:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| og:image:alt | This PR fixes #1144 (also pointed out in #1143) where the ax keyword was being ignored in the nyquist_plot command. Turns out that there were several related bugs: The Nichols grid was not being p... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7ce8ed0a54c4730aeca4e6abacfc6490365fc42e25480b86883054df3f9181c8 |
| turbo-cache-control | no-cache |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d7bfc78137af9a4828305e52ab993fce981d7085 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width