René's URL Explorer Experiment


Title: fix ax processing bug in {nyquist,nichols,describing_function}_plot by murrayrm · Pull Request #1145 · python-control/python-control · GitHub

Open Graph Title: fix ax processing bug in {nyquist,nichols,describing_function}_plot by murrayrm · Pull Request #1145 · python-control/python-control

X Title: fix ax processing bug in {nyquist,nichols,describing_function}_plot by murrayrm · Pull Request #1145 · python-control/python-control

Description: This PR fixes #1144 (also pointed out in #1143) where the ax keyword was being ignored in the nyquist_plot command. Turns out that there were several related bugs: The Nichols grid was not being plotted in the proper location when ax was passed to nichols_plot. The describing function curve was not being plotted in the proper location when ax was passed to describing_funciton_plot. This PR fixes those bugs as well, and includes an updated unit test that picks up all three previous errors.

Open Graph Description: This PR fixes #1144 (also pointed out in #1143) where the ax keyword was being ignored in the nyquist_plot command. Turns out that there were several related bugs: The Nichols grid was not being p...

X Description: This PR fixes #1144 (also pointed out in #1143) where the ax keyword was being ignored in the nyquist_plot command. Turns out that there were several related bugs: The Nichols grid was not being p...

Opengraph URL: https://github.com/python-control/python-control/pull/1145

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:aae6ba59-7203-9992-e143-8d763f785c09
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB118:28D67:3FF669:575CA1:697BC025
html-safe-nonce6b2290f4cd21ebb54644f36f13a7dc788ba2d437984d608b9832afdd50c5cc5b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTE4OjI4RDY3OjNGRjY2OTo1NzVDQTE6Njk3QkMwMjUiLCJ2aXNpdG9yX2lkIjoiNjc0NTIwNDAzMjI3ODM0NzgxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3dbf5023ea076404ca634e8e9e3725f34d2ac2503273c69df8d03c2a46ce456f
hovercard-subject-tagpull_request:2465010592
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/1145/files
twitter:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
og:image:altThis PR fixes #1144 (also pointed out in #1143) where the ax keyword was being ignored in the nyquist_plot command. Turns out that there were several related bugs: The Nichols grid was not being p...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneab413746e1b95376981dfec4a04b2384a611b96affe802ee3ee6d752200afbb1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebea0e0f1995ab0bb7fa336572c353032cf897ec1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/1145/changes#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F1145%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F1145%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/1145/changes
Reloadhttps://github.com/python-control/python-control/pull/1145/changes
Reloadhttps://github.com/python-control/python-control/pull/1145/changes
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
slivingstonhttps://github.com/slivingston
python-control:mainhttps://github.com/python-control/python-control/tree/main
murrayrm:fix_nyquist_ax-16Apr2025https://github.com/murrayrm/python-control/tree/fix_nyquist_ax-16Apr2025
Conversation 1 https://github.com/python-control/python-control/pull/1145
Commits 2 https://github.com/python-control/python-control/pull/1145/commits
Checks 14 https://github.com/python-control/python-control/pull/1145/checks
Files changed https://github.com/python-control/python-control/pull/1145/files
Please reload this pagehttps://github.com/python-control/python-control/pull/1145/changes
fix ax processing bug in {nyquist,nichols,describing_function}_plot https://github.com/python-control/python-control/pull/1145/changes#top
Show all changes 2 commits https://github.com/python-control/python-control/pull/1145/files
2764889 fix ax processing bug in {nyquist,nichols,describing_function}_plot murrayrm Apr 17, 2025 https://github.com/python-control/python-control/pull/1145/commits/2764889ba270d6340a6cef38e1e6df1fa9ede7d7
21f4912 fix ruff error in descfcn.py (matplotlib no longer needed) murrayrm Apr 17, 2025 https://github.com/python-control/python-control/pull/1145/commits/21f4912c8b12216534b8d5b07c243c66675a8b83
Clear filters https://github.com/python-control/python-control/pull/1145/files
Please reload this pagehttps://github.com/python-control/python-control/pull/1145/changes
Please reload this pagehttps://github.com/python-control/python-control/pull/1145/changes
ctrlplot.py https://github.com/python-control/python-control/pull/1145/changes#diff-634119b78de5d79475df039710a7b5e4a011957bc2b311821a51479b1d9bcb64
descfcn.py https://github.com/python-control/python-control/pull/1145/changes#diff-f0f5ffb2c67d9936a4896284a27a0b10ccc28b354bfbc7cc187460f1254a073d
freqplot.py https://github.com/python-control/python-control/pull/1145/changes#diff-a751fe1009e7b656d19357a39abb58dd88b89052c9d9259c3393a4648b697a16
nichols.py https://github.com/python-control/python-control/pull/1145/changes#diff-b581de8c6f5f8f72c517e49ebb7ec697d93fc31e16b6e9f9d36a10ec2aecd510
ctrlplot_test.py https://github.com/python-control/python-control/pull/1145/changes#diff-6baab066453bbefce9590e31752d0f906492105ac8120232db3689e206cc2d46
control/ctrlplot.pyhttps://github.com/python-control/python-control/pull/1145/changes#diff-634119b78de5d79475df039710a7b5e4a011957bc2b311821a51479b1d9bcb64
View file https://github.com/murrayrm/python-control/blob/21f4912c8b12216534b8d5b07c243c66675a8b83/control/ctrlplot.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/1145/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/1145/changes#diff-634119b78de5d79475df039710a7b5e4a011957bc2b311821a51479b1d9bcb64
https://github.com/python-control/python-control/pull/1145/changes#diff-634119b78de5d79475df039710a7b5e4a011957bc2b311821a51479b1d9bcb64
control/descfcn.pyhttps://github.com/python-control/python-control/pull/1145/changes#diff-f0f5ffb2c67d9936a4896284a27a0b10ccc28b354bfbc7cc187460f1254a073d
View file https://github.com/murrayrm/python-control/blob/21f4912c8b12216534b8d5b07c243c66675a8b83/control/descfcn.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/1145/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/1145/changes#diff-f0f5ffb2c67d9936a4896284a27a0b10ccc28b354bfbc7cc187460f1254a073d
https://github.com/python-control/python-control/pull/1145/changes#diff-f0f5ffb2c67d9936a4896284a27a0b10ccc28b354bfbc7cc187460f1254a073d
https://github.com/python-control/python-control/pull/1145/changes#diff-f0f5ffb2c67d9936a4896284a27a0b10ccc28b354bfbc7cc187460f1254a073d
https://github.com/python-control/python-control/pull/1145/changes#diff-f0f5ffb2c67d9936a4896284a27a0b10ccc28b354bfbc7cc187460f1254a073d
control/freqplot.pyhttps://github.com/python-control/python-control/pull/1145/changes#diff-a751fe1009e7b656d19357a39abb58dd88b89052c9d9259c3393a4648b697a16
View file https://github.com/murrayrm/python-control/blob/21f4912c8b12216534b8d5b07c243c66675a8b83/control/freqplot.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/1145/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/1145/changes#diff-a751fe1009e7b656d19357a39abb58dd88b89052c9d9259c3393a4648b697a16
https://github.com/python-control/python-control/pull/1145/changes#diff-a751fe1009e7b656d19357a39abb58dd88b89052c9d9259c3393a4648b697a16
https://github.com/python-control/python-control/pull/1145/changes#diff-a751fe1009e7b656d19357a39abb58dd88b89052c9d9259c3393a4648b697a16
https://github.com/python-control/python-control/pull/1145/changes#diff-a751fe1009e7b656d19357a39abb58dd88b89052c9d9259c3393a4648b697a16
https://github.com/python-control/python-control/pull/1145/changes#diff-a751fe1009e7b656d19357a39abb58dd88b89052c9d9259c3393a4648b697a16
https://github.com/python-control/python-control/pull/1145/changes#diff-a751fe1009e7b656d19357a39abb58dd88b89052c9d9259c3393a4648b697a16
https://github.com/python-control/python-control/pull/1145/changes#diff-a751fe1009e7b656d19357a39abb58dd88b89052c9d9259c3393a4648b697a16
https://github.com/python-control/python-control/pull/1145/changes#diff-a751fe1009e7b656d19357a39abb58dd88b89052c9d9259c3393a4648b697a16
control/nichols.pyhttps://github.com/python-control/python-control/pull/1145/changes#diff-b581de8c6f5f8f72c517e49ebb7ec697d93fc31e16b6e9f9d36a10ec2aecd510
View file https://github.com/murrayrm/python-control/blob/21f4912c8b12216534b8d5b07c243c66675a8b83/control/nichols.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/1145/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/1145/changes#diff-b581de8c6f5f8f72c517e49ebb7ec697d93fc31e16b6e9f9d36a10ec2aecd510
https://github.com/python-control/python-control/pull/1145/changes#diff-b581de8c6f5f8f72c517e49ebb7ec697d93fc31e16b6e9f9d36a10ec2aecd510
control/tests/ctrlplot_test.pyhttps://github.com/python-control/python-control/pull/1145/changes#diff-6baab066453bbefce9590e31752d0f906492105ac8120232db3689e206cc2d46
View file https://github.com/murrayrm/python-control/blob/21f4912c8b12216534b8d5b07c243c66675a8b83/control/tests/ctrlplot_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/1145/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/1145/changes#diff-6baab066453bbefce9590e31752d0f906492105ac8120232db3689e206cc2d46
https://github.com/python-control/python-control/pull/1145/changes#diff-6baab066453bbefce9590e31752d0f906492105ac8120232db3689e206cc2d46
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.