Title: Lint library code only with `ruff check` by roryyorke · Pull Request #1118 · python-control/python-control · GitHub
Open Graph Title: Lint library code only with `ruff check` by roryyorke · Pull Request #1118 · python-control/python-control
X Title: Lint library code only with `ruff check` by roryyorke · Pull Request #1118 · python-control/python-control
Description: Make library code ruff check clean for pyflakes ("F" code) warnings, and checks this in a Github Action. "Library code" is all non-test code in control/, so excludes tests, examples, and benchmarks. Making all of those ruff-check-clean too will take some time, and be a big change, so it seems worth getting this in first. This also gives an opportunity for reviewing the ruff configuration, and the overall approach, e.g., disabling import checks in __init__.py. Besides making the other parts of the code pass lint, ruff can do more, and we can look at adding more checks later. Partially addresses gh-1101. You can see an example of a failing Github Action ruff check here.
Open Graph Description: Make library code ruff check clean for pyflakes ("F" code) warnings, and checks this in a Github Action. "Library code" is all non-test code in control/, so excludes tests, exam...
X Description: Make library code ruff check clean for pyflakes ("F" code) warnings, and checks this in a Github Action. "Library code" is all non-test code in control/, so excl...
Opengraph URL: https://github.com/python-control/python-control/pull/1118
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:0a00d080-d832-06d2-6cf5-5eb527433b1f |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | D3B4:345E2B:163AEC5:1E4BD7C:697A9626 |
| html-safe-nonce | e408a6d7c11a333e6b69bf66c96ed8adf76f7567ea8d082b2ded295ffc5fa8ff |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEM0I0OjM0NUUyQjoxNjNBRUM1OjFFNEJEN0M6Njk3QTk2MjYiLCJ2aXNpdG9yX2lkIjoiMzc5NTY3ODkxMjk3NzczNzI1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 55aad7fd68e7416c280408eaad4122fa535634b2442139c8cb052640cc19bce5 |
| hovercard-subject-tag | pull_request:2311159745 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/1118/checks |
| twitter:image | https://avatars.githubusercontent.com/u/110974?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/110974?s=400&v=4 |
| og:image:alt | Make library code ruff check clean for pyflakes ("F" code) warnings, and checks this in a Github Action. "Library code" is all non-test code in control/, so excludes tests, exam... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0912f2a9aa0160e08239520d461a4b4c4ce1caa972a8370b7442b94a38a194c5 |
| turbo-cache-control | no-cache |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f8f5270c10a913bfa56f2dad4b864f1cda383754 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width