Title: update use/computation of sys._isstatic() by murrayrm · Pull Request #1117 · python-control/python-control · GitHub
Open Graph Title: update use/computation of sys._isstatic() by murrayrm · Pull Request #1117 · python-control/python-control
X Title: update use/computation of sys._isstatic() by murrayrm · Pull Request #1117 · python-control/python-control
Description: This small PR addresses #1090, where there was a redundant calculation for whether a transfer function is static (constant) or not. This fixes that by saving the computation done in init and using it later if sys._isstatic() is called. I also found a spot in nlsys where there was a (simple) redundant computation, so converted that to a call to sys._isstatic(). Following the discussion below, the current PR does the following: Moves the _isstatic() method from InputOutputSystem to NonlinearIOSystem and TransferFunction. This is because the way in which the checks are done is different for systems with a state versus transfer functions. For NonlinearIOSystem (including StateSpace, which is a subclass), a system sys is static if sys.nstates is zero, so this is what _isstatic() checks. For TransferFunction, a system sys is static if the numerator and denominator polynomials are all zero order. This is computed when the system is constructed and store in the private instance variable _static. For FrequencyResponseData, the _isstatic() method is not defined (mainly because it isn't used anywhere). Updated the User Guide documentation for nonlinear systems to reflect the updated usage of "static" (= no internal state, but time-varying is allowed). Updated the documentation and docstrings for describing functions to reflect that fact that non-static functions are allowed (eg, backlash and hysteresis). The main uses of the static property for a system are described in more detail in the comments below.
Open Graph Description: This small PR addresses #1090, where there was a redundant calculation for whether a transfer function is static (constant) or not. This fixes that by saving the computation done in init and using...
X Description: This small PR addresses #1090, where there was a redundant calculation for whether a transfer function is static (constant) or not. This fixes that by saving the computation done in init and using...
Opengraph URL: https://github.com/python-control/python-control/pull/1117
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c8c70caf-8c69-5b78-f12e-b9516babc847 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DCB0:3DF548:BEDB6F:107675B:697A7579 |
| html-safe-nonce | cd4f809dee19b90208fe9afe98918c4e96e82c1cca9cd4b0210057174d711090 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0IwOjNERjU0ODpCRURCNkY6MTA3Njc1Qjo2OTdBNzU3OSIsInZpc2l0b3JfaWQiOiI4NDY4MDIzMzczMDAxODE1NDE3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0d8ece6196eeb77c1f79626f076392016671d0b13e980c93ceb61cf4fee6573d |
| hovercard-subject-tag | pull_request:2311115495 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/1117/files |
| twitter:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| og:image:alt | This small PR addresses #1090, where there was a redundant calculation for whether a transfer function is static (constant) or not. This fixes that by saving the computation done in init and using... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 90af392c4422c0519eb9d3bf73d4a19bcd295cce41ce316abc60c8399f996938 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4c08209263bbbf322ab1921dc4539a6bfc158b1f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width