René's URL Explorer Experiment


Title: Update _ssmatrix and _check_shape for consistent usage by murrayrm · Pull Request #1116 · python-control/python-control · GitHub

Open Graph Title: Update _ssmatrix and _check_shape for consistent usage by murrayrm · Pull Request #1116 · python-control/python-control

X Title: Update _ssmatrix and _check_shape for consistent usage by murrayrm · Pull Request #1116 · python-control/python-control

Description: Prompted by issue #1100, this PR updates the _ssmatrix and _check_shape functions to make their usage more consistent and remove legacy calls that are no longer needed. Changes: Updated _ssmatrix to allow checking for square matrices and row/col dimensions, with improved error messages that include the name of the matrix generating the error. Functions that accept state-space matrices now call _ssmatrix for uniform processing. Removed unneeded calls to _ssmatrix on outputs of functions in mateqn.py and other places. These calls were used back when we supported the NumPy matrix class and are no longer required. Fixed acker to use the matrices generated by _ssmatrix. Updated _check_shape to have a call signature that is more conistent with _ssmatrix: the matrix and dimensions are first, followed by optional keywords, with a name keyword for the name of the matrix being checked (for error messages). Removed internal _check_shape in statefbk.py and replaced with a call to mateqn._check_shape. Updated unit tests to reflect the new wording of some error messages.

Open Graph Description: Prompted by issue #1100, this PR updates the _ssmatrix and _check_shape functions to make their usage more consistent and remove legacy calls that are no longer needed. Changes: Updated _ssmatrix ...

X Description: Prompted by issue #1100, this PR updates the _ssmatrix and _check_shape functions to make their usage more consistent and remove legacy calls that are no longer needed. Changes: Updated _ssmatrix ...

Opengraph URL: https://github.com/python-control/python-control/pull/1116

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1af94642-9d36-796a-ff83-c58494790745
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA38E:EE14C:2BBBE39:3BB481B:6979BBE8
html-safe-nonce00ecdb27ffd6cf143a7a9894047843e9d9146c376842fa629a60511180785634
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzhFOkVFMTRDOjJCQkJFMzk6M0JCNDgxQjo2OTc5QkJFOCIsInZpc2l0b3JfaWQiOiI3MDAyODM5ODQwMjU3MDYzOTEyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaceb2255acdee941733f29222c51aec1a91d0e80431b7072a976676f64bcfe818c
hovercard-subject-tagpull_request:2311104720
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/1116/files
twitter:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
og:image:altPrompted by issue #1100, this PR updates the _ssmatrix and _check_shape functions to make their usage more consistent and remove legacy calls that are no longer needed. Changes: Updated _ssmatrix ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec049b65ec7e54cbf2521f5a560b6527714c612b0bd169188e2ea6e16f83bd5f4
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release87b137883e35e2766c3d0f6a257c4044f6390b83
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/1116/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F1116%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F1116%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/1116/files
Reloadhttps://github.com/python-control/python-control/pull/1116/files
Reloadhttps://github.com/python-control/python-control/pull/1116/files
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
murrayrmhttps://github.com/murrayrm
python-control:mainhttps://github.com/python-control/python-control/tree/main
murrayrm:update_ssmatrix-01Feb2025https://github.com/murrayrm/python-control/tree/update_ssmatrix-01Feb2025
Conversation 3 https://github.com/python-control/python-control/pull/1116
Commits 1 https://github.com/python-control/python-control/pull/1116/commits
Checks 13 https://github.com/python-control/python-control/pull/1116/checks
Files changed https://github.com/python-control/python-control/pull/1116/files
Please reload this pagehttps://github.com/python-control/python-control/pull/1116/files
Update _ssmatrix and _check_shape for consistent usage https://github.com/python-control/python-control/pull/1116/files#top
Show all changes 1 commit https://github.com/python-control/python-control/pull/1116/files
4fc70f7 update _ssmatrix and _check_shape for consistent usage murrayrm Feb 2, 2025 https://github.com/python-control/python-control/pull/1116/commits/4fc70f7b021de9d7f0d2e1c17ea2ca84cce057c0
Clear filters https://github.com/python-control/python-control/pull/1116/files
Please reload this pagehttps://github.com/python-control/python-control/pull/1116/files
Please reload this pagehttps://github.com/python-control/python-control/pull/1116/files
mateqn.py https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
statefbk.py https://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
statesp.py https://github.com/python-control/python-control/pull/1116/files#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
stochsys.py https://github.com/python-control/python-control/pull/1116/files#diff-b32ff2216399700e0cc009ce41fe4aec6c0d8156841b29af325025d1fc13254d
docstrings_test.py https://github.com/python-control/python-control/pull/1116/files#diff-f098dc1536e0667ba32b96b805f95b4ee82c1c1c81e0547799106131b713028f
statefbk_test.py https://github.com/python-control/python-control/pull/1116/files#diff-90f212319faaca2098d93d660936eab8762ef555c04db53a4b76e6ece773fc1d
statesp_test.py https://github.com/python-control/python-control/pull/1116/files#diff-4c76080acbdea36493458693d93ec10e4e10b2e04ce01c56e8a81567cc1ea0d6
control/mateqn.pyhttps://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
View file https://github.com/murrayrm/python-control/blob/4fc70f7b021de9d7f0d2e1c17ea2ca84cce057c0/control/mateqn.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/1116/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
https://github.com/python-control/python-control/pull/1116/files#diff-063352893924b087df21a9816e0ee3e35db0bf1ad96e263c6c8f4fa5981995aa
control/statefbk.pyhttps://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
View file https://github.com/murrayrm/python-control/blob/4fc70f7b021de9d7f0d2e1c17ea2ca84cce057c0/control/statefbk.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/1116/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
https://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
https://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
https://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
https://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
https://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
https://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
https://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
https://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
https://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
https://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
https://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
https://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
https://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
https://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
https://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
https://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
https://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
https://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
https://github.com/python-control/python-control/pull/1116/files#diff-dbb4a524ae36f7833fa7b5991007098ea0b11b1f8a5d30831c641f5e6d39e0cb
Please reload this pagehttps://github.com/python-control/python-control/pull/1116/files
Please reload this pagehttps://github.com/python-control/python-control/pull/1116/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.