René's URL Explorer Experiment


Title: Update _ssmatrix and _check_shape for consistent usage by murrayrm · Pull Request #1116 · python-control/python-control · GitHub

Open Graph Title: Update _ssmatrix and _check_shape for consistent usage by murrayrm · Pull Request #1116 · python-control/python-control

X Title: Update _ssmatrix and _check_shape for consistent usage by murrayrm · Pull Request #1116 · python-control/python-control

Description: Prompted by issue #1100, this PR updates the _ssmatrix and _check_shape functions to make their usage more consistent and remove legacy calls that are no longer needed. Changes: Updated _ssmatrix to allow checking for square matrices and row/col dimensions, with improved error messages that include the name of the matrix generating the error. Functions that accept state-space matrices now call _ssmatrix for uniform processing. Removed unneeded calls to _ssmatrix on outputs of functions in mateqn.py and other places. These calls were used back when we supported the NumPy matrix class and are no longer required. Fixed acker to use the matrices generated by _ssmatrix. Updated _check_shape to have a call signature that is more conistent with _ssmatrix: the matrix and dimensions are first, followed by optional keywords, with a name keyword for the name of the matrix being checked (for error messages). Removed internal _check_shape in statefbk.py and replaced with a call to mateqn._check_shape. Updated unit tests to reflect the new wording of some error messages.

Open Graph Description: Prompted by issue #1100, this PR updates the _ssmatrix and _check_shape functions to make their usage more consistent and remove legacy calls that are no longer needed. Changes: Updated _ssmatrix ...

X Description: Prompted by issue #1100, this PR updates the _ssmatrix and _check_shape functions to make their usage more consistent and remove legacy calls that are no longer needed. Changes: Updated _ssmatrix ...

Opengraph URL: https://github.com/python-control/python-control/pull/1116

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:49b5ad3e-dfbe-6367-5f37-6172c8f8928c
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-id9F32:2E14C0:D11DE7:1276DAE:6979FE89
html-safe-noncec6558de86b7078a1eb58772ebc66d68ad43ec5c803c7d44726000d2a8a58830a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjMyOjJFMTRDMDpEMTFERTc6MTI3NkRBRTo2OTc5RkU4OSIsInZpc2l0b3JfaWQiOiIzNzc0NTA2NjE4Mjg4OTk1OTc3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1982c8d25f1a4cda29bea732dce020f7f87c3332647faf2941028a272225e8d9
hovercard-subject-tagpull_request:2311104720
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/1116/checks
twitter:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
og:image:altPrompted by issue #1100, this PR updates the _ssmatrix and _check_shape functions to make their usage more consistent and remove legacy calls that are no longer needed. Changes: Updated _ssmatrix ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None6cfe1afbf5a34a44e1b6fd6038587da09ec2a9c26ef005774d02c891b8850099
turbo-cache-controlno-cache
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive full-width full-width-p-0
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseed399b49bbeccb1e64d5dd1955c1f09334a52098
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/1116/checks#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F1116%2Fchecks
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F1116%2Fchecks
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/1116/checks
Reloadhttps://github.com/python-control/python-control/pull/1116/checks
Reloadhttps://github.com/python-control/python-control/pull/1116/checks
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
murrayrmhttps://github.com/murrayrm
python-control:mainhttps://github.com/python-control/python-control/tree/main
murrayrm:update_ssmatrix-01Feb2025https://github.com/murrayrm/python-control/tree/update_ssmatrix-01Feb2025
Conversation 3 https://github.com/python-control/python-control/pull/1116
Commits 1 https://github.com/python-control/python-control/pull/1116/commits
Checks 13 https://github.com/python-control/python-control/pull/1116/checks
Files changed https://github.com/python-control/python-control/pull/1116/files
Please reload this pagehttps://github.com/python-control/python-control/pull/1116/checks
Please reload this pagehttps://github.com/python-control/python-control/pull/1116/checks
Sign in for the full log viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F1116%2Fchecks
Update _ssmatrix and _check_shape for consistent usage https://github.com/python-control/python-control/pull/1116/checks#top
Please reload this pagehttps://github.com/python-control/python-control/pull/1116/checks
Setup, Examples, Notebooks on: pull_request https://github.com/python-control/python-control/actions/runs/13096124092
install-examples https://github.com/python-control/python-control/actions/runs/13096124092/job/36538596115?pr=1116
Slycot from source on: pull_request https://github.com/python-control/python-control/actions/runs/13096124093
build-linux https://github.com/python-control/python-control/actions/runs/13096124093/job/36538596116?pr=1116
Conda-based pytest on: pull_request https://github.com/python-control/python-control/actions/runs/13096124094
Py3.10; no Slycot; no Pandas; no CVXOPT https://github.com/python-control/python-control/actions/runs/13096124094/job/36538928626?pr=1116
Py3.10; no Slycot; no Pandas; conda CVXOPT https://github.com/python-control/python-control/actions/runs/13096124094/job/36538928741?pr=1116
Py3.10; conda Slycot; no Pandas; no CVXOPT https://github.com/python-control/python-control/actions/runs/13096124094/job/36538928832?pr=1116
Py3.10; conda Slycot; no Pandas; conda CVXOPT https://github.com/python-control/python-control/actions/runs/13096124094/job/36538928923?pr=1116
Py3.12; no Slycot; no Pandas; no CVXOPT https://github.com/python-control/python-control/actions/runs/13096124094/job/36538929014?pr=1116
Py3.12; no Slycot; no Pandas; conda CVXOPT https://github.com/python-control/python-control/actions/runs/13096124094/job/36538929094?pr=1116
Py3.12; conda Slycot; no Pandas; no CVXOPT https://github.com/python-control/python-control/actions/runs/13096124094/job/36538929158?pr=1116
Py3.12; conda Slycot; no Pandas; conda CVXOPT https://github.com/python-control/python-control/actions/runs/13096124094/job/36538929227?pr=1116
Py3.12; conda Slycot; conda Pandas; conda CVXOPT ; QtAgg https://github.com/python-control/python-control/actions/runs/13096124094/job/36538929306?pr=1116
Finalize parallel coveralls https://github.com/python-control/python-control/actions/runs/13096124094/job/36539107787?pr=1116
Doctest on: pull_request https://github.com/python-control/python-control/actions/runs/13096124096
doctest-linux https://github.com/python-control/python-control/actions/runs/13096124096/job/36538596126?pr=1116
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.