Title: Update _ssmatrix and _check_shape for consistent usage by murrayrm · Pull Request #1116 · python-control/python-control · GitHub
Open Graph Title: Update _ssmatrix and _check_shape for consistent usage by murrayrm · Pull Request #1116 · python-control/python-control
X Title: Update _ssmatrix and _check_shape for consistent usage by murrayrm · Pull Request #1116 · python-control/python-control
Description: Prompted by issue #1100, this PR updates the _ssmatrix and _check_shape functions to make their usage more consistent and remove legacy calls that are no longer needed. Changes: Updated _ssmatrix to allow checking for square matrices and row/col dimensions, with improved error messages that include the name of the matrix generating the error. Functions that accept state-space matrices now call _ssmatrix for uniform processing. Removed unneeded calls to _ssmatrix on outputs of functions in mateqn.py and other places. These calls were used back when we supported the NumPy matrix class and are no longer required. Fixed acker to use the matrices generated by _ssmatrix. Updated _check_shape to have a call signature that is more conistent with _ssmatrix: the matrix and dimensions are first, followed by optional keywords, with a name keyword for the name of the matrix being checked (for error messages). Removed internal _check_shape in statefbk.py and replaced with a call to mateqn._check_shape. Updated unit tests to reflect the new wording of some error messages.
Open Graph Description: Prompted by issue #1100, this PR updates the _ssmatrix and _check_shape functions to make their usage more consistent and remove legacy calls that are no longer needed. Changes: Updated _ssmatrix ...
X Description: Prompted by issue #1100, this PR updates the _ssmatrix and _check_shape functions to make their usage more consistent and remove legacy calls that are no longer needed. Changes: Updated _ssmatrix ...
Opengraph URL: https://github.com/python-control/python-control/pull/1116
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:49b5ad3e-dfbe-6367-5f37-6172c8f8928c |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 9F32:2E14C0:D11DE7:1276DAE:6979FE89 |
| html-safe-nonce | c6558de86b7078a1eb58772ebc66d68ad43ec5c803c7d44726000d2a8a58830a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjMyOjJFMTRDMDpEMTFERTc6MTI3NkRBRTo2OTc5RkU4OSIsInZpc2l0b3JfaWQiOiIzNzc0NTA2NjE4Mjg4OTk1OTc3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1982c8d25f1a4cda29bea732dce020f7f87c3332647faf2941028a272225e8d9 |
| hovercard-subject-tag | pull_request:2311104720 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/1116/checks |
| twitter:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| og:image:alt | Prompted by issue #1100, this PR updates the _ssmatrix and _check_shape functions to make their usage more consistent and remove legacy calls that are no longer needed. Changes: Updated _ssmatrix ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6cfe1afbf5a34a44e1b6fd6038587da09ec2a9c26ef005774d02c891b8850099 |
| turbo-cache-control | no-cache |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ed399b49bbeccb1e64d5dd1955c1f09334a52098 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width