Title: Move _tf_close_coeff back to testing realm and make better use of assertion messages by bnavigator · Pull Request #1109 · python-control/python-control · GitHub
Open Graph Title: Move _tf_close_coeff back to testing realm and make better use of assertion messages by bnavigator · Pull Request #1109 · python-control/python-control
X Title: Move _tf_close_coeff back to testing realm and make better use of assertion messages by bnavigator · Pull Request #1109 · python-control/python-control
Description: The OS/BLAS testing matrix started to fail with some macOS tests and the assertion messages make them hard to inspect: https://github.com/python-control/python-control/actions/runs/13087050463/job/36519541162#step:9:298 FAILED control/tests/statesp_test.py::TestStateSpace::test_pow - assert False + where False = _tf_close_coeff(TransferFunction(\n[[array([1.]), array([0.])],\n [array([0.]), array([1.])]],\n[[array([1.]), array([1.])],\n [array([1.]), array([1.])]],\noutputs=2, inputs=2), TransferFunction(\n[[array([1.]), array([-2.76395297e-15, -1.35541257e-13, 9.01576541e-13])],\n [array([0.]), array([1.])]],\n[[array([1.]), array([ 1., 3., -9., -41.])],\n [array([1.]), array([1.])]],\noutputs=2, inputs=2)) + where TransferFunction(\n[[array([1.]), array([0.])],\n [array([0.]), array([1.])]],\n[[array([1.]), array([1.])],\n [array([1.]), array([1.])]],\noutputs=2, inputs=2) = minreal() + where minreal = TransferFunction(\n[[array([1.]), array([0.])],\n [array([0.]), array([1.])]],\n[[array([1.]), array([1.])],\n [array([1.]), array([1.])]],\noutputs=2, inputs=2).minreal + where TransferFunction(\n[[array([1.]), array([0.])],\n [array([0.]), array([1.])]],\n[[array([1.]), array([1.])],\n [array([1.]), array([1.])]],\noutputs=2, inputs=2) = ss2tf(StateSpace(\narray([], shape=(0, 0), dtype=float64),\narray([], shape=(0, 2), dtype=float64),\narray([], shape=(2, 0), dtype=float64),\narray([[1., 0.],\n [0., 1.]]),\nstates=0, outputs=2, inputs=2)) + and TransferFunction(\n[[array([1.]), array([-2.76395297e-15, -1.35541257e-13, 9.01576541e-13])],\n [array([0.]), array([1.])]],\n[[array([1.]), array([ 1., 3., -9., -41.])],\n [array([1.]), array([1.])]],\noutputs=2, inputs=2) = minreal() + where minreal = TransferFunction(\n[[array([ 1., 3., -9., -41.]), \n array([-2.76395297e-15, -1.35541257e-13, 9.01576541e-13])],\n ...., 3., -9., -41.]), array([ 1., 3., -9., -41.])],\n [array([1.]), array([1., 0., 0., 0.])]],\noutputs=2, inputs=2).minreal + where TransferFunction(\n[[array([ 1., 3., -9., -41.]), \n array([-2.76395297e-15, -1.35541257e-13, 9.01576541e-13])],\n ...., 3., -9., -41.]), array([ 1., 3., -9., -41.])],\n [array([1.]), array([1., 0., 0., 0.])]],\noutputs=2, inputs=2) = ss2tf(StateSpace(\narray([[ 4.86563613, -0.22114886, -14.38268526],\n [ 3.86388385, -1.64824725, -16.2652334 ],\n ... [0.00000000e+00, 2.59786829e-16, 3.85014366e-15]]),\narray([[1., 0.],\n [0., 1.]]),\nstates=3, outputs=2, inputs=2)) Let's try to make this easier by using numpy's and pytest's assertion rewriting.
Open Graph Description: The OS/BLAS testing matrix started to fail with some macOS tests and the assertion messages make them hard to inspect: https://github.com/python-control/python-control/actions/runs/13087050463/job/...
X Description: The OS/BLAS testing matrix started to fail with some macOS tests and the assertion messages make them hard to inspect: https://github.com/python-control/python-control/actions/runs/13087050463/job/...
Opengraph URL: https://github.com/python-control/python-control/pull/1109
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:2ce88cf5-fb4f-af56-ce7c-85c695aa2890 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CC08:3F9C45:12550CF:1A26208:697A391B |
| html-safe-nonce | bb4ee8e3035944ebebea796a46ee436266990c5ac1660e71755abb4cd065baf3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzA4OjNGOUM0NToxMjU1MENGOjFBMjYyMDg6Njk3QTM5MUIiLCJ2aXNpdG9yX2lkIjoiNDMwNDM0NzAwMzgzMjkwODA1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9d3adf870a7d4d69d60119b2de60d7525b95d09e3f8b65d0ed4c97b6dc0a2a81 |
| hovercard-subject-tag | pull_request:2310673751 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/1109/files |
| twitter:image | https://avatars.githubusercontent.com/u/4623504?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4623504?s=400&v=4 |
| og:image:alt | The OS/BLAS testing matrix started to fail with some macOS tests and the assertion messages make them hard to inspect: https://github.com/python-control/python-control/actions/runs/13087050463/job/... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | af6de804ceb83ad30bb9b348cdeaccaa30cdcb566762d5e74e21e2bad88885d0 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2d980605f0959039ddebcbcf522b072508302977 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width