René's URL Explorer Experiment
Title: Move _tf_close_coeff back to testing realm and make better use of assertion messages by bnavigator · Pull Request #1109 · python-control/python-control · GitHub
Open Graph Title: Move _tf_close_coeff back to testing realm and make better use of assertion messages by bnavigator · Pull Request #1109 · python-control/python-control
X Title: Move _tf_close_coeff back to testing realm and make better use of assertion messages by bnavigator · Pull Request #1109 · python-control/python-control
Description: The OS/BLAS testing matrix started to fail with some macOS tests and the assertion messages make them hard to inspect:
https://github.com/python-control/python-control/actions/runs/13087050463/job/36519541162#step:9:298
FAILED control/tests/statesp_test.py::TestStateSpace::test_pow - assert False
+ where False = _tf_close_coeff(TransferFunction(\n[[array([1.]), array([0.])],\n [array([0.]), array([1.])]],\n[[array([1.]), array([1.])],\n [array([1.]), array([1.])]],\noutputs=2, inputs=2), TransferFunction(\n[[array([1.]), array([-2.76395297e-15, -1.35541257e-13, 9.01576541e-13])],\n [array([0.]), array([1.])]],\n[[array([1.]), array([ 1., 3., -9., -41.])],\n [array([1.]), array([1.])]],\noutputs=2, inputs=2))
+ where TransferFunction(\n[[array([1.]), array([0.])],\n [array([0.]), array([1.])]],\n[[array([1.]), array([1.])],\n [array([1.]), array([1.])]],\noutputs=2, inputs=2) = minreal()
+ where minreal = TransferFunction(\n[[array([1.]), array([0.])],\n [array([0.]), array([1.])]],\n[[array([1.]), array([1.])],\n [array([1.]), array([1.])]],\noutputs=2, inputs=2).minreal
+ where TransferFunction(\n[[array([1.]), array([0.])],\n [array([0.]), array([1.])]],\n[[array([1.]), array([1.])],\n [array([1.]), array([1.])]],\noutputs=2, inputs=2) = ss2tf(StateSpace(\narray([], shape=(0, 0), dtype=float64),\narray([], shape=(0, 2), dtype=float64),\narray([], shape=(2, 0), dtype=float64),\narray([[1., 0.],\n [0., 1.]]),\nstates=0, outputs=2, inputs=2))
+ and TransferFunction(\n[[array([1.]), array([-2.76395297e-15, -1.35541257e-13, 9.01576541e-13])],\n [array([0.]), array([1.])]],\n[[array([1.]), array([ 1., 3., -9., -41.])],\n [array([1.]), array([1.])]],\noutputs=2, inputs=2) = minreal()
+ where minreal = TransferFunction(\n[[array([ 1., 3., -9., -41.]), \n array([-2.76395297e-15, -1.35541257e-13, 9.01576541e-13])],\n ...., 3., -9., -41.]), array([ 1., 3., -9., -41.])],\n [array([1.]), array([1., 0., 0., 0.])]],\noutputs=2, inputs=2).minreal
+ where TransferFunction(\n[[array([ 1., 3., -9., -41.]), \n array([-2.76395297e-15, -1.35541257e-13, 9.01576541e-13])],\n ...., 3., -9., -41.]), array([ 1., 3., -9., -41.])],\n [array([1.]), array([1., 0., 0., 0.])]],\noutputs=2, inputs=2) = ss2tf(StateSpace(\narray([[ 4.86563613, -0.22114886, -14.38268526],\n [ 3.86388385, -1.64824725, -16.2652334 ],\n ... [0.00000000e+00, 2.59786829e-16, 3.85014366e-15]]),\narray([[1., 0.],\n [0., 1.]]),\nstates=3, outputs=2, inputs=2))
Let's try to make this easier by using numpy's and pytest's assertion rewriting.
Open Graph Description: The OS/BLAS testing matrix started to fail with some macOS tests and the assertion messages make them hard to inspect:
https://github.com/python-control/python-control/actions/runs/13087050463/job/...
X Description: The OS/BLAS testing matrix started to fail with some macOS tests and the assertion messages make them hard to inspect:
https://github.com/python-control/python-control/actions/runs/13087050463/job/...
Opengraph URL: https://github.com/python-control/python-control/pull/1109
X: @github
direct link
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:bbb24049-8f15-96af-2e89-f4fd7835af80 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 931E:3A72BD:13464D1:1B94BB9:697A39C6 |
| html-safe-nonce | 0406b243bc3dad3c2531d29c936630f72623996f48948ea843d0788e0509834a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzFFOjNBNzJCRDoxMzQ2NEQxOjFCOTRCQjk6Njk3QTM5QzYiLCJ2aXNpdG9yX2lkIjoiMTU2Mzk1NTI0NTMxMjc4NDgzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 66b6c5ecde7005de51f0e2d05f3a878aed9fb62f866d3b40c3760da5213fd7db |
| hovercard-subject-tag | pull_request:2310673751 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/checks |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/1109/checks |
| twitter:image | https://avatars.githubusercontent.com/u/4623504?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4623504?s=400&v=4 |
| og:image:alt | The OS/BLAS testing matrix started to fail with some macOS tests and the assertion messages make them hard to inspect:
https://github.com/python-control/python-control/actions/runs/13087050463/job/... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | af6de804ceb83ad30bb9b348cdeaccaa30cdcb566762d5e74e21e2bad88885d0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2d980605f0959039ddebcbcf522b072508302977 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
| Skip to content | https://github.com/python-control/python-control/pull/1109/checks#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F1109%2Fchecks |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F1109%2Fchecks |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=python-control%2Fpython-control |
| Reload | https://github.com/python-control/python-control/pull/1109/checks |
| Reload | https://github.com/python-control/python-control/pull/1109/checks |
| Reload | https://github.com/python-control/python-control/pull/1109/checks |
|
python-control
| https://github.com/python-control |
| python-control | https://github.com/python-control/python-control |
|
Notifications
| https://github.com/login?return_to=%2Fpython-control%2Fpython-control |
|
Fork
447
| https://github.com/login?return_to=%2Fpython-control%2Fpython-control |
|
Star
2k
| https://github.com/login?return_to=%2Fpython-control%2Fpython-control |
|
Code
| https://github.com/python-control/python-control |
|
Issues
87
| https://github.com/python-control/python-control/issues |
|
Pull requests
8
| https://github.com/python-control/python-control/pulls |
|
Discussions
| https://github.com/python-control/python-control/discussions |
|
Actions
| https://github.com/python-control/python-control/actions |
|
Projects
0
| https://github.com/python-control/python-control/projects |
|
Wiki
| https://github.com/python-control/python-control/wiki |
|
Security
0
| https://github.com/python-control/python-control/security |
|
Insights
| https://github.com/python-control/python-control/pulse |
|
Code
| https://github.com/python-control/python-control |
|
Issues
| https://github.com/python-control/python-control/issues |
|
Pull requests
| https://github.com/python-control/python-control/pulls |
|
Discussions
| https://github.com/python-control/python-control/discussions |
|
Actions
| https://github.com/python-control/python-control/actions |
|
Projects
| https://github.com/python-control/python-control/projects |
|
Wiki
| https://github.com/python-control/python-control/wiki |
|
Security
| https://github.com/python-control/python-control/security |
|
Insights
| https://github.com/python-control/python-control/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose |
| murrayrm | https://github.com/murrayrm |
| python-control:main | https://github.com/python-control/python-control/tree/main |
| bnavigator:assert_tf_close_coeff | https://github.com/bnavigator/python-control/tree/assert_tf_close_coeff |
|
Conversation
10
| https://github.com/python-control/python-control/pull/1109 |
|
Commits
5
| https://github.com/python-control/python-control/pull/1109/commits |
|
Checks
39
| https://github.com/python-control/python-control/pull/1109/checks |
|
Files changed
| https://github.com/python-control/python-control/pull/1109/files |
| Please reload this page | https://github.com/python-control/python-control/pull/1109/checks |
| Please reload this page | https://github.com/python-control/python-control/pull/1109/checks |
| Sign in for the full log view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F1109%2Fchecks |
|
Move _tf_close_coeff back to testing realm and make better use of assertion messages
| https://github.com/python-control/python-control/pull/1109/checks#top |
| Please reload this page | https://github.com/python-control/python-control/pull/1109/checks |
|
Doctest
on: pull_request
| https://github.com/python-control/python-control/actions/runs/13090999418 |
|
doctest-linux
| https://github.com/python-control/python-control/actions/runs/13090999418/job/36527599011?pr=1109 |
|
OS/BLAS test matrix
on: pull_request
| https://github.com/python-control/python-control/actions/runs/13090999419 |
|
Build pip Py3.10, ubuntu, unset BLA_VENDOR
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527599429?pr=1109 |
|
Build pip Py3.12, ubuntu, unset BLA_VENDOR
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527599614?pr=1109 |
|
Build pip Py3.10, macos, unset BLA_VENDOR
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527599688?pr=1109 |
|
Build pip Py3.12, macos, unset BLA_VENDOR
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527599768?pr=1109 |
|
Build pip Py3.12, ubuntu, Generic BLA_VENDOR
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527599851?pr=1109 |
|
Build pip Py3.12, ubuntu, OpenBLAS BLA_VENDOR
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527599949?pr=1109 |
|
Build pip Py3.12, macos, Apple BLA_VENDOR
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527600099?pr=1109 |
|
Build pip Py3.12, macos, Generic BLA_VENDOR
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527600260?pr=1109 |
|
Build pip Py3.12, macos, OpenBLAS BLA_VENDOR
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527600355?pr=1109 |
|
Build conda Py3.11, ubuntu
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527599031?pr=1109 |
|
Build conda Py3.11, macos
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527599309?pr=1109 |
|
Build conda Py3.11, windows
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527599522?pr=1109 |
|
Create wheel test matrix
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527658522?pr=1109 |
|
Create conda test matrix
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527828148?pr=1109 |
|
Test wheel macos-3.12-Generic, Generic BLAS lib
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527660898?pr=1109 |
|
Test wheel macos-3.12-Generic, OpenBLAS BLAS lib
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527661069?pr=1109 |
|
Test wheel macos-3.12-Generic, Apple BLAS lib
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527661137?pr=1109 |
|
Test wheel ubuntu-3.12-OpenBLAS, OpenBLAS BLAS lib
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527661232?pr=1109 |
|
Test wheel ubuntu-3.12-Generic, Generic BLAS lib
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527661310?pr=1109 |
|
Test wheel ubuntu-3.12-Generic, OpenBLAS BLAS lib
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527661415?pr=1109 |
|
Test wheel macos-3.12-unset, unset BLAS lib
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527661501?pr=1109 |
|
Test wheel ubuntu-3.10-unset, unset BLAS lib
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527661589?pr=1109 |
|
Test wheel macos-3.12-Apple, Apple BLAS lib
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527661683?pr=1109 |
|
Test wheel ubuntu-3.12-unset, unset BLAS lib
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527661767?pr=1109 |
|
Test wheel macos-3.10-unset, unset BLAS lib
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527661847?pr=1109 |
|
Test wheel macos-3.12-OpenBLAS, OpenBLAS BLAS lib
| https://github.com/python-control/python-control/actions/runs/13090999419/job/36527661938?pr=1109 |
|
Conda-based pytest
on: pull_request
| https://github.com/python-control/python-control/actions/runs/13090999420 |
|
Py3.10; no Slycot; no Pandas; no CVXOPT
| https://github.com/python-control/python-control/actions/runs/13090999420/job/36531744369?pr=1109 |
|
Py3.10; no Slycot; no Pandas; conda CVXOPT
| https://github.com/python-control/python-control/actions/runs/13090999420/job/36531744456?pr=1109 |
|
Py3.10; conda Slycot; no Pandas; no CVXOPT
| https://github.com/python-control/python-control/actions/runs/13090999420/job/36531744511?pr=1109 |
|
Py3.10; conda Slycot; no Pandas; conda CVXOPT
| https://github.com/python-control/python-control/actions/runs/13090999420/job/36531744575?pr=1109 |
|
Py3.12; no Slycot; no Pandas; no CVXOPT
| https://github.com/python-control/python-control/actions/runs/13090999420/job/36531744660?pr=1109 |
|
Py3.12; no Slycot; no Pandas; conda CVXOPT
| https://github.com/python-control/python-control/actions/runs/13090999420/job/36531744726?pr=1109 |
|
Py3.12; conda Slycot; no Pandas; no CVXOPT
| https://github.com/python-control/python-control/actions/runs/13090999420/job/36531744786?pr=1109 |
|
Py3.12; conda Slycot; no Pandas; conda CVXOPT
| https://github.com/python-control/python-control/actions/runs/13090999420/job/36531744844?pr=1109 |
|
Py3.12; conda Slycot; conda Pandas; conda CVXOPT ; QtAgg
| https://github.com/python-control/python-control/actions/runs/13090999420/job/36531744898?pr=1109 |
|
Finalize parallel coveralls
| https://github.com/python-control/python-control/actions/runs/13090999420/job/36531853641?pr=1109 |
|
Slycot from source
on: pull_request
| https://github.com/python-control/python-control/actions/runs/13090999421 |
|
build-linux
| https://github.com/python-control/python-control/actions/runs/13090999421/job/36527599001?pr=1109 |
|
Setup, Examples, Notebooks
on: pull_request
| https://github.com/python-control/python-control/actions/runs/13090999428 |
|
install-examples
| https://github.com/python-control/python-control/actions/runs/13090999428/job/36527598999?pr=1109 |
|
| https://github.com/python-control/python-control/pull/1109/checks#annotation:3:340 |
|
| https://github.com/python-control/python-control/pull/1109/checks#annotation:3:359 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |
Viewport: width=device-width
URLs of crawlers that visited me.