Title: fix complex -> real error messages by murrayrm · Pull Request #1086 · python-control/python-control · GitHub
Open Graph Title: fix complex -> real error messages by murrayrm · Pull Request #1086 · python-control/python-control
X Title: fix complex -> real error messages by murrayrm · Pull Request #1086 · python-control/python-control
Description: This is a small PR that fixes some errors I found when updating the documentation. In two cases, there was a complex-valued array getting used as a real-valued array (and generating an error message): In TransferFunction._common_den, the numerator and denominator polynomial's are computing by extracting poles and zeros and then regenerating polynomials. Because the poles and zeros can be complex, the operations generate a complex-valued array of coefficients. These should be cast back to real coefficients before assigning them back to the real-valued numerator and denominator coefficient arrays. This error showed up in examples/cruise.ipynb, which was also updated to remove the error message in the Output cells. In examples/describing-function.ipynb there was a plot of the describing function for a static nonlinearity. Because describing functions can be complex valued in general (eg, if there is hysteresis), before plotting the value of the real-valued describing function, the results needs to be explicitly cast to real (otherwise you get an error message). This was a small change in the Jupyter notebook. For the two Jupyter notebooks, all of the plots were also updated, even though they basically look the same => the changes look bigger than they are (and rendering the difference is very slow...).
Open Graph Description: This is a small PR that fixes some errors I found when updating the documentation. In two cases, there was a complex-valued array getting used as a real-valued array (and generating an error messa...
X Description: This is a small PR that fixes some errors I found when updating the documentation. In two cases, there was a complex-valued array getting used as a real-valued array (and generating an error messa...
Opengraph URL: https://github.com/python-control/python-control/pull/1086
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:325f5ddb-3884-7588-5ba3-61e9372b4c3a |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 931A:3CE003:12AAF9F:1A78F7C:697A39C5 |
| html-safe-nonce | 4028fb3540bf8fe17f1415d5bd3dd699dd2bf1b0d1f4ab4a7cc991a5620fa2ff |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzFBOjNDRTAwMzoxMkFBRjlGOjFBNzhGN0M6Njk3QTM5QzUiLCJ2aXNpdG9yX2lkIjoiOTAyODExMjA2MjE2MDE4OTg5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d7a778750865546d9f56ed521fa732294ec90ff19362c80ed86d82f7099681c1 |
| hovercard-subject-tag | pull_request:2254994870 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/1086/checks |
| twitter:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| og:image:alt | This is a small PR that fixes some errors I found when updating the documentation. In two cases, there was a complex-valued array getting used as a real-valued array (and generating an error messa... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | af6de804ceb83ad30bb9b348cdeaccaa30cdcb566762d5e74e21e2bad88885d0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2d980605f0959039ddebcbcf522b072508302977 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width