René's URL Explorer Experiment


Title: fix timebase processing in frd, zpk by murrayrm · Pull Request #1064 · python-control/python-control · GitHub

Open Graph Title: fix timebase processing in frd, zpk by murrayrm · Pull Request #1064 · python-control/python-control

X Title: fix timebase processing in frd, zpk by murrayrm · Pull Request #1064 · python-control/python-control

Description: This PR addresses issue #1062 by making sure that timebases are handled uniformly in all system creation factory functions: For ss, tf, frd, and zpk, use either an additional argument specifying the sampling time or use the dt keyword (using both generates a warning). For nlsys, use the dt keyword If no timebase is specified, use the default timebase set by config.defaults['control.default_dt'], which is 0 (continuous time) unless you change it. It was the last of these that was the problem in zpk: it was defaulting to None and that was later interpreted as a discrete time system. Also added unit tests to make sure everything is consistent across the different factory functions.

Open Graph Description: This PR addresses issue #1062 by making sure that timebases are handled uniformly in all system creation factory functions: For ss, tf, frd, and zpk, use either an additional argument specifying t...

X Description: This PR addresses issue #1062 by making sure that timebases are handled uniformly in all system creation factory functions: For ss, tf, frd, and zpk, use either an additional argument specifying t...

Opengraph URL: https://github.com/python-control/python-control/pull/1064

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:805d5f2e-91cc-1290-69ee-1f7422532106
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8EA:169132:1C892D:27B116:697B3F62
html-safe-nonce903c67a6a1793bb97d9d13216063363a0cb67833e2336e8b1564d734f09f29b8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEVBOjE2OTEzMjoxQzg5MkQ6MjdCMTE2OjY5N0IzRjYyIiwidmlzaXRvcl9pZCI6IjE1NzM0OTc0MTcxMDQwNDc5NzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd1e2460d681dbab869808e0296b4636729cdc28fcbbb39d212de5e314cb723cd
hovercard-subject-tagpull_request:2195990097
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/1064/files
twitter:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
og:image:altThis PR addresses issue #1062 by making sure that timebases are handled uniformly in all system creation factory functions: For ss, tf, frd, and zpk, use either an additional argument specifying t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None6fe64d94889230be19a900846cfc91707e7dd4206878d6c208922b46a6b0735d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release15736a47b83581130a149aa1b928696bea06adde
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/1064/changes#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F1064%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F1064%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/1064/changes
Reloadhttps://github.com/python-control/python-control/pull/1064/changes
Reloadhttps://github.com/python-control/python-control/pull/1064/changes
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
bnavigatorhttps://github.com/bnavigator
python-control:mainhttps://github.com/python-control/python-control/tree/main
murrayrm:fix_frd_timebase-20Nov2024https://github.com/murrayrm/python-control/tree/fix_frd_timebase-20Nov2024
Conversation 1 https://github.com/python-control/python-control/pull/1064
Commits 2 https://github.com/python-control/python-control/pull/1064/commits
Checks 0 https://github.com/python-control/python-control/pull/1064/checks
Files changed https://github.com/python-control/python-control/pull/1064/files
Please reload this pagehttps://github.com/python-control/python-control/pull/1064/changes
fix timebase processing in frd, zpk https://github.com/python-control/python-control/pull/1064/changes#top
Show all changes 2 commits https://github.com/python-control/python-control/pull/1064/files
f25e625 fix timebase processing in frd, zpk murrayrm Nov 21, 2024 https://github.com/python-control/python-control/pull/1064/commits/f25e6254ef1ca5527ee2d8a10bfbded42758331d
8b29e45 make frd timebase duplication testing consistent + unit tests murrayrm Nov 22, 2024 https://github.com/python-control/python-control/pull/1064/commits/8b29e45d71182a3b0ff60d1f1634fb0b63a5b715
Clear filters https://github.com/python-control/python-control/pull/1064/files
Please reload this pagehttps://github.com/python-control/python-control/pull/1064/changes
Please reload this pagehttps://github.com/python-control/python-control/pull/1064/changes
frdata.py https://github.com/python-control/python-control/pull/1064/changes#diff-cacf59417131c19becd6fba4dde9e979bed49ce572eb24f0f62bd2af460d83d1
docstrings_test.py https://github.com/python-control/python-control/pull/1064/changes#diff-f098dc1536e0667ba32b96b805f95b4ee82c1c1c81e0547799106131b713028f
timebase_test.py https://github.com/python-control/python-control/pull/1064/changes#diff-612d6b19662d8e7789b877186aaaaf795d2a276b5b22f62c8c2f29f1bc72af8e
xferfcn.py https://github.com/python-control/python-control/pull/1064/changes#diff-0dd9424d3024fc1d5cc8fd67d13efe5703318c4c705526ab0ae216de69ce3de7
control/frdata.pyhttps://github.com/python-control/python-control/pull/1064/changes#diff-cacf59417131c19becd6fba4dde9e979bed49ce572eb24f0f62bd2af460d83d1
View file https://github.com/murrayrm/python-control/blob/8b29e45d71182a3b0ff60d1f1634fb0b63a5b715/control/frdata.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/1064/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/1064/changes#diff-cacf59417131c19becd6fba4dde9e979bed49ce572eb24f0f62bd2af460d83d1
https://github.com/python-control/python-control/pull/1064/changes#diff-cacf59417131c19becd6fba4dde9e979bed49ce572eb24f0f62bd2af460d83d1
https://github.com/python-control/python-control/pull/1064/changes#diff-cacf59417131c19becd6fba4dde9e979bed49ce572eb24f0f62bd2af460d83d1
https://github.com/python-control/python-control/pull/1064/changes#diff-cacf59417131c19becd6fba4dde9e979bed49ce572eb24f0f62bd2af460d83d1
control/tests/docstrings_test.pyhttps://github.com/python-control/python-control/pull/1064/changes#diff-f098dc1536e0667ba32b96b805f95b4ee82c1c1c81e0547799106131b713028f
View file https://github.com/murrayrm/python-control/blob/8b29e45d71182a3b0ff60d1f1634fb0b63a5b715/control/tests/docstrings_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/1064/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/1064/changes#diff-f098dc1536e0667ba32b96b805f95b4ee82c1c1c81e0547799106131b713028f
https://github.com/python-control/python-control/pull/1064/changes#diff-f098dc1536e0667ba32b96b805f95b4ee82c1c1c81e0547799106131b713028f
control/tests/timebase_test.pyhttps://github.com/python-control/python-control/pull/1064/changes#diff-612d6b19662d8e7789b877186aaaaf795d2a276b5b22f62c8c2f29f1bc72af8e
View file https://github.com/murrayrm/python-control/blob/8b29e45d71182a3b0ff60d1f1634fb0b63a5b715/control/tests/timebase_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/1064/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/1064/changes#diff-612d6b19662d8e7789b877186aaaaf795d2a276b5b22f62c8c2f29f1bc72af8e
control/xferfcn.pyhttps://github.com/python-control/python-control/pull/1064/changes#diff-0dd9424d3024fc1d5cc8fd67d13efe5703318c4c705526ab0ae216de69ce3de7
View file https://github.com/murrayrm/python-control/blob/8b29e45d71182a3b0ff60d1f1634fb0b63a5b715/control/xferfcn.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/1064/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/1064/changes#diff-0dd9424d3024fc1d5cc8fd67d13efe5703318c4c705526ab0ae216de69ce3de7
https://github.com/python-control/python-control/pull/1064/changes#diff-0dd9424d3024fc1d5cc8fd67d13efe5703318c4c705526ab0ae216de69ce3de7
https://github.com/python-control/python-control/pull/1064/changes#diff-0dd9424d3024fc1d5cc8fd67d13efe5703318c4c705526ab0ae216de69ce3de7
https://github.com/python-control/python-control/pull/1064/changes#diff-0dd9424d3024fc1d5cc8fd67d13efe5703318c4c705526ab0ae216de69ce3de7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.