Title: A bug in bdalg.connect function · Issue #421 · python-control/python-control · GitHub
Open Graph Title: A bug in bdalg.connect function · Issue #421 · python-control/python-control
X Title: A bug in bdalg.connect function · Issue #421 · python-control/python-control
Description: Dear all, I found a bug in the connect function in the bdalg.py: 335: elif outp < 0 and -outp >= -sys.outputs: if outp < 0, the index meant is -outp because the negative sign is to tell it is negative feedback. (-outp) must be in the ran...
Open Graph Description: Dear all, I found a bug in the connect function in the bdalg.py: 335: elif outp < 0 and -outp >= -sys.outputs: if outp < 0, the index meant is -outp because the negative sign is to tell it is negat...
X Description: Dear all, I found a bug in the connect function in the bdalg.py: 335: elif outp < 0 and -outp >= -sys.outputs: if outp < 0, the index meant is -outp because the negative sign is to tell it...
Opengraph URL: https://github.com/python-control/python-control/issues/421
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"A bug in bdalg.connect function","articleBody":"Dear all,\r\n\r\nI found a bug in the connect function in the bdalg.py:\r\n\r\n335: elif outp \u003c 0 and -outp \u003e= -sys.outputs:\r\n\r\nif outp \u003c 0, the index meant is -outp because the negative sign is to tell it is negative feedback.\r\n(-outp) must be in the range [1, sys.outputs]. As outp \u003c 0, -outp \u003e 0 already. Hence, the remaining thing is that -outp \u003c= sys.outputs. The code must be corrected like this:\r\n\r\n335: elif outp \u003c 0 and -outp **_\u003c= sys.outputs_**:\r\n\r\nRegards.\r\n\r\nSeung-Kil\r\n","author":{"url":"https://github.com/SeungKil-Paek","@type":"Person","name":"SeungKil-Paek"},"datePublished":"2020-06-20T06:04:35.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":7},"url":"https://github.com/421/python-control/issues/421"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:7ed869b4-68e8-aa99-6ea6-bde7f738fe07 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C660:2EDE9:585130:78FF20:697BD3D3 |
| html-safe-nonce | bcba689cefc3b0d63492a0009d309d00faa93482e4f7b5be241233a8aa43222e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjYwOjJFREU5OjU4NTEzMDo3OEZGMjA6Njk3QkQzRDMiLCJ2aXNpdG9yX2lkIjoiNDYxMzUyMzU5NjE4NDkwMDU2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 76c0336c6b43a0c2f38776452e5453b4d1e582005e4ad746d6f347c7c102e9a6 |
| hovercard-subject-tag | issue:642317301 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-control/python-control/421/issue_layout |
| twitter:image | https://opengraph.githubassets.com/18da606f98cb0158fabaed3db98b02b9e532d117ff084c17e3cdb5411f2e1ade/python-control/python-control/issues/421 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/18da606f98cb0158fabaed3db98b02b9e532d117ff084c17e3cdb5411f2e1ade/python-control/python-control/issues/421 |
| og:image:alt | Dear all, I found a bug in the connect function in the bdalg.py: 335: elif outp < 0 and -outp >= -sys.outputs: if outp < 0, the index meant is -outp because the negative sign is to tell it is negat... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | SeungKil-Paek |
| hostname | github.com |
| expected-hostname | github.com |
| None | d9273cb6ee4e18acd2ce5be1d6a9f9b3984f728c67ac95709fc3d38fedbb2967 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 784b44795f41068c6521c17f38ad6ed44ce1775c |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width