Title: Any plan for step_info to support negative step responses? · Issue #337 · python-control/python-control · GitHub
Open Graph Title: Any plan for step_info to support negative step responses? · Issue #337 · python-control/python-control
X Title: Any plan for step_info to support negative step responses? · Issue #337 · python-control/python-control
Description: I have step responses that go negative and sometimes stay negative, and it breaks the settling time calculation and rise time calculation. I've been messing around with it and might open a pull request if this is something y'all would be...
Open Graph Description: I have step responses that go negative and sometimes stay negative, and it breaks the settling time calculation and rise time calculation. I've been messing around with it and might open a pull req...
X Description: I have step responses that go negative and sometimes stay negative, and it breaks the settling time calculation and rise time calculation. I've been messing around with it and might open a pull...
Opengraph URL: https://github.com/python-control/python-control/issues/337
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Any plan for step_info to support negative step responses?","articleBody":"I have step responses that go negative and sometimes stay negative, and it breaks the settling time calculation and rise time calculation. I've been messing around with it and might open a pull request if this is something y'all would be interested in. \r\n\r\nFor example, here is my code, the step response plot, and the error\r\n\r\n```python\r\nfrom control import tf, step_response, step_info\r\nimport matplotlib.pyplot as plt\r\nimport numpy as np\r\n\r\ntransfer_function = tf( [3.32, 0, -162.8], [1, 24.56, 186.5, 457.8, 116.2] )\r\ntime, response = step_response(transfer_function)\r\n\r\nfig, ax = plt.subplots(1, 1)\r\nax.plot(time, response)\r\nplt.show()\r\n\r\nstep_info(transfer_function)\r\n```\r\n\r\n\r\n\r\n`step_info()` gives the following error\r\n\r\n```\r\nTraceback (most recent call last):\r\n File \"bug_test.py\", line 14, in \u003cmodule\u003e\r\n step_info(transfer_function)\r\n File \"/Users/hgducharme/Programming/pendulum/env/lib/python3.7/site-packages/control/timeresp.py\", line 536, in step_info\r\n SettlingTime = T[i + 1]\r\nIndexError: index 1000 is out of bounds for axis 0 with size 1000\r\n```\r\n\r\nWhen I run this code in MATLAB, I get the following result\r\n\r\n\u003cbr\u003e\r\n\r\n\u003cimg width=\"644\" alt=\"Screen Shot 2019-08-20 at 8 36 44 PM\" src=\"https://user-images.githubusercontent.com/8628581/63395721-427e7e00-c38a-11e9-8ca3-25cd7bb7ce7d.png\"\u003e","author":{"url":"https://github.com/hgducharme","@type":"Person","name":"hgducharme"},"datePublished":"2019-08-21T01:37:25.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/337/python-control/issues/337"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:dcf62c98-60b4-d8af-eeee-842cabe9880e |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 949E:17D252:C89540:CB3CE5:697A7CE2 |
| html-safe-nonce | 7a3567fac010f4aa5281360bc9ed7856f5925ddcb3aea63503fee0cb79355d91 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDlFOjE3RDI1MjpDODk1NDA6Q0IzQ0U1OjY5N0E3Q0UyIiwidmlzaXRvcl9pZCI6Ijg3ODc0NjAxOTEyNTIyODI1OTQiLCJyZWdpb25fZWRnZSI6InNlYSIsInJlZ2lvbl9yZW5kZXIiOiJzZWEifQ== |
| visitor-hmac | dabd94694452586282211bd9b8f31a257ec13e64440b5777fc13bd2ab73289bd |
| hovercard-subject-tag | issue:483155951 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-control/python-control/337/issue_layout |
| twitter:image | https://opengraph.githubassets.com/5cd004ffc4af7cf03f08beb92edc9e45971f7f73e85b94190f12c4dc207c75d4/python-control/python-control/issues/337 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5cd004ffc4af7cf03f08beb92edc9e45971f7f73e85b94190f12c4dc207c75d4/python-control/python-control/issues/337 |
| og:image:alt | I have step responses that go negative and sometimes stay negative, and it breaks the settling time calculation and rise time calculation. I've been messing around with it and might open a pull req... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hgducharme |
| hostname | github.com |
| expected-hostname | github.com |
| None | a9d1eabfb8cf0cb510bcf598032681675ad29b7ee4cb3bfb9a0a088a12803628 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 31bacebc3305d80609c1b175449c3d314bd1a855 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width