Title: StateSpace constructor should not call _remove_useless_states · Issue #244 · python-control/python-control · GitHub
Open Graph Title: StateSpace constructor should not call _remove_useless_states · Issue #244 · python-control/python-control
X Title: StateSpace constructor should not call _remove_useless_states · Issue #244 · python-control/python-control
Description: State space representations should, in my opinion, not be reduced automatically with StateSpace._remove_useless_states(), similar to the fact that we don't call minreal() automatically. Unlike transfer functions, state space models can m...
Open Graph Description: State space representations should, in my opinion, not be reduced automatically with StateSpace._remove_useless_states(), similar to the fact that we don't call minreal() automatically. Unlike tran...
X Description: State space representations should, in my opinion, not be reduced automatically with StateSpace._remove_useless_states(), similar to the fact that we don't call minreal() automatically. Unlike ...
Opengraph URL: https://github.com/python-control/python-control/issues/244
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"StateSpace constructor should not call _remove_useless_states","articleBody":"State space representations should, in my opinion, not be reduced automatically with StateSpace._remove_useless_states(), similar to the fact that we don't call minreal() automatically.\r\n\r\nUnlike transfer functions, state space models can model non-observable or non-controllable behaviour, and cannot always be considered equivalent to their minimized form. Additionally, it is rather confusing to have `ss(A,B,C,D).A !== A` and e.g. `ss(A,B,C,D).sample(T).A !== expm(A*T)`. For a more object-oriented interface, it would also be great to have member functions like stateSpace.isControllable(), which do not make sense if the system has already been minimized.\r\n\r\nTo give an example: The autonomous system x'=0, y=x is a signal model for the constant output y=x(0). It is not equivalent to the system y=0 if you consider the initial response for x(0) !== 0.\r\n\r\n```\r\nimport control\r\nprint(control.__version__)\r\nprint(control.ss(0,0,1,0)) # expected: A,B,C,D unchanged from input\r\nprint(control.ss(0,0,1,0).sample(1)) # expected: ss(1,0,1,0, dt=1)\r\n```\r\noutput:\r\n```\r\n0.8.0\r\n\r\nA = []\r\nB = []\r\nC = []\r\nD = [[0]]\r\n\r\nA = []\r\nB = []\r\nC = []\r\nD = [[0]]\r\ndt = 1\r\n```\r\n\r\nIs there a reason for the current behavior, or would it be okay to change it?","author":{"url":"https://github.com/MaxGaukler","@type":"Person","name":"MaxGaukler"},"datePublished":"2018-11-14T10:55:53.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":8},"url":"https://github.com/244/python-control/issues/244"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:c30d0351-4b7a-7ce4-a3eb-146a4c0a2696 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8678:DA8F6:1650AE4:1D79349:697C1EF2 |
| html-safe-nonce | ae28c3f14ffb9ad493a0e8d83d976be2606d4580627eb9dbcb62469002669aa5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Njc4OkRBOEY2OjE2NTBBRTQ6MUQ3OTM0OTo2OTdDMUVGMiIsInZpc2l0b3JfaWQiOiI1MzgwNDMxNDc3ODM3NzM5MzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e3269653f1990d82133f0e3b44bc0a8bbeae31d6ffad7e4bc6503bc0bd73745a |
| hovercard-subject-tag | issue:380643422 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-control/python-control/244/issue_layout |
| twitter:image | https://opengraph.githubassets.com/57801f66750349d8f325ee4f9a2232ec7474ddf78750bf68f51ab2a7fae0bc41/python-control/python-control/issues/244 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/57801f66750349d8f325ee4f9a2232ec7474ddf78750bf68f51ab2a7fae0bc41/python-control/python-control/issues/244 |
| og:image:alt | State space representations should, in my opinion, not be reduced automatically with StateSpace._remove_useless_states(), similar to the fact that we don't call minreal() automatically. Unlike tran... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MaxGaukler |
| hostname | github.com |
| expected-hostname | github.com |
| None | da4f0ee56809799586f8ee546b27f94fe9b5893edfbf87732e82be45be013b52 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 787d8d274e314f52ce6d846c7581f9476d8dc736 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width