Title: better symmetry check test · Issue #1174 · python-control/python-control · GitHub
Open Graph Title: better symmetry check test · Issue #1174 · python-control/python-control
X Title: better symmetry check test · Issue #1174 · python-control/python-control
Description: Hi, While porting our MATLAB code to Python using the control library, we noticed that the current symmetry check: def _is_symmetric(M): M = np.atleast_2d(M) if isinstance(M[0, 0], inexact): eps = finfo(M.dtype).eps return ((M - M.T) < e...
Open Graph Description: Hi, While porting our MATLAB code to Python using the control library, we noticed that the current symmetry check: def _is_symmetric(M): M = np.atleast_2d(M) if isinstance(M[0, 0], inexact): eps = ...
X Description: Hi, While porting our MATLAB code to Python using the control library, we noticed that the current symmetry check: def _is_symmetric(M): M = np.atleast_2d(M) if isinstance(M[0, 0], inexact): eps = ...
Opengraph URL: https://github.com/python-control/python-control/issues/1174
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"better symmetry check test","articleBody":"Hi,\n\nWhile porting our MATLAB code to Python using the control library, we noticed that the current symmetry check:\n\n```\ndef _is_symmetric(M):\n M = np.atleast_2d(M)\n if isinstance(M[0, 0], inexact):\n eps = finfo(M.dtype).eps\n return ((M - M.T) \u003c eps).all()\n else:\n return (M == M.T).all()\n```\n\nhas some limitations:\n\n1. It performs elementwise comparison without using abs(), so small negative differences (e.g., from roundoff) can cause false failures. \n2. It uses a fixed eps, which is stricter than MATLAB's behavior and doesn’t scale with matrix magnitude.\n\nWould it be possible to adopt a more numerically robust check, similar to what SciPy uses?\n\n```\nfor ind, mat in enumerate((q, r)):\n if norm(mat - mat.conj().T, 1) \u003e np.spacing(norm(mat, 1)) * 100:\n raise ValueError(f\"Matrix {'qr'[ind]} should be symmetric/hermitian.\")\n```\n\nThis approach allows for small, scale-aware numerical asymmetries and works well for both real symmetric and complex Hermitian matrices.\n\nPrithvi","author":{"url":"https://github.com/dakeprithvi","@type":"Person","name":"dakeprithvi"},"datePublished":"2025-07-23T18:11:07.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":10},"url":"https://github.com/1174/python-control/issues/1174"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:cb70dc5c-1de4-0fc7-e01a-a5dae2fe7195 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 97CE:18498B:369AB77:4C6EAFE:69792CD6 |
| html-safe-nonce | 88a1249a6aa5c41244fadda00c6083dfdd81e67efd4c20fdffbe51b1e573b374 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0NFOjE4NDk4QjozNjlBQjc3OjRDNkVBRkU6Njk3OTJDRDYiLCJ2aXNpdG9yX2lkIjoiMjQ5MTQ4NDI3NTA0NDA2ODU2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f7ec0c66467bbec98e73600da64ab8b7367508063ce85cd4b0fe2dbe9b186aba |
| hovercard-subject-tag | issue:3257278186 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-control/python-control/1174/issue_layout |
| twitter:image | https://opengraph.githubassets.com/6de4140719d2161442cb5963f0b48b5be11e987e1f9841b4bf45e86d6a149797/python-control/python-control/issues/1174 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6de4140719d2161442cb5963f0b48b5be11e987e1f9841b4bf45e86d6a149797/python-control/python-control/issues/1174 |
| og:image:alt | Hi, While porting our MATLAB code to Python using the control library, we noticed that the current symmetry check: def _is_symmetric(M): M = np.atleast_2d(M) if isinstance(M[0, 0], inexact): eps = ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dakeprithvi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 15417fb272585d09f7c894f2a869ba34cc4c7ded898af9dccaa85542b9adb711 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 535f4866a7b2e3d762bd599bffe50a3cfb0702b2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width