René's URL Explorer Experiment


Title: aio: return session closing coroutine by RazAnyVision · Pull Request #276 · python-consul/python-consul · GitHub

Open Graph Title: aio: return session closing coroutine by RazAnyVision · Pull Request #276 · python-consul/python-consul

X Title: aio: return session closing coroutine by RazAnyVision · Pull Request #276 · python-consul/python-consul

Description: aio.Consul.close() uses aiohttp.ClientSession.close() which returns a coroutine that was never awaited. When this happens, RuntimeWarnings are raised on termination: RuntimeWarning: coroutine 'ClientSession.close' was never awaited self._session.close() RuntimeWarning: Enable tracemalloc to get the object allocation traceback Unclosed client session client_session: Unclosed connector connections: [] connector: In this change the coroutine will be returned so it could be awaited and by that avoids these warnings.

Open Graph Description: aio.Consul.close() uses aiohttp.ClientSession.close() which returns a coroutine that was never awaited. When this happens, RuntimeWarnings are raised on termination: RuntimeWarning: coroutine '...

X Description: aio.Consul.close() uses aiohttp.ClientSession.close() which returns a coroutine that was never awaited. When this happens, RuntimeWarnings are raised on termination: RuntimeWarning: coroutine &...

Opengraph URL: https://github.com/python-consul/python-consul/pull/276

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5742c483-29cf-a068-691a-7f0e5364d86d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC1C4:2F5E76:9E3DA:D107F:696AFC0F
html-safe-noncec1627d1f5e8c33da92f3db1ef1f1f36adb570ff8c604ffceca8a057641673ef8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUM0OjJGNUU3Njo5RTNEQTpEMTA3Rjo2OTZBRkMwRiIsInZpc2l0b3JfaWQiOiI1NTUxNTc2NjcwMTc5ODg0MDQ3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac89458a64c7ff998be7108fa5df19c26d084def312b8cef0f4a9511a6e09e87f4
hovercard-subject-tagpull_request:388084777
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-consul/python-consul/pull/276/files
twitter:imagehttps://avatars.githubusercontent.com/u/58777099?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/58777099?s=400&v=4
og:image:altaio.Consul.close() uses aiohttp.ClientSession.close() which returns a coroutine that was never awaited. When this happens, RuntimeWarnings are raised on termination: RuntimeWarning: coroutine '...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-consul/python-consul git https://github.com/python-consul/python-consul.git
octolytics-dimension-user_id143416393
octolytics-dimension-user_loginpython-consul
octolytics-dimension-repository_id24473148
octolytics-dimension-repository_nwopython-consul/python-consul
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24473148
octolytics-dimension-repository_network_root_nwopython-consul/python-consul
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-consul/python-consul/pull/276/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-consul%2Fpython-consul%2Fpull%2F276%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-consul%2Fpython-consul%2Fpull%2F276%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-consul%2Fpython-consul
Reloadhttps://github.com/python-consul/python-consul/pull/276/files
Reloadhttps://github.com/python-consul/python-consul/pull/276/files
Reloadhttps://github.com/python-consul/python-consul/pull/276/files
python-consul https://github.com/python-consul
python-consulhttps://github.com/python-consul/python-consul
Notifications https://github.com/login?return_to=%2Fpython-consul%2Fpython-consul
Fork 218 https://github.com/login?return_to=%2Fpython-consul%2Fpython-consul
Star 460 https://github.com/login?return_to=%2Fpython-consul%2Fpython-consul
Code https://github.com/python-consul/python-consul
Issues 60 https://github.com/python-consul/python-consul/issues
Pull requests 30 https://github.com/python-consul/python-consul/pulls
Actions https://github.com/python-consul/python-consul/actions
Projects 0 https://github.com/python-consul/python-consul/projects
Wiki https://github.com/python-consul/python-consul/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python-consul/python-consul/security
Please reload this pagehttps://github.com/python-consul/python-consul/pull/276/files
Insights https://github.com/python-consul/python-consul/pulse
Code https://github.com/python-consul/python-consul
Issues https://github.com/python-consul/python-consul/issues
Pull requests https://github.com/python-consul/python-consul/pulls
Actions https://github.com/python-consul/python-consul/actions
Projects https://github.com/python-consul/python-consul/projects
Wiki https://github.com/python-consul/python-consul/wiki
Security https://github.com/python-consul/python-consul/security
Insights https://github.com/python-consul/python-consul/pulse
RazAnyVisionhttps://github.com/RazAnyVision
python-consul:masterhttps://github.com/python-consul/python-consul/tree/master
RazAnyVision:aio-wait-for-session-closehttps://github.com/RazAnyVision/python-consul/tree/aio-wait-for-session-close
Conversation 1 https://github.com/python-consul/python-consul/pull/276
Commits 2 https://github.com/python-consul/python-consul/pull/276/commits
Checks 0 https://github.com/python-consul/python-consul/pull/276/checks
Files changed https://github.com/python-consul/python-consul/pull/276/files
Please reload this pagehttps://github.com/python-consul/python-consul/pull/276/files
aio: return session closing coroutine https://github.com/python-consul/python-consul/pull/276/files#top
Show all changes 2 commits https://github.com/python-consul/python-consul/pull/276/files
35fe05e aio: allow waiting for aiohttp.ClientSession.close() coroutine RazAnyVision Mar 14, 2020 https://github.com/python-consul/python-consul/pull/276/commits/35fe05ed1db42860dc480de47d618da7066dceea
709bda2 aio: updated tests to wait for close() coroutine to complete RazAnyVision Mar 14, 2020 https://github.com/python-consul/python-consul/pull/276/commits/709bda2a9207ff93410c73a84a9e1f2397da4ae1
Clear filters https://github.com/python-consul/python-consul/pull/276/files
Please reload this pagehttps://github.com/python-consul/python-consul/pull/276/files
Please reload this pagehttps://github.com/python-consul/python-consul/pull/276/files
aio.py https://github.com/python-consul/python-consul/pull/276/files#diff-2c1a3be98d45506c4de7f5aea36c66720d7c695758d5be70eaacc7c0023e16f7
test_aio.py https://github.com/python-consul/python-consul/pull/276/files#diff-614def4a76e1cf37e5de137c397dc920548ca7560707013fc38f3aea84603652
consul/aio.pyhttps://github.com/python-consul/python-consul/pull/276/files#diff-2c1a3be98d45506c4de7f5aea36c66720d7c695758d5be70eaacc7c0023e16f7
View file https://github.com/python-consul/python-consul/blob/709bda2a9207ff93410c73a84a9e1f2397da4ae1/consul/aio.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-consul/python-consul/pull/276/{{ revealButtonHref }}
https://github.com/python-consul/python-consul/pull/276/files#diff-2c1a3be98d45506c4de7f5aea36c66720d7c695758d5be70eaacc7c0023e16f7
https://github.com/python-consul/python-consul/pull/276/files#diff-2c1a3be98d45506c4de7f5aea36c66720d7c695758d5be70eaacc7c0023e16f7
https://github.com/python-consul/python-consul/pull/276/files#diff-2c1a3be98d45506c4de7f5aea36c66720d7c695758d5be70eaacc7c0023e16f7
tests/test_aio.pyhttps://github.com/python-consul/python-consul/pull/276/files#diff-614def4a76e1cf37e5de137c397dc920548ca7560707013fc38f3aea84603652
View file https://github.com/python-consul/python-consul/blob/709bda2a9207ff93410c73a84a9e1f2397da4ae1/tests/test_aio.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-consul/python-consul/pull/276/{{ revealButtonHref }}
https://github.com/python-consul/python-consul/pull/276/files#diff-614def4a76e1cf37e5de137c397dc920548ca7560707013fc38f3aea84603652
https://github.com/python-consul/python-consul/pull/276/files#diff-614def4a76e1cf37e5de137c397dc920548ca7560707013fc38f3aea84603652
https://github.com/python-consul/python-consul/pull/276/files#diff-614def4a76e1cf37e5de137c397dc920548ca7560707013fc38f3aea84603652
https://github.com/python-consul/python-consul/pull/276/files#diff-614def4a76e1cf37e5de137c397dc920548ca7560707013fc38f3aea84603652
https://github.com/python-consul/python-consul/pull/276/files#diff-614def4a76e1cf37e5de137c397dc920548ca7560707013fc38f3aea84603652
https://github.com/python-consul/python-consul/pull/276/files#diff-614def4a76e1cf37e5de137c397dc920548ca7560707013fc38f3aea84603652
https://github.com/python-consul/python-consul/pull/276/files#diff-614def4a76e1cf37e5de137c397dc920548ca7560707013fc38f3aea84603652
https://github.com/python-consul/python-consul/pull/276/files#diff-614def4a76e1cf37e5de137c397dc920548ca7560707013fc38f3aea84603652
https://github.com/python-consul/python-consul/pull/276/files#diff-614def4a76e1cf37e5de137c397dc920548ca7560707013fc38f3aea84603652
https://github.com/python-consul/python-consul/pull/276/files#diff-614def4a76e1cf37e5de137c397dc920548ca7560707013fc38f3aea84603652
https://github.com/python-consul/python-consul/pull/276/files#diff-614def4a76e1cf37e5de137c397dc920548ca7560707013fc38f3aea84603652
https://github.com/python-consul/python-consul/pull/276/files#diff-614def4a76e1cf37e5de137c397dc920548ca7560707013fc38f3aea84603652
https://github.com/python-consul/python-consul/pull/276/files#diff-614def4a76e1cf37e5de137c397dc920548ca7560707013fc38f3aea84603652
https://github.com/python-consul/python-consul/pull/276/files#diff-614def4a76e1cf37e5de137c397dc920548ca7560707013fc38f3aea84603652
https://github.com/python-consul/python-consul/pull/276/files#diff-614def4a76e1cf37e5de137c397dc920548ca7560707013fc38f3aea84603652
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.