René's URL Explorer Experiment


Title: FIX: #226 Allows aiohttp.client.ClientSession.close() to be awaited by ashwini-balnaves · Pull Request #231 · python-consul/python-consul · GitHub

Open Graph Title: FIX: #226 Allows aiohttp.client.ClientSession.close() to be awaited by ashwini-balnaves · Pull Request #231 · python-consul/python-consul

X Title: FIX: #226 Allows aiohttp.client.ClientSession.close() to be awaited by ashwini-balnaves · Pull Request #231 · python-consul/python-consul

Description: Resolves #226. Note that this change requires the client code to await (yield from) the Consul.close method. This is how all the other methods work (get, put, delete, etc).

Open Graph Description: Resolves #226. Note that this change requires the client code to await (yield from) the Consul.close method. This is how all the other methods work (get, put, delete, etc).

X Description: Resolves #226. Note that this change requires the client code to await (yield from) the Consul.close method. This is how all the other methods work (get, put, delete, etc).

Opengraph URL: https://github.com/python-consul/python-consul/pull/231

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:01c23425-d033-8b29-40a6-755495c71b9c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDA5C:37CCD2:18A75FB:20EF12F:696AED7E
html-safe-nonce157c9c73ea7f8562623b47c32cc47aa962822ec449bf8463364772066b73147a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTVDOjM3Q0NEMjoxOEE3NUZCOjIwRUYxMkY6Njk2QUVEN0UiLCJ2aXNpdG9yX2lkIjoiNDg4MDQzMjM1NDUxODgyMjI3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4a04bbcbf4c03258cd109edd05e2ffeed7cc94056fd7e00a1080abe68038916a
hovercard-subject-tagpull_request:209709706
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-consul/python-consul/231/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/35f79429985813deec50f306d1918624e24578655835485b6294fbe4cb77388c/python-consul/python-consul/pull/231
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/35f79429985813deec50f306d1918624e24578655835485b6294fbe4cb77388c/python-consul/python-consul/pull/231
og:image:altResolves #226. Note that this change requires the client code to await (yield from) the Consul.close method. This is how all the other methods work (get, put, delete, etc).
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameashwini-balnaves
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python-consul/python-consul git https://github.com/python-consul/python-consul.git
octolytics-dimension-user_id143416393
octolytics-dimension-user_loginpython-consul
octolytics-dimension-repository_id24473148
octolytics-dimension-repository_nwopython-consul/python-consul
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24473148
octolytics-dimension-repository_network_root_nwopython-consul/python-consul
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-consul/python-consul/pull/231#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-consul%2Fpython-consul%2Fpull%2F231
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-consul%2Fpython-consul%2Fpull%2F231
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-consul%2Fpython-consul
Reloadhttps://github.com/python-consul/python-consul/pull/231
Reloadhttps://github.com/python-consul/python-consul/pull/231
Reloadhttps://github.com/python-consul/python-consul/pull/231
python-consul https://github.com/python-consul
python-consulhttps://github.com/python-consul/python-consul
Notifications https://github.com/login?return_to=%2Fpython-consul%2Fpython-consul
Fork 218 https://github.com/login?return_to=%2Fpython-consul%2Fpython-consul
Star 460 https://github.com/login?return_to=%2Fpython-consul%2Fpython-consul
Code https://github.com/python-consul/python-consul
Issues 60 https://github.com/python-consul/python-consul/issues
Pull requests 30 https://github.com/python-consul/python-consul/pulls
Actions https://github.com/python-consul/python-consul/actions
Projects 0 https://github.com/python-consul/python-consul/projects
Wiki https://github.com/python-consul/python-consul/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python-consul/python-consul/security
Please reload this pagehttps://github.com/python-consul/python-consul/pull/231
Insights https://github.com/python-consul/python-consul/pulse
Code https://github.com/python-consul/python-consul
Issues https://github.com/python-consul/python-consul/issues
Pull requests https://github.com/python-consul/python-consul/pulls
Actions https://github.com/python-consul/python-consul/actions
Projects https://github.com/python-consul/python-consul/projects
Wiki https://github.com/python-consul/python-consul/wiki
Security https://github.com/python-consul/python-consul/security
Insights https://github.com/python-consul/python-consul/pulse
ashwini-balnaveshttps://github.com/ashwini-balnaves
python-consul:masterhttps://github.com/python-consul/python-consul/tree/master
ashwini-balnaves:issue-226https://github.com/ashwini-balnaves/python-consul/tree/issue-226
FIX: #226 Allows aiohttp.client.ClientSession.close() to be awaited https://github.com/python-consul/python-consul/pull/231#top
ashwini-balnaveshttps://github.com/ashwini-balnaves
python-consul:masterhttps://github.com/python-consul/python-consul/tree/master
ashwini-balnaves:issue-226https://github.com/ashwini-balnaves/python-consul/tree/issue-226
Conversation 8 https://github.com/python-consul/python-consul/pull/231
Commits 1 https://github.com/python-consul/python-consul/pull/231/commits
Checks 0 https://github.com/python-consul/python-consul/pull/231/checks
Files changed https://github.com/python-consul/python-consul/pull/231/files
Please reload this pagehttps://github.com/python-consul/python-consul/pull/231
https://github.co/hiddenchars
https://github.com/python-consul/python-consul/pull/{{ revealButtonHref }}
https://github.com/ashwini-balnaves
ashwini-balnaveshttps://github.com/ashwini-balnaves
Aug 21, 2018https://github.com/python-consul/python-consul/pull/231#issue-352387342
Please reload this pagehttps://github.com/python-consul/python-consul/pull/231
#226https://github.com/python-consul/python-consul/issues/226
Please reload this pagehttps://github.com/python-consul/python-consul/pull/231
https://github.com/ashwini-balnaves
ashwini-balnaveshttps://github.com/ashwini-balnaves
Aug 21, 2018 https://github.com/python-consul/python-consul/pull/231#ref-issue-350234306
ClientSession.close is a coroutine #226 https://github.com/python-consul/python-consul/issues/226
https://github.com/ashwini-balnaves
ashwini-balnaveshttps://github.com/ashwini-balnaves
Aug 21, 2018https://github.com/python-consul/python-consul/pull/231#event-1799250152
https://github.com/ashwini-balnaves
Allows aiohttp.client.ClientSession.close() to be awaitedhttps://github.com/python-consul/python-consul/pull/231/commits/711d64d0c66d06be47ce9219a6e057414dd74b54
711d64dhttps://github.com/python-consul/python-consul/pull/231/commits/711d64d0c66d06be47ce9219a6e057414dd74b54
https://github.com/ashwini-balnaves
ashwini-balnaveshttps://github.com/ashwini-balnaves
force-pushedhttps://github.com/python-consul/python-consul/compare/ba3f811f47cab58b4a38d6b76cb1353c6d1381a9..711d64d0c66d06be47ce9219a6e057414dd74b54
ba3f811https://github.com/python-consul/python-consul/commit/ba3f811f47cab58b4a38d6b76cb1353c6d1381a9
711d64dhttps://github.com/python-consul/python-consul/commit/711d64d0c66d06be47ce9219a6e057414dd74b54
Compare https://github.com/python-consul/python-consul/compare/ba3f811f47cab58b4a38d6b76cb1353c6d1381a9..711d64d0c66d06be47ce9219a6e057414dd74b54
August 21, 2018 05:28https://github.com/python-consul/python-consul/pull/231#event-1799257984
https://github.com/wdauchy
wdauchyhttps://github.com/wdauchy
Oct 2, 2018https://github.com/python-consul/python-consul/pull/231#issuecomment-426270820
@matusvalohttps://github.com/matusvalo
Please reload this pagehttps://github.com/python-consul/python-consul/pull/231
https://github.com/Pavkazzz
Pavkazzzhttps://github.com/Pavkazzz
Oct 5, 2018https://github.com/python-consul/python-consul/pull/231#issuecomment-427393916
Please reload this pagehttps://github.com/python-consul/python-consul/pull/231
https://github.com/mosquito
mosquitohttps://github.com/mosquito
Oct 8, 2018 https://github.com/python-consul/python-consul/pull/231#ref-pullrequest-367902852
fixes #226 #239 https://github.com/python-consul/python-consul/pull/239
https://github.com/habibutsu
habibutsuhttps://github.com/habibutsu
Oct 16, 2018https://github.com/python-consul/python-consul/pull/231#issuecomment-430309146
@cableheadhttps://github.com/cablehead
Please reload this pagehttps://github.com/python-consul/python-consul/pull/231
https://github.com/harobed
harobedhttps://github.com/harobed
Feb 3, 2019https://github.com/python-consul/python-consul/pull/231#issuecomment-460060687
@cableheadhttps://github.com/cablehead
Please reload this pagehttps://github.com/python-consul/python-consul/pull/231
nzloshhttps://github.com/nzlosh
May 28, 2019 https://github.com/python-consul/python-consul/pull/231#ref-commit-493ae78
https://github.com/nzlosh
Merge patch from ashwini-balnaveshttps://github.com/nzlosh/python-consul/commit/493ae787088bd7ca10bd2539a28820379a7b8606
python-consul#231https://github.com/python-consul/python-consul/pull/231
493ae78https://github.com/nzlosh/python-consul/commit/493ae787088bd7ca10bd2539a28820379a7b8606
https://github.com/icaropires
icaropireshttps://github.com/icaropires
Jul 23, 2019https://github.com/python-consul/python-consul/pull/231#issuecomment-514265514
Please reload this pagehttps://github.com/python-consul/python-consul/pull/231
https://github.com/ashwini-balnaves
ashwini-balnaveshttps://github.com/ashwini-balnaves
Aug 20, 2019 https://github.com/python-consul/python-consul/pull/231#ref-pullrequest-463592101
Throughput results updated jupyterhub/traefik-proxy#62 https://github.com/jupyterhub/traefik-proxy/pull/62
https://github.com/habibutsu
habibutsuhttps://github.com/habibutsu
Sep 5, 2019https://github.com/python-consul/python-consul/pull/231#issuecomment-528296068
@matusvalohttps://github.com/matusvalo
@abnhttps://github.com/abn
@cableheadhttps://github.com/cablehead
Please reload this pagehttps://github.com/python-consul/python-consul/pull/231
https://github.com/habibutsu
habibutsuhttps://github.com/habibutsu
Sep 5, 2019https://github.com/python-consul/python-consul/pull/231#issuecomment-528481132
https://pypi.org/project/habibutsu.python-consul/1.2.0/https://pypi.org/project/habibutsu.python-consul/1.2.0/
Please reload this pagehttps://github.com/python-consul/python-consul/pull/231
https://github.com/sheshtawy
sheshtawyhttps://github.com/sheshtawy
Mar 17, 2020https://github.com/python-consul/python-consul/pull/231#issuecomment-599815195
Please reload this pagehttps://github.com/python-consul/python-consul/pull/231
Please reload this pagehttps://github.com/python-consul/python-consul/pull/231
https://github.com/cablehead
cableheadhttps://github.com/cablehead
force-pushedhttps://github.com/python-consul/python-consul/compare/636f367ac14ba8ce58d77fd3053d4bffc81d7ec9..a91daae20c72625e764c10b5a98010df6b442238
636f367https://github.com/python-consul/python-consul/commit/636f367ac14ba8ce58d77fd3053d4bffc81d7ec9
a91daaehttps://github.com/python-consul/python-consul/commit/a91daae20c72625e764c10b5a98010df6b442238
Compare https://github.com/python-consul/python-consul/compare/636f367ac14ba8ce58d77fd3053d4bffc81d7ec9..a91daae20c72625e764c10b5a98010df6b442238
April 15, 2024 01:28https://github.com/python-consul/python-consul/pull/231#event-12461921534
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-consul%2Fpython-consul%2Fpull%2F231
ClientSession.close is a coroutine https://github.com/python-consul/python-consul/issues/226
Please reload this pagehttps://github.com/python-consul/python-consul/pull/231
https://github.com/ashwini-balnaves
https://github.com/wdauchy
https://github.com/Pavkazzz
https://github.com/habibutsu
https://github.com/harobed
https://github.com/icaropires
https://github.com/sheshtawy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.