René's URL Explorer Experiment


Title: RFC: Implement support for connecting to consul via unix socket by asteven · Pull Request #217 · python-consul/python-consul · GitHub

Open Graph Title: RFC: Implement support for connecting to consul via unix socket by asteven · Pull Request #217 · python-consul/python-consul

X Title: RFC: Implement support for connecting to consul via unix socket by asteven · Pull Request #217 · python-consul/python-consul

Description: Basically I need python-consul to work with this: # env | grep CONSUL_HTTP_ADDR CONSUL_HTTP_ADDR=unix:///var/run/consul/http.sock Just like the consul cli does. Unfortunately I had to change a lot of code to make this work :-( Basically the uri (unix:///var/run/consul/http.sock) has to be passed to all the different implementations like std, aio, tornado as they all handle this type of connection differently. I implemented the feature for all the backends I'm familiar with std and aio but not tornado and twisted. I also removed the default environment variables support in base.py for 2 reasons: The existing implementation interfered with the feature I wanted to implement. I strongly believe a environment variable should never override an explicitly defined argument. To fully support configuring a client through environment variables I added a explicit helper function similar to how the docker-py project implements it. c = consul.Consul.from_env()

Open Graph Description: Basically I need python-consul to work with this: # env | grep CONSUL_HTTP_ADDR CONSUL_HTTP_ADDR=unix:///var/run/consul/http.sock Just like the consul cli does. Unfortunately I had to change a lot ...

X Description: Basically I need python-consul to work with this: # env | grep CONSUL_HTTP_ADDR CONSUL_HTTP_ADDR=unix:///var/run/consul/http.sock Just like the consul cli does. Unfortunately I had to change a lot ...

Opengraph URL: https://github.com/python-consul/python-consul/pull/217

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1bd0b6a1-3e40-3ae8-375c-dfd73bf298c0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB114:258BE8:B05BA0:EDF3E8:696ABDE2
html-safe-noncef4ef7fdcd769956cc7e8e64f5fdf187e981960b952a88733835016a6f41f577d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTE0OjI1OEJFODpCMDVCQTA6RURGM0U4OjY5NkFCREUyIiwidmlzaXRvcl9pZCI6IjI5NjIzMzA5NzQwODQwNTQ0OTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6e918a8b79aeab5a371b388c44a91f2d020f9e5293127a94bb5dc94d5e79a2d3
hovercard-subject-tagpull_request:198444336
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-consul/python-consul/pull/217/files
twitter:imagehttps://avatars.githubusercontent.com/u/684915?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/684915?s=400&v=4
og:image:altBasically I need python-consul to work with this: # env | grep CONSUL_HTTP_ADDR CONSUL_HTTP_ADDR=unix:///var/run/consul/http.sock Just like the consul cli does. Unfortunately I had to change a lot ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-consul/python-consul git https://github.com/python-consul/python-consul.git
octolytics-dimension-user_id143416393
octolytics-dimension-user_loginpython-consul
octolytics-dimension-repository_id24473148
octolytics-dimension-repository_nwopython-consul/python-consul
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24473148
octolytics-dimension-repository_network_root_nwopython-consul/python-consul
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-consul/python-consul/pull/217/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-consul%2Fpython-consul%2Fpull%2F217%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-consul%2Fpython-consul%2Fpull%2F217%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-consul%2Fpython-consul
Reloadhttps://github.com/python-consul/python-consul/pull/217/files
Reloadhttps://github.com/python-consul/python-consul/pull/217/files
Reloadhttps://github.com/python-consul/python-consul/pull/217/files
python-consul https://github.com/python-consul
python-consulhttps://github.com/python-consul/python-consul
Notifications https://github.com/login?return_to=%2Fpython-consul%2Fpython-consul
Fork 218 https://github.com/login?return_to=%2Fpython-consul%2Fpython-consul
Star 460 https://github.com/login?return_to=%2Fpython-consul%2Fpython-consul
Code https://github.com/python-consul/python-consul
Issues 60 https://github.com/python-consul/python-consul/issues
Pull requests 30 https://github.com/python-consul/python-consul/pulls
Actions https://github.com/python-consul/python-consul/actions
Projects 0 https://github.com/python-consul/python-consul/projects
Wiki https://github.com/python-consul/python-consul/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python-consul/python-consul/security
Please reload this pagehttps://github.com/python-consul/python-consul/pull/217/files
Insights https://github.com/python-consul/python-consul/pulse
Code https://github.com/python-consul/python-consul
Issues https://github.com/python-consul/python-consul/issues
Pull requests https://github.com/python-consul/python-consul/pulls
Actions https://github.com/python-consul/python-consul/actions
Projects https://github.com/python-consul/python-consul/projects
Wiki https://github.com/python-consul/python-consul/wiki
Security https://github.com/python-consul/python-consul/security
Insights https://github.com/python-consul/python-consul/pulse
astevenhttps://github.com/asteven
python-consul:masterhttps://github.com/python-consul/python-consul/tree/master
asteven:unix-sockethttps://github.com/asteven/python-consul/tree/unix-socket
Conversation 15 https://github.com/python-consul/python-consul/pull/217
Commits 15 https://github.com/python-consul/python-consul/pull/217/commits
Checks 0 https://github.com/python-consul/python-consul/pull/217/checks
Files changed https://github.com/python-consul/python-consul/pull/217/files
Please reload this pagehttps://github.com/python-consul/python-consul/pull/217/files
RFC: Implement support for connecting to consul via unix socket https://github.com/python-consul/python-consul/pull/217/files#top
Show all changes 15 commits https://github.com/python-consul/python-consul/pull/217/files
7c91dee implement support for unix:// address asteven Jun 29, 2018 https://github.com/python-consul/python-consul/pull/217/commits/7c91dee42575b1203a935e5e81c72cf6ddaeab38
fba532a add example for from_env() asteven Jun 29, 2018 https://github.com/python-consul/python-consul/pull/217/commits/fba532a430264b0287f27854e352e99e5b510a1f
11558b1 add link to consul env vars asteven Jun 29, 2018 https://github.com/python-consul/python-consul/pull/217/commits/11558b17f19a316107f25ebbe090337d9ced9225
9965d4a properly format link asteven Jun 29, 2018 https://github.com/python-consul/python-consul/pull/217/commits/9965d4af1e49e7347a531c746e93fd499aff9409
88b1ced remove initial legacy env handling of verify asteven Jun 29, 2018 https://github.com/python-consul/python-consul/pull/217/commits/88b1ced42a079184148bf44b4edcca77199e2b42
e843148 qualified name for exception asteven Jun 29, 2018 https://github.com/python-consul/python-consul/pull/217/commits/e843148927dc865edd3bce771bc73b970df14a45
c1f0bf0 python 2.6 support asteven Jun 29, 2018 https://github.com/python-consul/python-consul/pull/217/commits/c1f0bf0ae84b4865f7e4190c5faaba9fc8c91017
59f5fc0 fix flake8 tests for python 3.5 asteven Jul 2, 2018 https://github.com/python-consul/python-consul/pull/217/commits/59f5fc0e3b7b4a95f84c4cdfe62cc273efdba1a8
93831cb start refactoring tests for parametrization of consul client asteven Jul 5, 2018 https://github.com/python-consul/python-consul/pull/217/commits/93831cb2c7ae95fb09a071c584f2d300652da65b
9ae3b20 fix flake8 E712 test failures for boolean comparison asteven Jul 5, 2018 https://github.com/python-consul/python-consul/pull/217/commits/9ae3b20ef79a8dd44c3864f056fdb06e16365606
b8beff2 fix flake8 E265: remove commented/unused code asteven Jul 5, 2018 https://github.com/python-consul/python-consul/pull/217/commits/b8beff2d6ee63545f2ed1e2f9258ac7145677fb7
9287fe7 fix flake8 E128 and E501 asteven Jul 5, 2018 https://github.com/python-consul/python-consul/pull/217/commits/9287fe75e2cfe097419178a01b11abb61bb4ea55
905b598 add tests for CONSUL_HTTP_ADDR with and without scheme and CONSUL_HTT… asteven Jul 10, 2018 https://github.com/python-consul/python-consul/pull/217/commits/905b59834e142c8cda9779c2d57c88df37ee5c65
84d73ca ensure CONSUL_HTTP_ADDR starts with a scheme, either http or https if… asteven Jul 10, 2018 https://github.com/python-consul/python-consul/pull/217/commits/84d73ca8d4dd7db2f2a6e6bee155c719b7b35927
a23c4d8 fix flake8 E225 asteven Jul 10, 2018 https://github.com/python-consul/python-consul/pull/217/commits/a23c4d82630d0ccdaa84375d5bc64a761f27acf0
Clear filters https://github.com/python-consul/python-consul/pull/217/files
Please reload this pagehttps://github.com/python-consul/python-consul/pull/217/files
Please reload this pagehttps://github.com/python-consul/python-consul/pull/217/files
README.rst https://github.com/python-consul/python-consul/pull/217/files#diff-7b3ed02bc73dc06b7db906cf97aa91dec2b2eb21f2d92bc5caa761df5bbc168f
aio.py https://github.com/python-consul/python-consul/pull/217/files#diff-2c1a3be98d45506c4de7f5aea36c66720d7c695758d5be70eaacc7c0023e16f7
base.py https://github.com/python-consul/python-consul/pull/217/files#diff-87d94b41a52bb393bfca3dc4b47be3807560585a919ef66394f9fe6e20c216c2
std.py https://github.com/python-consul/python-consul/pull/217/files#diff-6664aaaaee63c4555a36fd9fe81400f885dd7fe3189fbbd923ffe4ef91790636
tornado.py https://github.com/python-consul/python-consul/pull/217/files#diff-56c22625803544057cd4721ae67bf6a1a6feb3bb0dfabdfe171fbf8fe21f0ee4
twisted.py https://github.com/python-consul/python-consul/pull/217/files#diff-434a8b85bc9f9a363a162e17c7fb037c67ed224753e279c98203c47eeee287f6
requirements.txt https://github.com/python-consul/python-consul/pull/217/files#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552
test_aio.py https://github.com/python-consul/python-consul/pull/217/files#diff-614def4a76e1cf37e5de137c397dc920548ca7560707013fc38f3aea84603652
test_base.py https://github.com/python-consul/python-consul/pull/217/files#diff-9d6c961a9df09671b4f476b17891ccefaca2c9893fdbdb7c570cb2c4ffd43382
test_std.py https://github.com/python-consul/python-consul/pull/217/files#diff-d7a282dfdb11bb72904bb825391807eead6de013e18086be54184a2764e4bbbf
test_tornado.py https://github.com/python-consul/python-consul/pull/217/files#diff-342d9df0d29d89fef9e9376f386c1a994cb9bb567234cd61acdc9c764327c905
test_twisted.py https://github.com/python-consul/python-consul/pull/217/files#diff-673441c4b6dbee451d8130f1e9bb48f3dbc44d5d3acf1c21d52d0904002342d5
README.rsthttps://github.com/python-consul/python-consul/pull/217/files#diff-7b3ed02bc73dc06b7db906cf97aa91dec2b2eb21f2d92bc5caa761df5bbc168f
View file https://github.com/python-consul/python-consul/blob/a23c4d82630d0ccdaa84375d5bc64a761f27acf0/README.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-consul/python-consul/pull/217/{{ revealButtonHref }}
https://github.com/python-consul/python-consul/pull/217/files#diff-7b3ed02bc73dc06b7db906cf97aa91dec2b2eb21f2d92bc5caa761df5bbc168f
https://github.com/python-consul/python-consul/pull/217/files#diff-7b3ed02bc73dc06b7db906cf97aa91dec2b2eb21f2d92bc5caa761df5bbc168f
https://github.com/python-consul/python-consul/pull/217/files#diff-7b3ed02bc73dc06b7db906cf97aa91dec2b2eb21f2d92bc5caa761df5bbc168f
consul/aio.pyhttps://github.com/python-consul/python-consul/pull/217/files#diff-2c1a3be98d45506c4de7f5aea36c66720d7c695758d5be70eaacc7c0023e16f7
View file https://github.com/python-consul/python-consul/blob/a23c4d82630d0ccdaa84375d5bc64a761f27acf0/consul/aio.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-consul/python-consul/pull/217/{{ revealButtonHref }}
https://github.com/python-consul/python-consul/pull/217/files#diff-2c1a3be98d45506c4de7f5aea36c66720d7c695758d5be70eaacc7c0023e16f7
https://github.com/python-consul/python-consul/pull/217/files#diff-2c1a3be98d45506c4de7f5aea36c66720d7c695758d5be70eaacc7c0023e16f7
https://github.com/python-consul/python-consul/pull/217/files#diff-2c1a3be98d45506c4de7f5aea36c66720d7c695758d5be70eaacc7c0023e16f7
https://github.com/python-consul/python-consul/pull/217/files#diff-2c1a3be98d45506c4de7f5aea36c66720d7c695758d5be70eaacc7c0023e16f7
https://github.com/python-consul/python-consul/pull/217/files#diff-2c1a3be98d45506c4de7f5aea36c66720d7c695758d5be70eaacc7c0023e16f7
consul/base.pyhttps://github.com/python-consul/python-consul/pull/217/files#diff-87d94b41a52bb393bfca3dc4b47be3807560585a919ef66394f9fe6e20c216c2
View file https://github.com/python-consul/python-consul/blob/a23c4d82630d0ccdaa84375d5bc64a761f27acf0/consul/base.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-consul/python-consul/pull/217/{{ revealButtonHref }}
https://github.com/python-consul/python-consul/pull/217/files#diff-87d94b41a52bb393bfca3dc4b47be3807560585a919ef66394f9fe6e20c216c2
https://github.com/python-consul/python-consul/pull/217/files#diff-87d94b41a52bb393bfca3dc4b47be3807560585a919ef66394f9fe6e20c216c2
https://github.com/python-consul/python-consul/pull/217/files#diff-87d94b41a52bb393bfca3dc4b47be3807560585a919ef66394f9fe6e20c216c2
https://github.com/python-consul/python-consul/pull/217/files#diff-87d94b41a52bb393bfca3dc4b47be3807560585a919ef66394f9fe6e20c216c2
https://github.com/python-consul/python-consul/pull/217/files#diff-87d94b41a52bb393bfca3dc4b47be3807560585a919ef66394f9fe6e20c216c2
https://github.com/python-consul/python-consul/pull/217/files#diff-87d94b41a52bb393bfca3dc4b47be3807560585a919ef66394f9fe6e20c216c2
consul/std.pyhttps://github.com/python-consul/python-consul/pull/217/files#diff-6664aaaaee63c4555a36fd9fe81400f885dd7fe3189fbbd923ffe4ef91790636
View file https://github.com/python-consul/python-consul/blob/a23c4d82630d0ccdaa84375d5bc64a761f27acf0/consul/std.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-consul/python-consul/pull/217/{{ revealButtonHref }}
https://github.com/python-consul/python-consul/pull/217/files#diff-6664aaaaee63c4555a36fd9fe81400f885dd7fe3189fbbd923ffe4ef91790636
https://github.com/python-consul/python-consul/pull/217/files#diff-6664aaaaee63c4555a36fd9fe81400f885dd7fe3189fbbd923ffe4ef91790636
https://github.com/python-consul/python-consul/pull/217/files#diff-6664aaaaee63c4555a36fd9fe81400f885dd7fe3189fbbd923ffe4ef91790636
consul/tornado.pyhttps://github.com/python-consul/python-consul/pull/217/files#diff-56c22625803544057cd4721ae67bf6a1a6feb3bb0dfabdfe171fbf8fe21f0ee4
View file https://github.com/python-consul/python-consul/blob/a23c4d82630d0ccdaa84375d5bc64a761f27acf0/consul/tornado.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-consul/python-consul/pull/217/{{ revealButtonHref }}
https://github.com/python-consul/python-consul/pull/217/files#diff-56c22625803544057cd4721ae67bf6a1a6feb3bb0dfabdfe171fbf8fe21f0ee4
https://github.com/python-consul/python-consul/pull/217/files#diff-56c22625803544057cd4721ae67bf6a1a6feb3bb0dfabdfe171fbf8fe21f0ee4
https://github.com/python-consul/python-consul/pull/217/files#diff-56c22625803544057cd4721ae67bf6a1a6feb3bb0dfabdfe171fbf8fe21f0ee4
consul/twisted.pyhttps://github.com/python-consul/python-consul/pull/217/files#diff-434a8b85bc9f9a363a162e17c7fb037c67ed224753e279c98203c47eeee287f6
View file https://github.com/python-consul/python-consul/blob/a23c4d82630d0ccdaa84375d5bc64a761f27acf0/consul/twisted.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-consul/python-consul/pull/217/{{ revealButtonHref }}
https://github.com/python-consul/python-consul/pull/217/files#diff-434a8b85bc9f9a363a162e17c7fb037c67ed224753e279c98203c47eeee287f6
https://github.com/python-consul/python-consul/pull/217/files#diff-434a8b85bc9f9a363a162e17c7fb037c67ed224753e279c98203c47eeee287f6
https://github.com/python-consul/python-consul/pull/217/files#diff-434a8b85bc9f9a363a162e17c7fb037c67ed224753e279c98203c47eeee287f6
requirements.txthttps://github.com/python-consul/python-consul/pull/217/files#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552
View file https://github.com/python-consul/python-consul/blob/a23c4d82630d0ccdaa84375d5bc64a761f27acf0/requirements.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-consul/python-consul/pull/217/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python-consul/python-consul/pull/217/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.