Title: RFC: Implement support for connecting to consul via unix socket by asteven · Pull Request #217 · python-consul/python-consul · GitHub
Open Graph Title: RFC: Implement support for connecting to consul via unix socket by asteven · Pull Request #217 · python-consul/python-consul
X Title: RFC: Implement support for connecting to consul via unix socket by asteven · Pull Request #217 · python-consul/python-consul
Description: Basically I need python-consul to work with this: # env | grep CONSUL_HTTP_ADDR CONSUL_HTTP_ADDR=unix:///var/run/consul/http.sock Just like the consul cli does. Unfortunately I had to change a lot of code to make this work :-( Basically the uri (unix:///var/run/consul/http.sock) has to be passed to all the different implementations like std, aio, tornado as they all handle this type of connection differently. I implemented the feature for all the backends I'm familiar with std and aio but not tornado and twisted. I also removed the default environment variables support in base.py for 2 reasons: The existing implementation interfered with the feature I wanted to implement. I strongly believe a environment variable should never override an explicitly defined argument. To fully support configuring a client through environment variables I added a explicit helper function similar to how the docker-py project implements it. c = consul.Consul.from_env()
Open Graph Description: Basically I need python-consul to work with this: # env | grep CONSUL_HTTP_ADDR CONSUL_HTTP_ADDR=unix:///var/run/consul/http.sock Just like the consul cli does. Unfortunately I had to change a lot ...
X Description: Basically I need python-consul to work with this: # env | grep CONSUL_HTTP_ADDR CONSUL_HTTP_ADDR=unix:///var/run/consul/http.sock Just like the consul cli does. Unfortunately I had to change a lot ...
Opengraph URL: https://github.com/python-consul/python-consul/pull/217
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:da11d933-9d8a-e0d3-764b-f6faf25503fe |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | A9D6:30E6E5:1C625DB:26CDBE5:696ABDAA |
| html-safe-nonce | fcf20f19a6f1e92ad0d8f55086ac1fef601587177c97dba2932e4601b27dee0a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUQ2OjMwRTZFNToxQzYyNURCOjI2Q0RCRTU6Njk2QUJEQUEiLCJ2aXNpdG9yX2lkIjoiNzg5MzQ5Njc3MjA1NzMyNzc4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 3e1ff7b605ce84944ef1ae11bf8971f178ae53d1e5d8af2f07515354e272f133 |
| hovercard-subject-tag | pull_request:198444336 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-consul/python-consul/pull/217/checks |
| twitter:image | https://avatars.githubusercontent.com/u/684915?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/684915?s=400&v=4 |
| og:image:alt | Basically I need python-consul to work with this: # env | grep CONSUL_HTTP_ADDR CONSUL_HTTP_ADDR=unix:///var/run/consul/http.sock Just like the consul cli does. Unfortunately I had to change a lot ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b |
| turbo-cache-control | no-preview |
| go-import | github.com/python-consul/python-consul git https://github.com/python-consul/python-consul.git |
| octolytics-dimension-user_id | 143416393 |
| octolytics-dimension-user_login | python-consul |
| octolytics-dimension-repository_id | 24473148 |
| octolytics-dimension-repository_nwo | python-consul/python-consul |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24473148 |
| octolytics-dimension-repository_network_root_nwo | python-consul/python-consul |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 30300f30bb3949de255e84a146706a3bdb5c19c9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width