Title: Environment variables should not have precedence over `Consul` constructor arguments · Issue #192 · python-consul/python-consul · GitHub
Open Graph Title: Environment variables should not have precedence over `Consul` constructor arguments · Issue #192 · python-consul/python-consul
X Title: Environment variables should not have precedence over `Consul` constructor arguments · Issue #192 · python-consul/python-consul
Description: The token passed in as an argument in the constructor is overriden by the CONSUL_HTTP_TOKEN (if set): https://github.com/cablehead/python-consul/blob/d056ff5c4efc6a5642775ad66600864e3f0f6cbc/consul/base.py#L311 The same is true with the ...
Open Graph Description: The token passed in as an argument in the constructor is overriden by the CONSUL_HTTP_TOKEN (if set): https://github.com/cablehead/python-consul/blob/d056ff5c4efc6a5642775ad66600864e3f0f6cbc/consul...
X Description: The token passed in as an argument in the constructor is overriden by the CONSUL_HTTP_TOKEN (if set): https://github.com/cablehead/python-consul/blob/d056ff5c4efc6a5642775ad66600864e3f0f6cbc/consul...
Opengraph URL: https://github.com/python-consul/python-consul/issues/192
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Environment variables should not have precedence over `Consul` constructor arguments ","articleBody":"The token passed in as an argument in the constructor is overriden by the `CONSUL_HTTP_TOKEN` (if set): https://github.com/cablehead/python-consul/blob/d056ff5c4efc6a5642775ad66600864e3f0f6cbc/consul/base.py#L311\r\n\r\nThe same is true with the host and port (and others!):\r\nhttps://github.com/cablehead/python-consul/blob/d056ff5c4efc6a5642775ad66600864e3f0f6cbc/consul/base.py#L297-L299\r\n\r\nI would argue that this is not the behaviour most would expect. It would be better if the precedence order was `argument \u003e env \u003e default`.","author":{"url":"https://github.com/colin-nolan","@type":"Person","name":"colin-nolan"},"datePublished":"2018-02-07T11:31:35.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/192/python-consul/issues/192"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:264def33-5c19-6d37-4410-e8a4797d46a0 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | ECB8:115F21:31E210:421537:696B6752 |
| html-safe-nonce | f7d7ff14e8f3a2e216cacff5c411372df347807643e6b51662d8ff426e1f3cc5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0I4OjExNUYyMTozMUUyMTA6NDIxNTM3OjY5NkI2NzUyIiwidmlzaXRvcl9pZCI6IjExNjY1MDY0NTc4Njc5NzAzODYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c39b6f983ecae6eb1fa8cf47657375e33c4bfeb7723f6989be31565d6f4013d7 |
| hovercard-subject-tag | issue:295103511 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-consul/python-consul/192/issue_layout |
| twitter:image | https://opengraph.githubassets.com/44875507e0c0fdfe50286e5779ae517c40974eeb7ee3137519b301e03ea43494/python-consul/python-consul/issues/192 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/44875507e0c0fdfe50286e5779ae517c40974eeb7ee3137519b301e03ea43494/python-consul/python-consul/issues/192 |
| og:image:alt | The token passed in as an argument in the constructor is overriden by the CONSUL_HTTP_TOKEN (if set): https://github.com/cablehead/python-consul/blob/d056ff5c4efc6a5642775ad66600864e3f0f6cbc/consul... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | colin-nolan |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/python-consul/python-consul git https://github.com/python-consul/python-consul.git |
| octolytics-dimension-user_id | 143416393 |
| octolytics-dimension-user_login | python-consul |
| octolytics-dimension-repository_id | 24473148 |
| octolytics-dimension-repository_nwo | python-consul/python-consul |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24473148 |
| octolytics-dimension-repository_network_root_nwo | python-consul/python-consul |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width