Title: Fix SAML ticket verification failing when response is not namespaced by mbenadda · Pull Request #39 · python-cas/python-cas · GitHub
Open Graph Title: Fix SAML ticket verification failing when response is not namespaced by mbenadda · Pull Request #39 · python-cas/python-cas
X Title: Fix SAML ticket verification failing when response is not namespaced by mbenadda · Pull Request #39 · python-cas/python-cas
Description: Hi, I've encountered a problem where responses would be treated as though login had failed when they contained a Success status code. I was able to track it down to ticket verification picking up status codes ending with ':Success'. This works fine when the response is namespaced (eg the code is ns2:Success) but not otherwise (the code is Success). As far as I know, namespacing of the soap response is not necessary. If the response is not namespaced, the ":" in the string matcher will cause the client to fail authentication when it had succeeded. I think we can safely remove the : in the expected status code end substring to support non namespaced responses.
Open Graph Description: Hi, I've encountered a problem where responses would be treated as though login had failed when they contained a Success status code. I was able to track it down to ticket verification picking ...
X Description: Hi, I've encountered a problem where responses would be treated as though login had failed when they contained a Success status code. I was able to track it down to ticket verification pick...
Opengraph URL: https://github.com/python-cas/python-cas/pull/39
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:67c94f53-dc24-0deb-a37b-acacad6c63f4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B43E:E616D:2571FF2:329305B:6981CBBE |
| html-safe-nonce | 40227d81d230ef8643a9718fc6dc1e5eb6874886bc40b6657d2418f74f308025 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDNFOkU2MTZEOjI1NzFGRjI6MzI5MzA1Qjo2OTgxQ0JCRSIsInZpc2l0b3JfaWQiOiIxMzA5NDAyNDcyMjMzNjgzOTAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | fca7116818c84035b92b8af9d137f60ee608230603e8064edfaa5f8bdb4d8d80 |
| hovercard-subject-tag | pull_request:395767367 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-cas/python-cas/pull/39/files |
| twitter:image | https://avatars.githubusercontent.com/u/1932937?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1932937?s=400&v=4 |
| og:image:alt | Hi, I've encountered a problem where responses would be treated as though login had failed when they contained a Success status code. I was able to track it down to ticket verification picking ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 95dd6eb30a064b87bd2c653e622fe2eb6a2ec1d12751c5463c252220548e75a4 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python-cas/python-cas git https://github.com/python-cas/python-cas.git |
| octolytics-dimension-user_id | 12914971 |
| octolytics-dimension-user_login | python-cas |
| octolytics-dimension-repository_id | 37541882 |
| octolytics-dimension-repository_nwo | python-cas/python-cas |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 37541882 |
| octolytics-dimension-repository_network_root_nwo | python-cas/python-cas |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7f9fe298cbc605034955dde47054b68dbf531efd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width