René's URL Explorer Experiment


Title: Fix SAML ticket verification failing when response is not namespaced by mbenadda · Pull Request #39 · python-cas/python-cas · GitHub

Open Graph Title: Fix SAML ticket verification failing when response is not namespaced by mbenadda · Pull Request #39 · python-cas/python-cas

X Title: Fix SAML ticket verification failing when response is not namespaced by mbenadda · Pull Request #39 · python-cas/python-cas

Description: Hi, I've encountered a problem where responses would be treated as though login had failed when they contained a Success status code. I was able to track it down to ticket verification picking up status codes ending with ':Success'. This works fine when the response is namespaced (eg the code is ns2:Success) but not otherwise (the code is Success). As far as I know, namespacing of the soap response is not necessary. If the response is not namespaced, the ":" in the string matcher will cause the client to fail authentication when it had succeeded. I think we can safely remove the : in the expected status code end substring to support non namespaced responses.

Open Graph Description: Hi, I've encountered a problem where responses would be treated as though login had failed when they contained a Success status code. I was able to track it down to ticket verification picking ...

X Description: Hi, I've encountered a problem where responses would be treated as though login had failed when they contained a Success status code. I was able to track it down to ticket verification pick...

Opengraph URL: https://github.com/python-cas/python-cas/pull/39

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:5d5bde49-11d3-ce99-55d4-3eb8db333352
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-id98B6:317F00:1979ED6:21EFC32:6981AD35
html-safe-nonce292062688a683529a27d84982f285415047a95af917bc01b738e13d25ff09080
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OEI2OjMxN0YwMDoxOTc5RUQ2OjIxRUZDMzI6Njk4MUFEMzUiLCJ2aXNpdG9yX2lkIjoiNDkwNTk4ODk2MDQxNDcwNjk5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac29389bf8685acf95f3418fa2ed805f3100f384a546e6090414376212b674ec3c
hovercard-subject-tagpull_request:395767367
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-cas/python-cas/pull/39/checks
twitter:imagehttps://avatars.githubusercontent.com/u/1932937?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1932937?s=400&v=4
og:image:altHi, I've encountered a problem where responses would be treated as though login had failed when they contained a Success status code. I was able to track it down to ticket verification picking ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee137814e266030874fd2c86863529d0622b13889eeda04148c57654b6ea84ad6
turbo-cache-controlno-preview
go-importgithub.com/python-cas/python-cas git https://github.com/python-cas/python-cas.git
octolytics-dimension-user_id12914971
octolytics-dimension-user_loginpython-cas
octolytics-dimension-repository_id37541882
octolytics-dimension-repository_nwopython-cas/python-cas
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id37541882
octolytics-dimension-repository_network_root_nwopython-cas/python-cas
turbo-body-classeslogged-out env-production page-responsive full-width full-width-p-0
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedd58d68a7813bbec9c91422c8c35f4af33832d70
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-cas/python-cas/pull/39/checks#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-cas%2Fpython-cas%2Fpull%2F39%2Fchecks
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-cas%2Fpython-cas%2Fpull%2F39%2Fchecks
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=python-cas%2Fpython-cas
Reloadhttps://github.com/python-cas/python-cas/pull/39/checks
Reloadhttps://github.com/python-cas/python-cas/pull/39/checks
Reloadhttps://github.com/python-cas/python-cas/pull/39/checks
python-cas https://github.com/python-cas
python-cashttps://github.com/python-cas/python-cas
Notifications https://github.com/login?return_to=%2Fpython-cas%2Fpython-cas
Fork 48 https://github.com/login?return_to=%2Fpython-cas%2Fpython-cas
Star 101 https://github.com/login?return_to=%2Fpython-cas%2Fpython-cas
Code https://github.com/python-cas/python-cas
Issues 6 https://github.com/python-cas/python-cas/issues
Pull requests 0 https://github.com/python-cas/python-cas/pulls
Actions https://github.com/python-cas/python-cas/actions
Projects 0 https://github.com/python-cas/python-cas/projects
Wiki https://github.com/python-cas/python-cas/wiki
Security 0 https://github.com/python-cas/python-cas/security
Insights https://github.com/python-cas/python-cas/pulse
Code https://github.com/python-cas/python-cas
Issues https://github.com/python-cas/python-cas/issues
Pull requests https://github.com/python-cas/python-cas/pulls
Actions https://github.com/python-cas/python-cas/actions
Projects https://github.com/python-cas/python-cas/projects
Wiki https://github.com/python-cas/python-cas/wiki
Security https://github.com/python-cas/python-cas/security
Insights https://github.com/python-cas/python-cas/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-cas%2Fpython-cas%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-cas%2Fpython-cas%2Fissues%2Fnew%2Fchoose
mingchenhttps://github.com/mingchen
python-cas:masterhttps://github.com/python-cas/python-cas/tree/master
mbenadda:fix-saml-ticket-verificationhttps://github.com/mbenadda/python-cas/tree/fix-saml-ticket-verification
Conversation 4 https://github.com/python-cas/python-cas/pull/39
Commits 1 https://github.com/python-cas/python-cas/pull/39/commits
Checks 0 https://github.com/python-cas/python-cas/pull/39/checks
Files changed https://github.com/python-cas/python-cas/pull/39/files
Please reload this pagehttps://github.com/python-cas/python-cas/pull/39/checks
Please reload this pagehttps://github.com/python-cas/python-cas/pull/39/checks
Fix SAML ticket verification failing when response is not namespaced https://github.com/python-cas/python-cas/pull/39/checks#top
Please reload this pagehttps://github.com/python-cas/python-cas/pull/39/checks
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.