René's URL Explorer Experiment


Title: Fix how type parameters are collected from parametrized `Protocol` bases by brianschubert · Pull Request #667 · python/typing_extensions · GitHub

Open Graph Title: Fix how type parameters are collected from parametrized `Protocol` bases by brianschubert · Pull Request #667 · python/typing_extensions

X Title: Fix how type parameters are collected from parametrized `Protocol` bases by brianschubert · Pull Request #667 · python/typing_extensions

Description: Fixes #636, backport of python/cpython#137281 Added some inline comments about the implementation below.

Open Graph Description: Fixes #636, backport of python/cpython#137281 Added some inline comments about the implementation below.

X Description: Fixes #636, backport of python/cpython#137281 Added some inline comments about the implementation below.

Opengraph URL: https://github.com/python/typing_extensions/pull/667

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b7efaf86-198e-b8dd-159b-7edc07764e7d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8254:36099A:12DDA01:1A70C09:696A3E9D
html-safe-nonce9d3695447b79b7e647836fc8143bdff1d4e9c785acf5443f26fa4e00549a66ec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjU0OjM2MDk5QToxMkREQTAxOjFBNzBDMDk6Njk2QTNFOUQiLCJ2aXNpdG9yX2lkIjoiMjA1NDU2NTAxNzMyMTg4MTI0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace1537b469d47609e1d09e2b53e2dd91144276b93de4e7fa158350664eed2f807
hovercard-subject-tagpull_request:2790537215
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/typing_extensions/667/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/04a83d6428325c087a7ea31afc48f199d4f991dab0fe608f090d2da4d387bb10/python/typing_extensions/pull/667
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/04a83d6428325c087a7ea31afc48f199d4f991dab0fe608f090d2da4d387bb10/python/typing_extensions/pull/667
og:image:altFixes #636, backport of python/cpython#137281 Added some inline comments about the implementation below.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebrianschubert
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
go-importgithub.com/python/typing_extensions git https://github.com/python/typing_extensions.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id494077289
octolytics-dimension-repository_nwopython/typing_extensions
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id494077289
octolytics-dimension-repository_network_root_nwopython/typing_extensions
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release13581a31d51edf4a3aca179e10890a4d4f9b6d76
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typing_extensions/pull/667#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping_extensions%2Fpull%2F667
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping_extensions%2Fpull%2F667
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Ftyping_extensions
Reloadhttps://github.com/python/typing_extensions/pull/667
Reloadhttps://github.com/python/typing_extensions/pull/667
Reloadhttps://github.com/python/typing_extensions/pull/667
python https://github.com/python
typing_extensionshttps://github.com/python/typing_extensions
Please reload this pagehttps://github.com/python/typing_extensions/pull/667
Notifications https://github.com/login?return_to=%2Fpython%2Ftyping_extensions
Fork 133 https://github.com/login?return_to=%2Fpython%2Ftyping_extensions
Star 544 https://github.com/login?return_to=%2Fpython%2Ftyping_extensions
Code https://github.com/python/typing_extensions
Issues 18 https://github.com/python/typing_extensions/issues
Pull requests 10 https://github.com/python/typing_extensions/pulls
Actions https://github.com/python/typing_extensions/actions
Projects 0 https://github.com/python/typing_extensions/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/typing_extensions/security
Please reload this pagehttps://github.com/python/typing_extensions/pull/667
Insights https://github.com/python/typing_extensions/pulse
Code https://github.com/python/typing_extensions
Issues https://github.com/python/typing_extensions/issues
Pull requests https://github.com/python/typing_extensions/pulls
Actions https://github.com/python/typing_extensions/actions
Projects https://github.com/python/typing_extensions/projects
Security https://github.com/python/typing_extensions/security
Insights https://github.com/python/typing_extensions/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftyping_extensions%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftyping_extensions%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/typing_extensions/pull/667#issue-comment-box
brianschuberthttps://github.com/brianschubert
python:mainhttps://github.com/python/typing_extensions/tree/main
brianschubert:gh-636-backport-137281-param-orderhttps://github.com/brianschubert/typing_extensions/tree/gh-636-backport-137281-param-order
Fix how type parameters are collected from parametrized Protocol bases https://github.com/python/typing_extensions/pull/667#top
brianschuberthttps://github.com/brianschubert
python:mainhttps://github.com/python/typing_extensions/tree/main
brianschubert:gh-636-backport-137281-param-orderhttps://github.com/brianschubert/typing_extensions/tree/gh-636-backport-137281-param-order
Conversation 5 https://github.com/python/typing_extensions/pull/667
Commits 4 https://github.com/python/typing_extensions/pull/667/commits
Checks 22 https://github.com/python/typing_extensions/pull/667/checks
Files changed 3 https://github.com/python/typing_extensions/pull/667/files
https://github.co/hiddenchars
https://github.com/python/typing_extensions/pull/{{ revealButtonHref }}
https://github.com/brianschubert
brianschuberthttps://github.com/brianschubert
Sep 1, 2025https://github.com/python/typing_extensions/pull/667#issue-3373505706
Please reload this pagehttps://github.com/python/typing_extensions/pull/667
#636https://github.com/python/typing_extensions/issues/636
python/cpython#137281https://github.com/python/cpython/pull/137281
Please reload this pagehttps://github.com/python/typing_extensions/pull/667
brianschuberthttps://github.com/brianschubert
September 1, 2025 14:28https://github.com/python/typing_extensions/pull/667#commits-pushed-db5c0c0
https://github.com/brianschubert
Fix how type parameters are collected from Protocol baseshttps://github.com/python/typing_extensions/pull/667/commits/db5c0c0b2646f99ff45816f6b9f579239c2fa4e3
db5c0c0https://github.com/python/typing_extensions/pull/667/commits/db5c0c0b2646f99ff45816f6b9f579239c2fa4e3
https://github.com/brianschubert
Add changelog entryhttps://github.com/python/typing_extensions/pull/667/commits/9023129ca4b4bb0dd624b6b39d8d674df3f82d0e
9023129https://github.com/python/typing_extensions/pull/667/commits/9023129ca4b4bb0dd624b6b39d8d674df3f82d0e
https://github.com/brianschubert
brianschuberthttps://github.com/brianschubert
Sep 1, 2025 https://github.com/python/typing_extensions/pull/667#pullrequestreview-3174343638
View reviewed changes https://github.com/python/typing_extensions/pull/667/files/9023129ca4b4bb0dd624b6b39d8d674df3f82d0e
src/typing_extensions.pyhttps://github.com/python/typing_extensions/pull/667/files/9023129ca4b4bb0dd624b6b39d8d674df3f82d0e#diff-2e398129239518dc82985bc023ce5fb83df781e9f84098cfe1415bdd6d7ac59f
brianschuberthttps://github.com/brianschubert
Sep 1, 2025https://github.com/python/typing_extensions/pull/667#discussion_r2314447598
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
python/cpython#26091https://github.com/python/cpython/pull/26091
Please reload this pagehttps://github.com/python/typing_extensions/pull/667
src/typing_extensions.pyhttps://github.com/python/typing_extensions/pull/667/files/9023129ca4b4bb0dd624b6b39d8d674df3f82d0e#diff-2e398129239518dc82985bc023ce5fb83df781e9f84098cfe1415bdd6d7ac59f
brianschuberthttps://github.com/brianschubert
Sep 1, 2025https://github.com/python/typing_extensions/pull/667#discussion_r2314448408
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#392https://github.com/python/typing_extensions/pull/392
Please reload this pagehttps://github.com/python/typing_extensions/pull/667
src/typing_extensions.pyhttps://github.com/python/typing_extensions/pull/667/files/9023129ca4b4bb0dd624b6b39d8d674df3f82d0e#diff-2e398129239518dc82985bc023ce5fb83df781e9f84098cfe1415bdd6d7ac59f
brianschuberthttps://github.com/brianschubert
Sep 1, 2025https://github.com/python/typing_extensions/pull/667#discussion_r2314448733
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typing_extensions/pull/667
src/typing_extensions.pyhttps://github.com/python/typing_extensions/pull/667/files/9023129ca4b4bb0dd624b6b39d8d674df3f82d0e#diff-2e398129239518dc82985bc023ce5fb83df781e9f84098cfe1415bdd6d7ac59f
brianschuberthttps://github.com/brianschubert
Sep 1, 2025https://github.com/python/typing_extensions/pull/667#discussion_r2314449616
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
python/cpython#118900https://github.com/python/cpython/pull/118900
Please reload this pagehttps://github.com/python/typing_extensions/pull/667
brianschuberthttps://github.com/brianschubert
September 5, 2025 17:21https://github.com/python/typing_extensions/pull/667#commits-pushed-858f1f5
https://github.com/brianschubert
Merge branch 'main' intohttps://github.com/python/typing_extensions/pull/667/commits/858f1f5730bf65eccd27578316f48f2d18c48aa6
pythongh-636https://github.com/python/typing_extensions/issues/636
-backport-137281-param-orderhttps://github.com/python/typing_extensions/pull/667/commits/858f1f5730bf65eccd27578316f48f2d18c48aa6
858f1f5https://github.com/python/typing_extensions/pull/667/commits/858f1f5730bf65eccd27578316f48f2d18c48aa6
https://github.com/brianschubert
Merge branch 'main' intohttps://github.com/python/typing_extensions/pull/667/commits/d748b5dc8e6d5c91dc42a574691b2d76e264fde1
pythongh-636https://github.com/python/typing_extensions/issues/636
-backport-137281-param-orderhttps://github.com/python/typing_extensions/pull/667/commits/d748b5dc8e6d5c91dc42a574691b2d76e264fde1
d748b5dhttps://github.com/python/typing_extensions/pull/667/commits/d748b5dc8e6d5c91dc42a574691b2d76e264fde1
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 9, 2025https://github.com/python/typing_extensions/pull/667#issuecomment-3271376491
Please reload this pagehttps://github.com/python/typing_extensions/pull/667
Codecovhttps://app.codecov.io/gh/python/typing_extensions/pull/667?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python
4f42e6bhttps://app.codecov.io/gh/python/typing_extensions/commit/4f42e6bf0052129bc6dae5e71699a409652d2091?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python
d748b5dhttps://app.codecov.io/gh/python/typing_extensions/commit/d748b5dc8e6d5c91dc42a574691b2d76e264fde1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python
Files with missing lineshttps://app.codecov.io/gh/python/typing_extensions/pull/667?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python
src/typing_extensions.pyhttps://app.codecov.io/gh/python/typing_extensions/pull/667?src=pr&el=tree&filepath=src%2Ftyping_extensions.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python#diff-c3JjL3R5cGluZ19leHRlbnNpb25zLnB5
5 Missing ⚠️ https://app.codecov.io/gh/python/typing_extensions/pull/667?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python
Flaghttps://app.codecov.io/gh/python/typing_extensions/pull/667/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python
3.10https://app.codecov.io/gh/python/typing_extensions/pull/667/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python
3.10.4https://app.codecov.io/gh/python/typing_extensions/pull/667/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python
3.11https://app.codecov.io/gh/python/typing_extensions/pull/667/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python
3.11.0https://app.codecov.io/gh/python/typing_extensions/pull/667/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python
3.12https://app.codecov.io/gh/python/typing_extensions/pull/667/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python
3.12.0https://app.codecov.io/gh/python/typing_extensions/pull/667/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python
3.13https://app.codecov.io/gh/python/typing_extensions/pull/667/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python
3.13.0https://app.codecov.io/gh/python/typing_extensions/pull/667/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python
3.14https://app.codecov.io/gh/python/typing_extensions/pull/667/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python
3.9https://app.codecov.io/gh/python/typing_extensions/pull/667/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python
3.9.12https://app.codecov.io/gh/python/typing_extensions/pull/667/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python
pypy3.10https://app.codecov.io/gh/python/typing_extensions/pull/667/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python
pypy3.11https://app.codecov.io/gh/python/typing_extensions/pull/667/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python
pypy3.9https://app.codecov.io/gh/python/typing_extensions/pull/667/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python
Click herehttps://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python#carryforward-flags-in-the-pull-request-comment
Files with missing lineshttps://app.codecov.io/gh/python/typing_extensions/pull/667?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python
src/test_typing_extensions.pyhttps://app.codecov.io/gh/python/typing_extensions/pull/667?src=pr&el=tree&filepath=src%2Ftest_typing_extensions.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python#diff-c3JjL3Rlc3RfdHlwaW5nX2V4dGVuc2lvbnMucHk=
src/typing_extensions.pyhttps://app.codecov.io/gh/python/typing_extensions/pull/667?src=pr&el=tree&filepath=src%2Ftyping_extensions.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python#diff-c3JjL3R5cGluZ19leHRlbnNpb25zLnB5
Test Analyticshttps://docs.codecov.com/docs/test-analytics
Please reload this pagehttps://github.com/python/typing_extensions/pull/667
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping_extensions%2Fpull%2F667
TypeError when omitting a Protocol type argument with default https://github.com/python/typing_extensions/issues/636
Please reload this pagehttps://github.com/python/typing_extensions/pull/667
https://github.com/brianschubert
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.