René's URL Explorer Experiment


Title: Fix isinstance() for Protocols by ilevkivskyi · Pull Request #330 · python/typing · GitHub

Open Graph Title: Fix isinstance() for Protocols by ilevkivskyi · Pull Request #330 · python/typing

X Title: Fix isinstance() for Protocols by ilevkivskyi · Pull Request #330 · python/typing

Description: Fixes #297 This allows to use isinstance() with classes that inherit from protocols in typing.py such as SupportsInt etc. @gvanrossum I was thinking about how protocols should work (including runtime), and now I think that the "quick-fix" that you proposed is actually the right fix for this issue. (Main motivation is that a class that inherits from a protocol should not be considered a protocol itself, unless it lists Protocol in bases.) Please, take a look.

Open Graph Description: Fixes #297 This allows to use isinstance() with classes that inherit from protocols in typing.py such as SupportsInt etc. @gvanrossum I was thinking about how protocols should work (including runti...

X Description: Fixes #297 This allows to use isinstance() with classes that inherit from protocols in typing.py such as SupportsInt etc. @gvanrossum I was thinking about how protocols should work (including runti...

Opengraph URL: https://github.com/python/typing/pull/330

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4b71f6dc-301e-3fb6-c60a-52062f6c3d46
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD87A:283776:31E05A:4313A8:6B0026D8
html-safe-nonce03151858a38c3eb270a10edd67c080367d97d1ff9fa54ef622faec7a3ea98ff5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODdBOjI4Mzc3NjozMUUwNUE6NDMxM0E4OjZCMDAyNkQ4IiwidmlzaXRvcl9pZCI6IjY2NjAzNjIxMjQ1MTE5NDY0NTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca49bcbc78cf222c0b5ada7a696c918f207643c03d34bf45eda82bccdf1ce4f9a
hovercard-subject-tagpull_request:94480542
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/typing/pull/330/files
twitter:imagehttps://avatars.githubusercontent.com/u/12005495?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/12005495?s=400&v=4
og:image:altFixes #297 This allows to use isinstance() with classes that inherit from protocols in typing.py such as SupportsInt etc. @gvanrossum I was thinking about how protocols should work (including runti...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/typing git https://github.com/python/typing.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id24604008
octolytics-dimension-repository_nwopython/typing
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24604008
octolytics-dimension-repository_network_root_nwopython/typing
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typing/pull/330/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F330%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F330%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftyping
Reloadhttps://github.com/python/typing/pull/330/files
Reloadhttps://github.com/python/typing/pull/330/files
Reloadhttps://github.com/python/typing/pull/330/files
pythonhttps://github.com/python
typinghttps://github.com/python/typing
Codehttps://github.com/python/typing
Issues206 (206)https://github.com/python/typing/issues
Pull requests27 (27)https://github.com/python/typing/pulls
Discussionshttps://github.com/python/typing/discussions
Actionshttps://github.com/python/typing/actions
Security and qualityhttps://github.com/python/typing/security
Insightshttps://github.com/python/typing/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftyping%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftyping%2Fissues%2Fnew%2Fchoose
gvanrossumhttps://github.com/gvanrossum
python:masterhttps://github.com/python/typing/tree/master
ilevkivskyi:fix-protocolshttps://github.com/ilevkivskyi/typehinting/tree/fix-protocols
Conversation 0 https://github.com/python/typing/pull/330
Commits 1 https://github.com/python/typing/pull/330/commits
Checks 0 https://github.com/python/typing/pull/330/checks
Files changed https://github.com/python/typing/pull/330/files
Please reload this pagehttps://github.com/python/typing/pull/330/files
Fix isinstance() for Protocols https://github.com/python/typing/pull/330/files#top
Show all changes 1 commit https://github.com/python/typing/pull/330/files
93fcc04 Fix isinstance() for Protocols ilevkivskyi Nov 19, 2016 https://github.com/python/typing/pull/330/commits/93fcc04db7d047961c7d5f999d4d18911b6941d6
Clear filters https://github.com/python/typing/pull/330/files
Please reload this pagehttps://github.com/python/typing/pull/330/files
Please reload this pagehttps://github.com/python/typing/pull/330/files
test_typing.py https://github.com/python/typing/pull/330/files#diff-f23c53e6fa002cdeac74b9499d744b9492bfd34a58ce281c2b5076e628d0083a
typing.py https://github.com/python/typing/pull/330/files#diff-cbea31cd6366bdaf7805202979325ba4b14a29613bb7aeaecf9a18e94ea93619
test_typing.py https://github.com/python/typing/pull/330/files#diff-e618ee6a4894a62d9269e41c4dc836e31e8224cfb66b5be3b325f4798ec245e3
typing.py https://github.com/python/typing/pull/330/files#diff-ad6da8dfad5c336100410e57073641a0266b69e1801476d2b1e593b2c04f81f5
python2/test_typing.pyhttps://github.com/python/typing/pull/330/files#diff-f23c53e6fa002cdeac74b9499d744b9492bfd34a58ce281c2b5076e628d0083a
View file https://github.com/ilevkivskyi/typehinting/blob/93fcc04db7d047961c7d5f999d4d18911b6941d6/python2/test_typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/330/{{ revealButtonHref }}
https://github.com/python/typing/pull/330/files#diff-f23c53e6fa002cdeac74b9499d744b9492bfd34a58ce281c2b5076e628d0083a
https://github.com/python/typing/pull/330/files#diff-f23c53e6fa002cdeac74b9499d744b9492bfd34a58ce281c2b5076e628d0083a
python2/typing.pyhttps://github.com/python/typing/pull/330/files#diff-cbea31cd6366bdaf7805202979325ba4b14a29613bb7aeaecf9a18e94ea93619
View file https://github.com/ilevkivskyi/typehinting/blob/93fcc04db7d047961c7d5f999d4d18911b6941d6/python2/typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/330/{{ revealButtonHref }}
https://github.com/python/typing/pull/330/files#diff-cbea31cd6366bdaf7805202979325ba4b14a29613bb7aeaecf9a18e94ea93619
https://github.com/python/typing/pull/330/files#diff-cbea31cd6366bdaf7805202979325ba4b14a29613bb7aeaecf9a18e94ea93619
src/test_typing.pyhttps://github.com/python/typing/pull/330/files#diff-e618ee6a4894a62d9269e41c4dc836e31e8224cfb66b5be3b325f4798ec245e3
View file https://github.com/ilevkivskyi/typehinting/blob/93fcc04db7d047961c7d5f999d4d18911b6941d6/src/test_typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/330/{{ revealButtonHref }}
https://github.com/python/typing/pull/330/files#diff-e618ee6a4894a62d9269e41c4dc836e31e8224cfb66b5be3b325f4798ec245e3
https://github.com/python/typing/pull/330/files#diff-e618ee6a4894a62d9269e41c4dc836e31e8224cfb66b5be3b325f4798ec245e3
src/typing.pyhttps://github.com/python/typing/pull/330/files#diff-ad6da8dfad5c336100410e57073641a0266b69e1801476d2b1e593b2c04f81f5
View file https://github.com/ilevkivskyi/typehinting/blob/93fcc04db7d047961c7d5f999d4d18911b6941d6/src/typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/330/{{ revealButtonHref }}
https://github.com/python/typing/pull/330/files#diff-ad6da8dfad5c336100410e57073641a0266b69e1801476d2b1e593b2c04f81f5
https://github.com/python/typing/pull/330/files#diff-ad6da8dfad5c336100410e57073641a0266b69e1801476d2b1e593b2c04f81f5
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.