René's URL Explorer Experiment


Title: A real fix for issue #250 (failure with mock) by ilevkivskyi · Pull Request #295 · python/typing · GitHub

Open Graph Title: A real fix for issue #250 (failure with mock) by ilevkivskyi · Pull Request #295 · python/typing

X Title: A real fix for issue #250 (failure with mock) by ilevkivskyi · Pull Request #295 · python/typing

Description: @gvanrossum This PR actually fixes #250 The main idea here is optimizing generics for cases where a type information is added to existing code. Now: Node[int] and Node have identical __bases__ and identical __mro__[1:] (except for the first item, since it is the class itself). After addition of typing information (i.e. making some classes generic), __mro__ is changed very little, at most one bare Generic appears in __mro__. Consequently, only non-parameterized generics appear in __bases__ and __mro__[1:]. Interestingly, this could be achieved in few lines of code and no existing test break. On the positive side of this approach, there is very little chance that existing code (even with sophisticated "magic") will break after addition of typing information. On the negative side, it will be more difficult for runtime type-checkers to perform decorator-based type checks (e.g. enforce method overriding only by consistent methods). Essentially, now type erasure happens partially at the class creation time (all bases are reduced to origin).

Open Graph Description: @gvanrossum This PR actually fixes #250 The main idea here is optimizing generics for cases where a type information is added to existing code. Now: Node[int] and Node have identical __bases__ and...

X Description: @gvanrossum This PR actually fixes #250 The main idea here is optimizing generics for cases where a type information is added to existing code. Now: Node[int] and Node have identical __bases__ and...

Opengraph URL: https://github.com/python/typing/pull/295

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9a49bc8d-daec-4a76-511d-3c8b6c65c8a8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC1C:30CC09:214C50D:2CF3AE4:6B001A8B
html-safe-nonce4d357310fb2a9e4d06b6cd38540fa5303d8385cf1e72bb885c0d697ff56216b1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzFDOjMwQ0MwOToyMTRDNTBEOjJDRjNBRTQ6NkIwMDFBOEIiLCJ2aXNpdG9yX2lkIjoiNzc2MDA4ODM0NjAzMzkyMDY1MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc72b8bddec11ea534ccddf543213f3ca75a1b8a600f27e5545336ef8a6f73b9f
hovercard-subject-tagpull_request:88596087
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/typing/pull/295/files
twitter:imagehttps://avatars.githubusercontent.com/u/12005495?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/12005495?s=400&v=4
og:image:alt@gvanrossum This PR actually fixes #250 The main idea here is optimizing generics for cases where a type information is added to existing code. Now: Node[int] and Node have identical __bases__ and...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonea2dd2291b1b13cc9c06f27ec92fa3dbaf34116fc24c9347b8539db61884c59f4
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/typing git https://github.com/python/typing.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id24604008
octolytics-dimension-repository_nwopython/typing
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24604008
octolytics-dimension-repository_network_root_nwopython/typing
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release70121d4e855ee0bb7b75cf15d061d91f8863c0f8
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typing/pull/295/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F295%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F295%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftyping
Reloadhttps://github.com/python/typing/pull/295/files
Reloadhttps://github.com/python/typing/pull/295/files
Reloadhttps://github.com/python/typing/pull/295/files
pythonhttps://github.com/python
typinghttps://github.com/python/typing
Codehttps://github.com/python/typing
Issues206 (206)https://github.com/python/typing/issues
Pull requests27 (27)https://github.com/python/typing/pulls
Discussionshttps://github.com/python/typing/discussions
Actionshttps://github.com/python/typing/actions
Security and qualityhttps://github.com/python/typing/security
Insightshttps://github.com/python/typing/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftyping%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftyping%2Fissues%2Fnew%2Fchoose
gvanrossumhttps://github.com/gvanrossum
python:masterhttps://github.com/python/typing/tree/master
ilevkivskyi:masterhttps://github.com/ilevkivskyi/typehinting/tree/master
Conversation 23 https://github.com/python/typing/pull/295
Commits 6 https://github.com/python/typing/pull/295/commits
Checks 0 https://github.com/python/typing/pull/295/checks
Files changed https://github.com/python/typing/pull/295/files
Please reload this pagehttps://github.com/python/typing/pull/295/files
A real fix for issue #250 (failure with mock) https://github.com/python/typing/pull/295/files#top
Show all changes 6 commits https://github.com/python/typing/pull/295/files
b07b8ea A real fix for #250 ilevkivskyi Oct 9, 2016 https://github.com/python/typing/pull/295/commits/b07b8eab3429a802f44ea7ebf09f614c6efc9642
eb7801b Use _gorg for the case of multiply parameterized generics ilevkivskyi Oct 9, 2016 https://github.com/python/typing/pull/295/commits/eb7801bb3d96643ffa0f943cb6f685795eb27946
be5d7ed Formatting ilevkivskyi Oct 9, 2016 https://github.com/python/typing/pull/295/commits/be5d7ed51aebe7ad5e65f985ffe835c868a7611c
63482fa Response to comments + some tests ilevkivskyi Oct 10, 2016 https://github.com/python/typing/pull/295/commits/63482faf6775d68f6de073a3a2d7e506949e809e
307bf64 Add tests illustrating new dunder attributes; preserve initial class … ilevkivskyi Oct 16, 2016 https://github.com/python/typing/pull/295/commits/307bf649e54a72842f59dfa6b3b62aa49c28450d
f4932bb Response to comments ilevkivskyi Oct 20, 2016 https://github.com/python/typing/pull/295/commits/f4932bb33887448615bcb27098341b74786b0b4d
Clear filters https://github.com/python/typing/pull/295/files
Please reload this pagehttps://github.com/python/typing/pull/295/files
Please reload this pagehttps://github.com/python/typing/pull/295/files
test_typing.py https://github.com/python/typing/pull/295/files#diff-f23c53e6fa002cdeac74b9499d744b9492bfd34a58ce281c2b5076e628d0083a
typing.py https://github.com/python/typing/pull/295/files#diff-cbea31cd6366bdaf7805202979325ba4b14a29613bb7aeaecf9a18e94ea93619
test_typing.py https://github.com/python/typing/pull/295/files#diff-e618ee6a4894a62d9269e41c4dc836e31e8224cfb66b5be3b325f4798ec245e3
typing.py https://github.com/python/typing/pull/295/files#diff-ad6da8dfad5c336100410e57073641a0266b69e1801476d2b1e593b2c04f81f5
python2/test_typing.pyhttps://github.com/python/typing/pull/295/files#diff-f23c53e6fa002cdeac74b9499d744b9492bfd34a58ce281c2b5076e628d0083a
View file https://github.com/ilevkivskyi/typehinting/blob/f4932bb33887448615bcb27098341b74786b0b4d/python2/test_typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/295/{{ revealButtonHref }}
https://github.com/python/typing/pull/295/files#diff-f23c53e6fa002cdeac74b9499d744b9492bfd34a58ce281c2b5076e628d0083a
https://github.com/python/typing/pull/295/files#diff-f23c53e6fa002cdeac74b9499d744b9492bfd34a58ce281c2b5076e628d0083a
python2/typing.pyhttps://github.com/python/typing/pull/295/files#diff-cbea31cd6366bdaf7805202979325ba4b14a29613bb7aeaecf9a18e94ea93619
View file https://github.com/ilevkivskyi/typehinting/blob/f4932bb33887448615bcb27098341b74786b0b4d/python2/typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/295/{{ revealButtonHref }}
https://github.com/python/typing/pull/295/files#diff-cbea31cd6366bdaf7805202979325ba4b14a29613bb7aeaecf9a18e94ea93619
https://github.com/python/typing/pull/295/files#diff-cbea31cd6366bdaf7805202979325ba4b14a29613bb7aeaecf9a18e94ea93619
https://github.com/python/typing/pull/295/files#diff-cbea31cd6366bdaf7805202979325ba4b14a29613bb7aeaecf9a18e94ea93619
gvanrossumhttps://github.com/gvanrossum
Oct 10, 2016https://github.com/python/typing/pull/295/files#r82630943
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typing/pull/295/files
https://github.com/python/typing/pull/295/files#diff-cbea31cd6366bdaf7805202979325ba4b14a29613bb7aeaecf9a18e94ea93619
https://github.com/python/typing/pull/295/files#diff-cbea31cd6366bdaf7805202979325ba4b14a29613bb7aeaecf9a18e94ea93619
https://github.com/python/typing/pull/295/files#diff-cbea31cd6366bdaf7805202979325ba4b14a29613bb7aeaecf9a18e94ea93619
https://github.com/python/typing/pull/295/files#diff-cbea31cd6366bdaf7805202979325ba4b14a29613bb7aeaecf9a18e94ea93619
https://github.com/python/typing/pull/295/files#diff-cbea31cd6366bdaf7805202979325ba4b14a29613bb7aeaecf9a18e94ea93619
https://github.com/python/typing/pull/295/files#diff-cbea31cd6366bdaf7805202979325ba4b14a29613bb7aeaecf9a18e94ea93619
https://github.com/python/typing/pull/295/files#diff-cbea31cd6366bdaf7805202979325ba4b14a29613bb7aeaecf9a18e94ea93619
src/test_typing.pyhttps://github.com/python/typing/pull/295/files#diff-e618ee6a4894a62d9269e41c4dc836e31e8224cfb66b5be3b325f4798ec245e3
View file https://github.com/ilevkivskyi/typehinting/blob/f4932bb33887448615bcb27098341b74786b0b4d/src/test_typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/295/{{ revealButtonHref }}
https://github.com/python/typing/pull/295/files#diff-e618ee6a4894a62d9269e41c4dc836e31e8224cfb66b5be3b325f4798ec245e3
gvanrossumhttps://github.com/gvanrossum
Oct 14, 2016https://github.com/python/typing/pull/295/files#r83515461
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typing/pull/295/files
ilevkivskyihttps://github.com/ilevkivskyi
Oct 16, 2016https://github.com/python/typing/pull/295/files#r83554287
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typing/pull/295/files
https://github.com/python/typing/pull/295/files#diff-e618ee6a4894a62d9269e41c4dc836e31e8224cfb66b5be3b325f4798ec245e3
src/typing.pyhttps://github.com/python/typing/pull/295/files#diff-ad6da8dfad5c336100410e57073641a0266b69e1801476d2b1e593b2c04f81f5
View file https://github.com/ilevkivskyi/typehinting/blob/f4932bb33887448615bcb27098341b74786b0b4d/src/typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/295/{{ revealButtonHref }}
https://github.com/python/typing/pull/295/files#diff-ad6da8dfad5c336100410e57073641a0266b69e1801476d2b1e593b2c04f81f5
https://github.com/python/typing/pull/295/files#diff-ad6da8dfad5c336100410e57073641a0266b69e1801476d2b1e593b2c04f81f5
https://github.com/python/typing/pull/295/files#diff-ad6da8dfad5c336100410e57073641a0266b69e1801476d2b1e593b2c04f81f5
https://github.com/python/typing/pull/295/files#diff-ad6da8dfad5c336100410e57073641a0266b69e1801476d2b1e593b2c04f81f5
https://github.com/python/typing/pull/295/files#diff-ad6da8dfad5c336100410e57073641a0266b69e1801476d2b1e593b2c04f81f5
https://github.com/python/typing/pull/295/files#diff-ad6da8dfad5c336100410e57073641a0266b69e1801476d2b1e593b2c04f81f5
https://github.com/python/typing/pull/295/files#diff-ad6da8dfad5c336100410e57073641a0266b69e1801476d2b1e593b2c04f81f5
gvanrossumhttps://github.com/gvanrossum
Oct 20, 2016https://github.com/python/typing/pull/295/files#r84392668
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typing/pull/295/files
https://github.com/python/typing/pull/295/files#diff-ad6da8dfad5c336100410e57073641a0266b69e1801476d2b1e593b2c04f81f5
https://github.com/python/typing/pull/295/files#diff-ad6da8dfad5c336100410e57073641a0266b69e1801476d2b1e593b2c04f81f5
https://github.com/python/typing/pull/295/files#diff-ad6da8dfad5c336100410e57073641a0266b69e1801476d2b1e593b2c04f81f5
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.